All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org
Subject: Re: [RFC 4/7] snd-aoa: add codecs
Date: Tue, 30 May 2006 15:48:17 +0200	[thread overview]
Message-ID: <s5hpshvfwta.wl%tiwai@suse.de> (raw)
In-Reply-To: <1148996349.4372.7.camel@johannes>

At Tue, 30 May 2006 15:39:09 +0200,
Johannes Berg wrote:
> 
> On Tue, 2006-05-30 at 15:35 +0200, Takashi Iwai wrote:
> 
> > And I thought the put callbacks in your code always return either 1 or
> > -err?
> 
> Yeah, they return 1 if the change was applied (or no change) and -err if
> there's an error about the change (only in very few cases).
> 
> I figured the extra notification wouldn't hurt, and to the application
> there wouldn't be a problem.

Actually the extra notification won't hurt much in practice.
I've seen that some drivers also don't check the unchanged case and
return always 1, so apparently the apps work.  But, it's of course
better to check the state on the driver side.


Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org
Subject: Re: [Alsa-devel] [RFC 4/7] snd-aoa: add codecs
Date: Tue, 30 May 2006 15:48:17 +0200	[thread overview]
Message-ID: <s5hpshvfwta.wl%tiwai@suse.de> (raw)
In-Reply-To: <1148996349.4372.7.camel@johannes>

At Tue, 30 May 2006 15:39:09 +0200,
Johannes Berg wrote:
> 
> On Tue, 2006-05-30 at 15:35 +0200, Takashi Iwai wrote:
> 
> > And I thought the put callbacks in your code always return either 1 or
> > -err?
> 
> Yeah, they return 1 if the change was applied (or no change) and -err if
> there's an error about the change (only in very few cases).
> 
> I figured the extra notification wouldn't hurt, and to the application
> there wouldn't be a problem.

Actually the extra notification won't hurt much in practice.
I've seen that some drivers also don't check the unchanged case and
return always 1, so apparently the apps work.  But, it's of course
better to check the state on the driver side.


Takashi

  reply	other threads:[~2006-05-30 13:48 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-28 19:00 [RFC 0/7] snd-aoa: add snd-aoa Johannes Berg
2006-05-28 19:00 ` [RFC 1/7] snd-aoa: add aoa header files Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-28 19:00 ` [RFC 2/7] snd-aoa: add aoa core Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-29 10:57   ` Takashi Iwai
2006-05-29 10:57     ` [Alsa-devel] " Takashi Iwai
2006-05-30 12:44     ` Johannes Berg
2006-05-30 13:20       ` Takashi Iwai
2006-05-30 13:20         ` [Alsa-devel] " Takashi Iwai
2006-05-30 12:44     ` Johannes Berg
2006-05-28 19:00 ` [RFC 3/7] snd-aoa: add soundbus and i2sbus Johannes Berg
2006-05-28 19:00 ` [RFC 4/7] snd-aoa: add codecs Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-29 12:08   ` Takashi Iwai
2006-05-29 12:08     ` [Alsa-devel] " Takashi Iwai
2006-05-30 12:43     ` Johannes Berg
2006-05-30 13:19       ` Takashi Iwai
2006-05-30 13:19         ` [Alsa-devel] " Takashi Iwai
2006-05-30 13:26         ` Johannes Berg
2006-05-30 13:26           ` [Alsa-devel] " Johannes Berg
2006-05-30 13:35           ` Takashi Iwai
2006-05-30 13:35           ` [Alsa-devel] " Takashi Iwai
2006-05-30 13:39             ` Johannes Berg
2006-05-30 13:39               ` [Alsa-devel] " Johannes Berg
2006-05-30 13:48               ` Takashi Iwai [this message]
2006-05-30 13:48                 ` Takashi Iwai
2006-05-30 13:53                 ` Johannes Berg
2006-05-30 13:53                   ` [Alsa-devel] " Johannes Berg
2006-05-30 13:56                   ` Takashi Iwai
2006-05-30 13:56                     ` [Alsa-devel] " Takashi Iwai
2006-05-30 12:43     ` Johannes Berg
2006-05-28 19:00 ` [RFC 5/7] snd-aoa: add layout-id fabric Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-29 12:14   ` Takashi Iwai
2006-05-29 12:14     ` [Alsa-devel] " Takashi Iwai
2006-05-30 12:37     ` Johannes Berg
2006-05-30 12:37       ` [Alsa-devel] " Johannes Berg
2006-05-28 19:00 ` [RFC 6/7] snd-aoa: add Kconfig and Makefile Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-28 19:00 ` [RFC 7/7] snd-aoa: wire up aoa in sound/ Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-28 19:10 ` [RFC 0/7] snd-aoa: add snd-aoa Johannes Berg
2006-05-29 10:12   ` Takashi Iwai
2006-05-30 12:37     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hpshvfwta.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=johannes@sipsolutions.net \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.