All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org
Subject: Re: [RFC 5/7] snd-aoa: add layout-id fabric
Date: Mon, 29 May 2006 14:14:59 +0200	[thread overview]
Message-ID: <s5h64jp9ge4.wl%tiwai@suse.de> (raw)
In-Reply-To: <20060528190129.503400000@johannes.berg>

At Sun, 28 May 2006 21:00:31 +0200,
Johannes Berg wrote:
> 
> The 'fabric' is the thing that pulls all of snd-aoa together, this patch
> adds the 'layout' or 'layout-id' fabric that keys off the 'layout-id'
> property in the device-tree to pull in the proper modules. It itself loads
> if an i2sbus is present with a layout-id (exported in modalias) that it can
> use.
(snip)
> +static void use_layout(struct layout *l)
> +{
> +	int i;
> +
> +	for (i=0; i<MAX_CODECS_PER_BUS; i++) {
> +		if (l->codecs[i].name) {
> +			request_module("snd-aoa-codec-%s", l->codecs[i].name);

Just from curiosity:  Does this work properly?
I remember that there was a deadlock when you call request_module()
during module probe.


Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org
Subject: Re: [Alsa-devel] [RFC 5/7] snd-aoa: add layout-id fabric
Date: Mon, 29 May 2006 14:14:59 +0200	[thread overview]
Message-ID: <s5h64jp9ge4.wl%tiwai@suse.de> (raw)
In-Reply-To: <20060528190129.503400000@johannes.berg>

At Sun, 28 May 2006 21:00:31 +0200,
Johannes Berg wrote:
> 
> The 'fabric' is the thing that pulls all of snd-aoa together, this patch
> adds the 'layout' or 'layout-id' fabric that keys off the 'layout-id'
> property in the device-tree to pull in the proper modules. It itself loads
> if an i2sbus is present with a layout-id (exported in modalias) that it can
> use.
(snip)
> +static void use_layout(struct layout *l)
> +{
> +	int i;
> +
> +	for (i=0; i<MAX_CODECS_PER_BUS; i++) {
> +		if (l->codecs[i].name) {
> +			request_module("snd-aoa-codec-%s", l->codecs[i].name);

Just from curiosity:  Does this work properly?
I remember that there was a deadlock when you call request_module()
during module probe.


Takashi

  reply	other threads:[~2006-05-29 12:14 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-28 19:00 [RFC 0/7] snd-aoa: add snd-aoa Johannes Berg
2006-05-28 19:00 ` [RFC 1/7] snd-aoa: add aoa header files Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-28 19:00 ` [RFC 2/7] snd-aoa: add aoa core Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-29 10:57   ` Takashi Iwai
2006-05-29 10:57     ` [Alsa-devel] " Takashi Iwai
2006-05-30 12:44     ` Johannes Berg
2006-05-30 12:44     ` [Alsa-devel] " Johannes Berg
2006-05-30 13:20       ` Takashi Iwai
2006-05-30 13:20         ` [Alsa-devel] " Takashi Iwai
2006-05-28 19:00 ` [RFC 3/7] snd-aoa: add soundbus and i2sbus Johannes Berg
2006-05-28 19:00 ` [RFC 4/7] snd-aoa: add codecs Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-29 12:08   ` Takashi Iwai
2006-05-29 12:08     ` [Alsa-devel] " Takashi Iwai
2006-05-30 12:43     ` Johannes Berg
2006-05-30 12:43     ` [Alsa-devel] " Johannes Berg
2006-05-30 13:19       ` Takashi Iwai
2006-05-30 13:19         ` [Alsa-devel] " Takashi Iwai
2006-05-30 13:26         ` Johannes Berg
2006-05-30 13:26           ` [Alsa-devel] " Johannes Berg
2006-05-30 13:35           ` Takashi Iwai
2006-05-30 13:35           ` [Alsa-devel] " Takashi Iwai
2006-05-30 13:39             ` Johannes Berg
2006-05-30 13:39               ` [Alsa-devel] " Johannes Berg
2006-05-30 13:48               ` Takashi Iwai
2006-05-30 13:48                 ` [Alsa-devel] " Takashi Iwai
2006-05-30 13:53                 ` Johannes Berg
2006-05-30 13:53                   ` [Alsa-devel] " Johannes Berg
2006-05-30 13:56                   ` Takashi Iwai
2006-05-30 13:56                     ` [Alsa-devel] " Takashi Iwai
2006-05-28 19:00 ` [RFC 5/7] snd-aoa: add layout-id fabric Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-29 12:14   ` Takashi Iwai [this message]
2006-05-29 12:14     ` [Alsa-devel] " Takashi Iwai
2006-05-30 12:37     ` Johannes Berg
2006-05-30 12:37       ` [Alsa-devel] " Johannes Berg
2006-05-28 19:00 ` [RFC 6/7] snd-aoa: add Kconfig and Makefile Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-28 19:00 ` [RFC 7/7] snd-aoa: wire up aoa in sound/ Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-28 19:10 ` [RFC 0/7] snd-aoa: add snd-aoa Johannes Berg
2006-05-29 10:12   ` Takashi Iwai
2006-05-30 12:37     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h64jp9ge4.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=johannes@sipsolutions.net \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.