Re: [PATCH] Freeze bdevs when freezing processes.

[Nigel Cunningham <ncunningham@linuxmail.org>]

Hi.

On Mon, 2006-10-23 at 10:50 -0700, Andrew Morton wrote:
> > On Mon, 23 Oct 2006 19:14:50 +0200 Pavel Machek <pavel@ucw.cz> wrote:
> > On Mon 2006-10-23 09:55:22, Andrew Morton wrote:
> > > > On Mon, 23 Oct 2006 16:07:16 +0200 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> > > > > I'm trying to prepare the patches to make swsusp into suspend2.
> > > > 
> > > > Oh, I see.  Please don't do that.
> > > 
> > > Why not?
> > 
> > Last time I checked, suspend2 was 15000 lines of code, including its
> > own plugin system and special user-kernel protocol for drawing
> > progress bar (netlink based). It also did parts of user interface from
> 
> That's different.

Let's judge those bits when we see them, rather than going on rumour and
inuendo :)

> I don't know where these patches are leading, but thus far they look like
> reasonable cleanups and generalisations.  So I suggest we just take them
> one at a time.

I am seeking to produce patches to merge Suspend2 one bit at a time, as
has been requested in the past. I'd therefore ask that you do that,
because even if Pavel and Rafael don't like the overall thrust, it
doesn't mean you can't cherry pick what is good and useful along the
way.

Regards,

Nigel