From: Peter Zijlstra <peterz@infradead.org>
To: Fengguang Wu <wfg@mail.ustc.edu.cn>
Cc: Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] compacting file_ra_state
Date: Fri, 20 Jul 2007 12:48:59 +0200 [thread overview]
Message-ID: <1184928539.20032.171.camel@twins> (raw)
In-Reply-To: <1184927207.20032.168.camel@twins>
On Fri, 2007-07-20 at 12:26 +0200, Peter Zijlstra wrote:
> On Fri, 2007-07-20 at 18:07 +0800, Fengguang Wu wrote:
> > plain text document attachment (short-rasize.patch)
> > Use 'unsigned int' instead of 'unsigned long' for the readahead indexes/sizes.
> >
> > This helps reduce memory consumption on 64bit CPU when
> > a lot of files are opened.
> >
> > Note that the (smaller) 32bit index can support up to 16PB file.
> > Which should be sufficient large at least for now.
>
> Perhaps merge prev_offset and prev_index into a pgoff_t prev? That
> should give the same savings on 64bit and be more correct on 32bit.
s/pgoff_t/loff_t/
(and how come lkml was not on the CC list?)
next prev parent reply other threads:[~2007-07-20 10:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 10:07 [PATCH 0/6] readahead cleanups and interleaved readahead Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu
2007-07-20 10:07 ` [PATCH 1/6] compacting file_ra_state Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu
[not found] ` <p73y7hbux4d.fsf@bingen.suse.de>
2007-07-20 12:11 ` Fengguang Wu
2007-07-20 12:11 ` Fengguang Wu
2007-07-20 16:02 ` Linus Torvalds
[not found] ` <1184927207.20032.168.camel@twins>
2007-07-20 10:48 ` Peter Zijlstra [this message]
2007-07-20 11:24 ` Fengguang Wu
2007-07-20 11:24 ` Fengguang Wu
2007-07-20 10:07 ` [PATCH 2/6] mmap read-around simplification Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu
2007-07-20 10:07 ` [PATCH 3/6] remove several readahead macros Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu
2007-07-20 10:07 ` [PATCH 4/6] remove the limit max_sectors_kb imposed on max_readahead_kb Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu
2007-07-20 11:07 ` Jens Axboe
2007-07-20 11:25 ` Fengguang Wu
2007-07-20 11:25 ` Fengguang Wu
2007-07-20 10:07 ` [PATCH 5/6] introduce radix_tree_scan_hole() Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu
2007-07-20 10:07 ` [PATCH 6/6] basic support of interleaved reads Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184928539.20032.171.camel@twins \
--to=peterz@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=wfg@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.