All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 3/6] remove several readahead macros
Date: Fri, 20 Jul 2007 18:07:43 +0800	[thread overview]
Message-ID: <384926280.27423@ustc.edu.cn> (raw)
Message-ID: <20070720101124.221472134@mail.ustc.edu.cn> (raw)
In-Reply-To: 20070720100740.106917381@mail.ustc.edu.cn

[-- Attachment #1: readahead-macros-cleanup.patch --]
[-- Type: text/plain, Size: 1523 bytes --]

Remove VM_MAX_CACHE_HIT, MAX_RA_PAGES and MIN_RA_PAGES.

Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
---
 include/linux/mm.h |    2 --
 mm/readahead.c     |   10 +---------
 2 files changed, 1 insertion(+), 11 deletions(-)

--- linux-2.6.22-rc6-mm1.orig/include/linux/mm.h
+++ linux-2.6.22-rc6-mm1/include/linux/mm.h
@@ -1148,8 +1148,6 @@ int write_one_page(struct page *page, in
 /* readahead.c */
 #define VM_MAX_READAHEAD	128	/* kbytes */
 #define VM_MIN_READAHEAD	16	/* kbytes (includes current page) */
-#define VM_MAX_CACHE_HIT    	256	/* max pages in a row in cache before
-					 * turning readahead off */
 
 int do_page_cache_readahead(struct address_space *mapping, struct file *filp,
 			pgoff_t offset, unsigned long nr_to_read);
--- linux-2.6.22-rc6-mm1.orig/mm/readahead.c
+++ linux-2.6.22-rc6-mm1/mm/readahead.c
@@ -21,16 +21,8 @@ void default_unplug_io_fn(struct backing
 }
 EXPORT_SYMBOL(default_unplug_io_fn);
 
-/*
- * Convienent macros for min/max read-ahead pages.
- * Note that MAX_RA_PAGES is rounded down, while MIN_RA_PAGES is rounded up.
- * The latter is necessary for systems with large page size(i.e. 64k).
- */
-#define MAX_RA_PAGES	(VM_MAX_READAHEAD*1024 / PAGE_CACHE_SIZE)
-#define MIN_RA_PAGES	DIV_ROUND_UP(VM_MIN_READAHEAD*1024, PAGE_CACHE_SIZE)
-
 struct backing_dev_info default_backing_dev_info = {
-	.ra_pages	= MAX_RA_PAGES,
+	.ra_pages	= VM_MAX_READAHEAD * 1024 / PAGE_CACHE_SIZE,
 	.state		= 0,
 	.capabilities	= BDI_CAP_MAP_COPY,
 	.unplug_io_fn	= default_unplug_io_fn,

--

  parent reply	other threads:[~2007-07-20 10:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-20 10:07 [PATCH 0/6] readahead cleanups and interleaved readahead Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu
2007-07-20 10:07 ` [PATCH 1/6] compacting file_ra_state Fengguang Wu
2007-07-20 10:07   ` Fengguang Wu
     [not found]     ` <p73y7hbux4d.fsf@bingen.suse.de>
2007-07-20 12:11       ` Fengguang Wu
2007-07-20 12:11         ` Fengguang Wu
2007-07-20 16:02           ` Linus Torvalds
     [not found]   ` <1184927207.20032.168.camel@twins>
2007-07-20 10:48     ` Peter Zijlstra
2007-07-20 11:24       ` Fengguang Wu
2007-07-20 11:24         ` Fengguang Wu
2007-07-20 10:07 ` [PATCH 2/6] mmap read-around simplification Fengguang Wu
2007-07-20 10:07   ` Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu [this message]
2007-07-20 10:07   ` [PATCH 3/6] remove several readahead macros Fengguang Wu
2007-07-20 10:07 ` [PATCH 4/6] remove the limit max_sectors_kb imposed on max_readahead_kb Fengguang Wu
2007-07-20 10:07   ` Fengguang Wu
2007-07-20 11:07   ` Jens Axboe
2007-07-20 11:25     ` Fengguang Wu
2007-07-20 11:25       ` Fengguang Wu
2007-07-20 10:07 ` [PATCH 5/6] introduce radix_tree_scan_hole() Fengguang Wu
2007-07-20 10:07   ` Fengguang Wu
2007-07-20 10:07 ` [PATCH 6/6] basic support of interleaved reads Fengguang Wu
2007-07-20 10:07   ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=384926280.27423@ustc.edu.cn \
    --to=wfg@mail.ustc.edu.cn \
    --cc=akpm@osdl.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.