From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/6] mmap read-around simplification
Date: Fri, 20 Jul 2007 18:07:42 +0800 [thread overview]
Message-ID: <384926280.22018@ustc.edu.cn> (raw)
Message-ID: <20070720101124.083676724@mail.ustc.edu.cn> (raw)
In-Reply-To: 20070720100740.106917381@mail.ustc.edu.cn
[-- Attachment #1: remove-mmap-hit.patch --]
[-- Type: text/plain, Size: 1359 bytes --]
Fold file_ra_state.mmap_hit into file_ra_state.mmap_miss
and make it an int.
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
---
include/linux/fs.h | 3 +--
mm/filemap.c | 4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
--- linux-2.6.22-rc6-mm1.orig/include/linux/fs.h
+++ linux-2.6.22-rc6-mm1/include/linux/fs.h
@@ -777,8 +777,7 @@ struct file_ra_state {
there are only # of pages ahead */
unsigned int ra_pages; /* Maximum readahead window */
- unsigned long mmap_hit; /* Cache hit stat for mmap accesses */
- unsigned long mmap_miss; /* Cache miss stat for mmap accesses */
+ int mmap_miss; /* Cache miss stat for mmap accesses */
unsigned int prev_offset; /* Offset where last read() ended in a page */
unsigned int prev_index; /* Cache last read() position */
};
--- linux-2.6.22-rc6-mm1.orig/mm/filemap.c
+++ linux-2.6.22-rc6-mm1/mm/filemap.c
@@ -1389,7 +1389,7 @@ retry_find:
* Do we miss much more than hit in this file? If so,
* stop bothering with read-ahead. It will only hurt.
*/
- if (ra->mmap_miss > ra->mmap_hit + MMAP_LOTSAMISS)
+ if (ra->mmap_miss > MMAP_LOTSAMISS)
goto no_cached_page;
/*
@@ -1415,7 +1415,7 @@ retry_find:
}
if (!did_readaround)
- ra->mmap_hit++;
+ ra->mmap_miss--;
/*
* We have a locked page in the page cache, now we need to check
--
next prev parent reply other threads:[~2007-07-20 10:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 10:07 [PATCH 0/6] readahead cleanups and interleaved readahead Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu
2007-07-20 10:07 ` [PATCH 1/6] compacting file_ra_state Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu
[not found] ` <p73y7hbux4d.fsf@bingen.suse.de>
2007-07-20 12:11 ` Fengguang Wu
2007-07-20 12:11 ` Fengguang Wu
2007-07-20 16:02 ` Linus Torvalds
[not found] ` <1184927207.20032.168.camel@twins>
2007-07-20 10:48 ` Peter Zijlstra
2007-07-20 11:24 ` Fengguang Wu
2007-07-20 11:24 ` Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu [this message]
2007-07-20 10:07 ` [PATCH 2/6] mmap read-around simplification Fengguang Wu
2007-07-20 10:07 ` [PATCH 3/6] remove several readahead macros Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu
2007-07-20 10:07 ` [PATCH 4/6] remove the limit max_sectors_kb imposed on max_readahead_kb Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu
2007-07-20 11:07 ` Jens Axboe
2007-07-20 11:25 ` Fengguang Wu
2007-07-20 11:25 ` Fengguang Wu
2007-07-20 10:07 ` [PATCH 5/6] introduce radix_tree_scan_hole() Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu
2007-07-20 10:07 ` [PATCH 6/6] basic support of interleaved reads Fengguang Wu
2007-07-20 10:07 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=384926280.22018@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@osdl.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.