From: Dave Hansen <haveblue@us.ibm.com>
To: balbir@linux.vnet.ibm.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM Mailing List <linux-mm@kvack.org>,
David Rientjes <rientjes@google.com>,
Linux Containers <containers@lists.osdl.org>,
Paul Menage <menage@google.com>
Subject: Re: [-mm PATCH] Memory controller improve user interface
Date: Wed, 29 Aug 2007 15:18:14 -0700 [thread overview]
Message-ID: <1188425894.28903.140.camel@localhost> (raw)
In-Reply-To: <46D5ED5C.9030405@linux.vnet.ibm.com>
On Thu, 2007-08-30 at 03:34 +0530, Balbir Singh wrote:
> I've thought about this before. The problem is that a user could
> set his limit to 10000 bytes, but would then see the usage and
> limit round to the closest page boundary. This can be confusing
> to a user.
True, but we're lying if we allow a user to set their limit there,
because we can't actually enforce a limit at 8,192 bytes vs 10,000.
They're the same limit as far as the kernel is concerned.
Why not just -EINVAL if the value isn't page-aligned? There are plenty
of interfaces in the kernel that require userspace to know the page
size, so this shouldn't be too difficult.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: balbir@linux.vnet.ibm.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM Mailing List <linux-mm@kvack.org>,
David Rientjes <rientjes@google.com>,
Linux Containers <containers@lists.osdl.org>,
Paul Menage <menage@google.com>
Subject: Re: [-mm PATCH] Memory controller improve user interface
Date: Wed, 29 Aug 2007 15:18:14 -0700 [thread overview]
Message-ID: <1188425894.28903.140.camel@localhost> (raw)
In-Reply-To: <46D5ED5C.9030405@linux.vnet.ibm.com>
On Thu, 2007-08-30 at 03:34 +0530, Balbir Singh wrote:
> I've thought about this before. The problem is that a user could
> set his limit to 10000 bytes, but would then see the usage and
> limit round to the closest page boundary. This can be confusing
> to a user.
True, but we're lying if we allow a user to set their limit there,
because we can't actually enforce a limit at 8,192 bytes vs 10,000.
They're the same limit as far as the kernel is concerned.
Why not just -EINVAL if the value isn't page-aligned? There are plenty
of interfaces in the kernel that require userspace to know the page
size, so this shouldn't be too difficult.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-08-29 22:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-29 11:10 [-mm PATCH] Memory controller improve user interface Balbir Singh
2007-08-29 11:10 ` Balbir Singh
2007-08-29 15:28 ` Paul Menage
2007-08-29 15:28 ` Paul Menage
2007-08-29 16:07 ` Balbir Singh
2007-08-29 16:07 ` Balbir Singh
2007-08-29 16:17 ` Paul Menage
2007-08-29 16:17 ` Paul Menage
2007-08-29 18:45 ` Dave Hansen
2007-08-29 18:45 ` Dave Hansen
2007-08-29 22:04 ` Balbir Singh
2007-08-29 22:04 ` Balbir Singh
2007-08-29 22:04 ` Balbir Singh
2007-08-29 22:18 ` Dave Hansen [this message]
2007-08-29 22:18 ` Dave Hansen
2007-08-29 22:20 ` Paul Menage
2007-08-29 22:20 ` Paul Menage
2007-08-29 22:25 ` Dave Hansen
2007-08-29 22:25 ` Dave Hansen
2007-08-29 22:37 ` Balbir Singh
2007-08-29 22:37 ` Balbir Singh
2007-08-29 22:37 ` Balbir Singh
2007-08-30 5:38 ` KAMEZAWA Hiroyuki
2007-08-30 5:38 ` KAMEZAWA Hiroyuki
[not found] ` <20070830143859.e9d3511a.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2007-08-30 9:13 ` Balbir Singh
2007-08-30 9:13 ` Balbir Singh
2007-08-30 9:13 ` Balbir Singh
2007-08-29 22:27 ` Balbir Singh
2007-08-29 22:27 ` Balbir Singh
2007-08-29 22:36 ` Dave Hansen
2007-08-29 22:36 ` Dave Hansen
2007-08-29 22:44 ` Balbir Singh
2007-08-29 22:44 ` Balbir Singh
2007-08-29 22:44 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1188425894.28903.140.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.