From: "Clemens Ladisch" <cladisch@fastmail.net>
To: Trent Piepho <xyzzy@speakeasy.org>, Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] Improved support for different bt87x board configurations
Date: Mon, 03 Sep 2007 08:36:47 +0200 [thread overview]
Message-ID: <1188801407.6762.1208578117@webmail.messagingengine.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0709021603380.18152@shell4.speakeasy.net>
Trent Piepho wrote:
> On Thu, 30 Aug 2007, Takashi Iwai wrote:
> > > - BT_DEVICE(PCI_DEVICE_ID_BROOKTREE_878, 0x0070, 0x13eb, 32000),
> > > + BT_DEVICE(_878, 0x0070, 0x13eb, SND_BT87X_BOARD_HAUPPAUGE878),
> > > /* Hauppauge WinTV series */
> >
> > The word _878 looks strange. PCI_DEVICE_ID_BROOKTREE_878 is more
> > obvious that it's a macro and the readability isn't so bad.
> > I'd say, let it be.
>
> The only problem is that PCI_DEVICE_ID_BROOKTREE_878 is so long that the
> lines become longer than 80 columns. They have to be wrapped, so it's no
> longer one line, one card and less readable. It's also easier to miss that
> one line says PCI_DEVICE_ID_BROOKTREE_879, when you have such a long string
> repeated many times, with only one digit different.
>
> What if I used "BROOKTREE_878" or some suffix of that?
My earlier version of the driver that did use "BT_DEVICE(878, ...)" was
changed to use PCI_DEVICE_ID_BROOKTREE_878 because only the complete
symbol allows to search for PCI IDs with grep.
You could drop the SND_BT87X_ prefix from the board symbols.
The 80 column limit isn't that hard when exceeding it really improves
readability.
Regards,
Clemens
next prev parent reply other threads:[~2007-09-03 6:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 10:21 [PATCH] Improved support for different bt87x board configurations Trent Piepho
2007-08-30 11:03 ` Takashi Iwai
2007-09-02 23:21 ` Trent Piepho
2007-09-03 6:36 ` Clemens Ladisch [this message]
2007-09-04 11:49 ` Trent Piepho
2007-09-04 13:54 ` Mauro Carvalho Chehab
2007-09-04 20:29 ` Takashi Iwai
2007-09-04 21:04 ` Trent Piepho
2007-09-05 6:54 ` Mauro Carvalho Chehab
2007-09-05 9:09 ` [alsa-devel] " Trent Piepho
2007-09-05 10:07 ` Takashi Iwai
2007-09-05 10:32 ` Mauro Carvalho Chehab
2007-09-05 22:34 ` Trent Piepho
2007-09-06 20:17 ` [alsa-devel] " Mauro Carvalho Chehab
2007-09-07 23:50 ` Takashi Iwai
2007-09-08 0:33 ` [alsa-devel] " Mauro Carvalho Chehab
2007-09-05 10:16 ` Takashi Iwai
2007-09-05 22:23 ` Trent Piepho
2007-09-06 13:13 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1188801407.6762.1208578117@webmail.messagingengine.com \
--to=cladisch@fastmail.net \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.