All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Trent Piepho <xyzzy@speakeasy.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] Improved support for different bt87x board configurations
Date: Thu, 06 Sep 2007 15:13:37 +0200	[thread overview]
Message-ID: <s5hy7fk543i.wl%tiwai@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0709051507490.31808@shell4.speakeasy.net>

At Wed, 5 Sep 2007 15:23:06 -0700 (PDT),
Trent Piepho wrote:
> 
> On Wed, 5 Sep 2007, Takashi Iwai wrote:
> > At Tue, 4 Sep 2007 04:49:46 -0700 (PDT),
> > Trent Piepho wrote:
> > >
> > > -	BT_DEVICE(PCI_DEVICE_ID_BROOKTREE_878, 0x0070, 0x13eb, 32000),
> > > +	BT_DEVICE(_878, 0x0070, 0x13eb, SND_BT87X_BOARD_HAUPPAUGE878),
> >
> > It's a bad move.  As Clemens pointed, it was in a similar expression
> > in the earlier version, but we changed to the form with
> > PCI_DEVICE_ID_ prefix *intentionally* after complains from kernel
> > hackers (and that was reasonable).  If the length of a line really
> > matters, we can drop SND_BT87X_ prefix from the board enum items
> > instead.
> 
> This is what I've done.  I think last time I sent the patch I accidently
> sent an old version without this change.
> 
> I also merged a few of the SND_BT87X boards with the same configuration.
> Initially I though each board should have a unique entry in the
> configuration list, but the fact is that there are only a couple different
> configurations now, and probably won't be many more, if any.  It makes more
> sense to think of it as a "board type id" instead of "board id", since
> there is several times more boards than there are board types.

OK, then that's fine.  I merged your patch to HG tree now.
Thanks!


Takashi

      reply	other threads:[~2007-09-06 13:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-30 10:21 [PATCH] Improved support for different bt87x board configurations Trent Piepho
2007-08-30 11:03 ` Takashi Iwai
2007-09-02 23:21   ` Trent Piepho
2007-09-03  6:36     ` Clemens Ladisch
2007-09-04 11:49       ` Trent Piepho
2007-09-04 13:54         ` Mauro Carvalho Chehab
2007-09-04 20:29           ` Takashi Iwai
2007-09-04 21:04             ` Trent Piepho
2007-09-05  6:54               ` Mauro Carvalho Chehab
2007-09-05  9:09                 ` [alsa-devel] " Trent Piepho
2007-09-05 10:07                   ` Takashi Iwai
2007-09-05 10:32                     ` Mauro Carvalho Chehab
2007-09-05 22:34                       ` Trent Piepho
2007-09-06 20:17                         ` [alsa-devel] " Mauro Carvalho Chehab
2007-09-07 23:50                           ` Takashi Iwai
2007-09-08  0:33                             ` [alsa-devel] " Mauro Carvalho Chehab
2007-09-05 10:16         ` Takashi Iwai
2007-09-05 22:23           ` Trent Piepho
2007-09-06 13:13             ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hy7fk543i.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=xyzzy@speakeasy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.