All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Linux and Kernel Video <video4linux-list@redhat.com>,
	alsa-devel@alsa-project.org, Trent Piepho <xyzzy@speakeasy.org>
Subject: Re: [alsa-devel] [PATCH] Improved support for	different	bt87x	board configurations
Date: Sat, 08 Sep 2007 01:33:36 +0100	[thread overview]
Message-ID: <1189211616.6721.90.camel@areia> (raw)
In-Reply-To: <s5hlkbihw6y.wl%tiwai@suse.de>

> > Reviewed-by: Mauro Carvalho Chehab <mchehab@infradead.org>
> 
> Thanks, but I have already committed, and don't want to rollback now
> :)
No problem ;)

> BTW, how is this tag supposed to use?

This is a new tag that were agreed to be used informally at KS/2007 :)

The idea behind is to use the following logic:

Signed-off-by: - should be used by the author(s) and the trees for what
the patch passed. A maintainer should add this tag to confirm that he
received a patch by its author or from a sub-subsystem tree (in fact,
sometimes, this tag is abused);

Acked-by: - this simply means that you aren't against some patch;

Reviewed-by: - It means that somebody that are not at the direct
forwarding way of a patch has reviewed and/or tested a patch.

So, in this case, as Trent sent the patch directly to you (even I'm
being C/C), I should use either acked-by (if I'm just ok with this) or
reviewed-by. As I've reviewed the source code, reviewed-by is the better
option.

Also, subsystem maintainers are asked to require at least one
reviewed-by by patch. The idea is to stimulate the community to review
changesets and improve the overall quality of the kernel.

>  On git or Hg, it's hard to
>  change the already committed stuff, especially after openly
>  published...)

What I do here is: I don't change -hg tree. During my -git conversion, I
add such tags that I receive from third parties, even for patches
already published at kernel.org. I only stop adding tags after asking a
git pull.

Here, I'm still using stgit porcelain to allow me to review changesets,
but this is not recommended. Probably, I'll review my procedures.
However, git have already some way for you to edit a message for an
already-edited changeset.

On possible way would be do to this - supposing that you want to edit
the patch that is HEAD - 3 patches from your master branch:

git checkout HEAD~3
git commit -e --amend
	(edit the comments)
git chckout master


I didn't really tested the above procedure, so I would try this on an
experimental tree first.
.
> 
> Takashi

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  reply	other threads:[~2007-09-08  0:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-30 10:21 [PATCH] Improved support for different bt87x board configurations Trent Piepho
2007-08-30 11:03 ` Takashi Iwai
2007-09-02 23:21   ` Trent Piepho
2007-09-03  6:36     ` Clemens Ladisch
2007-09-04 11:49       ` Trent Piepho
2007-09-04 13:54         ` Mauro Carvalho Chehab
2007-09-04 20:29           ` Takashi Iwai
2007-09-04 21:04             ` Trent Piepho
2007-09-05  6:54               ` Mauro Carvalho Chehab
2007-09-05  9:09                 ` [alsa-devel] " Trent Piepho
2007-09-05 10:07                   ` Takashi Iwai
2007-09-05 10:32                     ` Mauro Carvalho Chehab
2007-09-05 22:34                       ` Trent Piepho
2007-09-06 20:17                         ` [alsa-devel] " Mauro Carvalho Chehab
2007-09-07 23:50                           ` Takashi Iwai
2007-09-08  0:33                             ` Mauro Carvalho Chehab [this message]
2007-09-05 10:16         ` Takashi Iwai
2007-09-05 22:23           ` Trent Piepho
2007-09-06 13:13             ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1189211616.6721.90.camel@areia \
    --to=mchehab@infradead.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    --cc=video4linux-list@redhat.com \
    --cc=xyzzy@speakeasy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.