From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Trent Piepho <xyzzy@speakeasy.org>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] Improved support for different bt87x board configurations
Date: Tue, 04 Sep 2007 14:54:39 +0100 [thread overview]
Message-ID: <1188914079.6535.47.camel@areia> (raw)
In-Reply-To: <Pine.LNX.4.58.0709040447220.31808@shell4.speakeasy.net>
> Ok, that's what I did. The other checkpatch warnings are fixed too.
> +/* Cards with configuration information */
> +enum snd_bt87x_boardid {
> + SND_BT87X_BOARD_GENERIC,
> + SND_BT87X_BOARD_ANALOG, /* board with no external A/D
> */
> + SND_BT87X_BOARD_HAUPPAUGE878,
> + SND_BT87X_BOARD_OSPREY2x0,
> + SND_BT87X_BOARD_OSPREY440,
> + SND_BT87X_BOARD_ATI_TVWONDER,
> + SND_BT87X_BOARD_WINFAST2000,
> + SND_BT87X_BOARD_VOODOOTV_200,
> + SND_BT87X_BOARD_AVPHONE98,
Hmm... Maybe it would be a good idea to move the board numbers from
linux/drivers/media/video/bt8xx/bttv.h to a separate header (maybe
something like /include/media/bt8xx-cards.h) and use the same board IDs
for both -alsa and -v4l drivers.
This will make easier to associate the audio and video parts for
troubleshooting and newer developments.
Cheers,
Mauro.
next prev parent reply other threads:[~2007-09-04 13:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 10:21 [PATCH] Improved support for different bt87x board configurations Trent Piepho
2007-08-30 11:03 ` Takashi Iwai
2007-09-02 23:21 ` Trent Piepho
2007-09-03 6:36 ` Clemens Ladisch
2007-09-04 11:49 ` Trent Piepho
2007-09-04 13:54 ` Mauro Carvalho Chehab [this message]
2007-09-04 20:29 ` Takashi Iwai
2007-09-04 21:04 ` Trent Piepho
2007-09-05 6:54 ` Mauro Carvalho Chehab
2007-09-05 9:09 ` [alsa-devel] " Trent Piepho
2007-09-05 10:07 ` Takashi Iwai
2007-09-05 10:32 ` Mauro Carvalho Chehab
2007-09-05 22:34 ` Trent Piepho
2007-09-06 20:17 ` [alsa-devel] " Mauro Carvalho Chehab
2007-09-07 23:50 ` Takashi Iwai
2007-09-08 0:33 ` [alsa-devel] " Mauro Carvalho Chehab
2007-09-05 10:16 ` Takashi Iwai
2007-09-05 22:23 ` Trent Piepho
2007-09-06 13:13 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1188914079.6535.47.camel@areia \
--to=mchehab@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.