Re: [PATCH 1/4] [NETFILTER]: ebtables: expand/remove unneeded macros

[Bart De Schuymer <bdschuym@pandora.be>]

Op zo, 20-01-2008 te 14:17 +0100, schreef Patrick McHardy:
> Jan Engelhardt wrote:
> > On Jan 20 2008 14:02, Patrick McHardy wrote:
> >> Jan Engelhardt wrote:
> >>> commit a6c73fee39cedc87ef2562f84d5b1f68a315a79b
> >>> Author: Jan Engelhardt <jengelh@computergmbh.de>
> >>> Date:   Thu Jan 17 18:58:05 2008 +0100
> >>>
> >>>     [NETFILTER]: ebtables: expand/remove unneeded macros
> >>>     
> >>>     The EBT_*_{MATCH,TARGET,WATCHER} macros are only used within the
> >>>     accompanying .c source file, so they can be moved to it. And since
> >>>     they are only used once, we can just as well expand them.
> >>>     
> >>>     Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
> >>
> >> Your patches all look fine, but please CC Bart on ebtables patches,
> >> I think its impolite to bypass him when he's stated as maintainer.
> >>
> >>
> > Sorry for the inconvenience! Links are:
> > 
> > [1] marc missed that one(!?)
> > [2] http://marc.info/?l=netfilter-devel&m=120060092423718&w=2
> > [3] http://marc.info/?l=netfilter-devel&m=120060092523724&w=2
> > [4] http://marc.info/?l=netfilter-devel&m=120060075523444&w=2
> 
> 
> Thanks. Bart, please let me know if you have any objections or
> want to add a Signed-off-by: line.

Hi, thanks for putting me in CC. If you remove the EBT_*_ macros from
ebtables.h this will break the ebtables userspace compilation. For the
other patches I have no objection except that the MODULE_DESCRIPTION
isn't consistent with using upper case after 'Ebtables: ', but I guess
that's nitpicking :) Anyway, thanks Jan.

Btw, Patrick, I'm sure you've noticed I'm not very active in ebtables
development anymore. It has come to the point that I no longer find
pleasure in investing my spare time and energy in serious ebtables
development: most interesting ebtables things have been done for me. I'm
still around for bugfixing or commenting on patches, though (I tend to
only read things on ebtables-devel and stuff I'm CC'ed in). So if there
would ever arrive an active developer who has some serious ebtables
contributions (like getting access to the xt_ matches) and a long-term
commitment, I'm willing to step down as maintainer ((s)he'd have to take
over the responsibility for the userspace tool too). Anyway, no need to
worry that I'll suddenly abandon my project :) I think for bridge-nf
you're already the true maintainer, though you can always CC me for my
opinion (feel free to update the header of br_netfilter.c).

cheers,
Bart