All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Netfilter Developer Mailing List
	<netfilter-devel@vger.kernel.org>,
	bdschuym@pandora.be
Subject: Re: [PATCH 1/4] [NETFILTER]: ebtables: expand/remove unneeded macros
Date: Sun, 20 Jan 2008 14:17:07 +0100	[thread overview]
Message-ID: <479349D3.6050103@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0801201407280.14598@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On Jan 20 2008 14:02, Patrick McHardy wrote:
>> Jan Engelhardt wrote:
>>> commit a6c73fee39cedc87ef2562f84d5b1f68a315a79b
>>> Author: Jan Engelhardt <jengelh@computergmbh.de>
>>> Date:   Thu Jan 17 18:58:05 2008 +0100
>>>
>>>     [NETFILTER]: ebtables: expand/remove unneeded macros
>>>     
>>>     The EBT_*_{MATCH,TARGET,WATCHER} macros are only used within the
>>>     accompanying .c source file, so they can be moved to it. And since
>>>     they are only used once, we can just as well expand them.
>>>     
>>>     Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
>>
>> Your patches all look fine, but please CC Bart on ebtables patches,
>> I think its impolite to bypass him when he's stated as maintainer.
>>
>>
> Sorry for the inconvenience! Links are:
> 
> [1] marc missed that one(!?)
> [2] http://marc.info/?l=netfilter-devel&m=120060092423718&w=2
> [3] http://marc.info/?l=netfilter-devel&m=120060092523724&w=2
> [4] http://marc.info/?l=netfilter-devel&m=120060075523444&w=2


Thanks. Bart, please let me know if you have any objections or
want to add a Signed-off-by: line.



  reply	other threads:[~2008-01-20 13:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17 20:10 [PATCH 1/4] [NETFILTER]: ebtables: expand/remove unneeded macros Jan Engelhardt
2008-01-17 20:10 ` [PATCH 2/4] [NETFILTER]: ebtables: remove casts, use consts Jan Engelhardt
2008-01-20 14:52   ` Patrick McHardy
2008-01-17 20:11 ` [PATCH 3/4] [NETFILTER]: ebtables: mark matches, targets and watchers __read_mostly Jan Engelhardt
2008-01-20 14:52   ` Patrick McHardy
2008-01-20 18:07     ` Jan Engelhardt
2008-01-20 18:21       ` Patrick McHardy
2008-01-22 17:02   ` Patrick McHardy
2008-01-17 20:11 ` [PATCH 4/4] [NETFILTER]: ebtables: Update modules' descriptions Jan Engelhardt
2008-01-20 14:54   ` Patrick McHardy
2008-01-20 13:02 ` [PATCH 1/4] [NETFILTER]: ebtables: expand/remove unneeded macros Patrick McHardy
2008-01-20 13:09   ` Jan Engelhardt
2008-01-20 13:17     ` Patrick McHardy [this message]
2008-01-20 14:26       ` Bart De Schuymer
2008-01-20 14:45         ` Patrick McHardy
2008-01-20 17:34           ` Jan Engelhardt
2008-01-20 18:07             ` Bart De Schuymer
2008-01-20 18:30               ` Jan Engelhardt
2008-01-20 18:57                 ` Bart De Schuymer
2008-01-20 19:03                   ` Jan Engelhardt
2008-01-24  8:05                 ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=479349D3.6050103@trash.net \
    --to=kaber@trash.net \
    --cc=bdschuym@pandora.be \
    --cc=jengelh@computergmbh.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.