All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 2/4] [NETFILTER]: ebtables: remove casts, use consts
Date: Sun, 20 Jan 2008 15:52:23 +0100	[thread overview]
Message-ID: <47936027.5080806@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0801172110390.18447@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> commit cae15d95db223db34c6ac39953061e7aa8ebc7b1
> Author: Jan Engelhardt <jengelh@computergmbh.de>
> Date:   Thu Jan 17 19:40:51 2008 +0100
> 
>     [NETFILTER]: ebtables: remove casts, use consts
>     
>     Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>

Applied, thanks.

> diff --git a/include/net/arp.h b/include/net/arp.h
> index 752eb47..c236270 100644
> --- a/include/net/arp.h
> +++ b/include/net/arp.h
> @@ -13,15 +13,17 @@ extern int	arp_find(unsigned char *haddr, struct sk_buff *skb);
>  extern int	arp_ioctl(struct net *net, unsigned int cmd, void __user *arg);
>  extern void     arp_send(int type, int ptype, __be32 dest_ip,
>  			 struct net_device *dev, __be32 src_ip,
> -			 unsigned char *dest_hw, unsigned char *src_hw, unsigned char *th);
> +			 const unsigned char *dest_hw,
> +			 const unsigned char *src_hw, const unsigned char *th);
>  extern int	arp_bind_neighbour(struct dst_entry *dst);
>  extern int	arp_mc_map(__be32 addr, u8 *haddr, struct net_device *dev, int dir);
>  extern void	arp_ifdown(struct net_device *dev);


This would have been better in a seperate patch though.


  reply	other threads:[~2008-01-20 14:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17 20:10 [PATCH 1/4] [NETFILTER]: ebtables: expand/remove unneeded macros Jan Engelhardt
2008-01-17 20:10 ` [PATCH 2/4] [NETFILTER]: ebtables: remove casts, use consts Jan Engelhardt
2008-01-20 14:52   ` Patrick McHardy [this message]
2008-01-17 20:11 ` [PATCH 3/4] [NETFILTER]: ebtables: mark matches, targets and watchers __read_mostly Jan Engelhardt
2008-01-20 14:52   ` Patrick McHardy
2008-01-20 18:07     ` Jan Engelhardt
2008-01-20 18:21       ` Patrick McHardy
2008-01-22 17:02   ` Patrick McHardy
2008-01-17 20:11 ` [PATCH 4/4] [NETFILTER]: ebtables: Update modules' descriptions Jan Engelhardt
2008-01-20 14:54   ` Patrick McHardy
2008-01-20 13:02 ` [PATCH 1/4] [NETFILTER]: ebtables: expand/remove unneeded macros Patrick McHardy
2008-01-20 13:09   ` Jan Engelhardt
2008-01-20 13:17     ` Patrick McHardy
2008-01-20 14:26       ` Bart De Schuymer
2008-01-20 14:45         ` Patrick McHardy
2008-01-20 17:34           ` Jan Engelhardt
2008-01-20 18:07             ` Bart De Schuymer
2008-01-20 18:30               ` Jan Engelhardt
2008-01-20 18:57                 ` Bart De Schuymer
2008-01-20 19:03                   ` Jan Engelhardt
2008-01-24  8:05                 ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47936027.5080806@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@computergmbh.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.