Re: [PATCH 1/4] [NETFILTER]: ebtables: expand/remove unneeded macros

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> On Jan 20 2008 19:07, Bart De Schuymer wrote:
>> Op zo, 20-01-2008 te 18:34 +0100, schreef Jan Engelhardt:
>>> "Ugh." I do not think ebtables(8) should depend on such macros.
>>> iptables(8) does not do that either.
>>> What good would those macros be for? It is not like the module names
>>> would be changing anyway (one purpose of macros - to reduce the number
>>> of places where you have to change things iff things change).
>> We are talking about EBT_ENTRY_ITERATE and the like, right?
>> I didn't see your patch, but even the kernel code uses the ITERATE
>> macros more than once.
>>
> No, just the name macros:
> 
> 
> (shortened)
> diff --git a/include/linux/netfilter_bridge/ebt_802_3.h b/include/linux/netfilter_bridge/ebt_802_3.h
> index a11b0c2..11421ca 100644
> --- a/include/linux/netfilter_bridge/ebt_802_3.h
> +++ b/include/linux/netfilter_bridge/ebt_802_3.h
> @@ -4,8 +4,6 @@
>  #define EBT_802_3_SAP 0x01
>  #define EBT_802_3_TYPE 0x02
>  
> -#define EBT_802_3_MATCH "802_3"


I've folded the ebtables MODULES_DESCRIPTION part without
this change and the {ip,ip6,x}_tables parts into your
first patch to update the descriptions. Frankly, I don't
care much about packet vs. Packet, but if you want to
change the other descriptions again, please send that
part seperately.