All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Native CD test results
Date: Sun, 30 Mar 2008 00:08:14 -0400	[thread overview]
Message-ID: <1206850094.8818.15.camel@dv> (raw)
In-Reply-To: <47EE2452.80304@nic.fi>

On Sat, 2008-03-29 at 13:13 +0200, Vesa Jääskeläinen wrote:

> Yeah... I noticed that too when I was playing with IDT's some time ago 
> and Bean found out the reason. I think we need to update this so that it 
> will never happen. Perhaps divide code to sections or so? We could 
> provide this in LD variable... hmm... I could investigate what would be 
> required for it... Good place to learn more about LD scripts.

If I understand correctly, kernel.img is a binary, so grub-mkimage won't
be able to get any linker data.

I think we could use one of the fields in the beginning of startup.S to
store the size of the part that should not be compressed.  For instance,
grub_compressed_size could be used for that, and grub-mkimage read it,
use it instead of GRUB_KERNEL_MACHINE_RAW_SIZE and then replace it with
the value it would normally put there.

That's the change in startup.S

--- kern/i386/pc/startup.S
+++ kern/i386/pc/startup.S
@@ -91,7 +91,7 @@
 VARIABLE(grub_kernel_image_size)
        .long   0
 VARIABLE(grub_compressed_size)
-       .long   0
+       .long   grub_stop - _start
 VARIABLE(grub_install_dos_part)
        .long   0xFFFFFFFF
 VARIABLE(grub_install_bsd_part)

Of course, we could put another label next to grub_stop with a more
descriptive name, like grub_uncompressed_end.

lnxboot.S needs to be changed to remove GRUB_KERNEL_MACHINE_RAW_SIZE as
well.  I don't understand at the first glance why lnxboot.S needs it.
Perhaps it could be calculated in a different way.

-- 
Regards,
Pavel Roskin



  reply	other threads:[~2008-03-30  4:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27  2:09 Native CD test results Pavel Roskin
2008-03-27  6:37 ` [RFC PATCH] " Pavel Roskin
2008-03-30  4:59   ` Pavel Roskin
2008-03-27  8:24 ` Bean
2008-03-27 15:30   ` Pavel Roskin
2008-03-27 20:25     ` Bean
2008-03-27 20:48       ` Pavel Roskin
2008-03-27 21:46         ` Pavel Roskin
2008-03-27 21:55           ` Vesa Jääskeläinen
2008-03-27 22:08             ` Pavel Roskin
2008-03-28 17:40     ` Pavel Roskin
2008-03-29 11:13       ` Vesa Jääskeläinen
2008-03-30  4:08         ` Pavel Roskin [this message]
2008-04-13 11:08 ` Robert Millan
2008-04-14  1:09   ` Pavel Roskin
2008-04-14 12:08     ` Robert Millan
  -- strict thread matches above, loose matches on Subject: below --
2008-03-28  2:54 Kalamatee
2008-03-28 15:46 ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1206850094.8818.15.camel@dv \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.