All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Native CD test results
Date: Thu, 27 Mar 2008 11:30:22 -0400	[thread overview]
Message-ID: <1206631822.2380.2.camel@dv> (raw)
In-Reply-To: <ca0f59980803270124j125b58baoa6dd70fd537d320@mail.gmail.com>

On Thu, 2008-03-27 at 16:24 +0800, Bean wrote:
> On Thu, Mar 27, 2008 at 10:09 AM, Pavel Roskin <proski@gnu.org> wrote:
> >  It turned out that the splash image called isolinux/splash.jpg is
> >  actually a png file.  What's worse, GRUB won't use it because it's not
> >  8-bit:
> >
> >  $ identify splash.jpg
> >  splash.jpg PNG 640x480 640x480+0+0 DirectClass 16-bit 436.441kb
> 
> It's quite easy to support 16-bit png, but i don't have one to test.
> would you please send the image to me ?

http://red-bean.com/proski/splash.png

> >  Once I had Fedora 9 installed, I tried to install the latest GRUB on
> >  it.  But I would get a strange message: "Warning: syntax error
> >  (missing slash) in `'"
> >
> >  It turned out that grub_parse_color_name_pair() was called from
> >  normal/menu.c, which didn't know a prototype for that function.  Even
> >  though NULL was passed as the "name" argument,
> >  grub_parse_color_name_pair() would see some non-zero value.  Adding
> >  the declaration to normal.h fixed the problem.
> 
> I think this is caused by compile optimization. grub use -mregparm=3
> option, which means use register instead of stack to pass parameter.
> When caller encounter a function without prototype, it use the c
> calling convention, which conflict with callee. But i think gcc is not
> to be blame here, because it just have no way to know better, we could
> be calling a function in the c library, in which case, the standard
> calling convention is the correct one.

That makes sense.  Thanks for the explanation.

By the way, the fix for GRUB hanging when booting from a CD is not
making any difference on the system where I discovered it initially.  I
need to look deeper.

-- 
Regards,
Pavel Roskin



  reply	other threads:[~2008-03-27 15:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27  2:09 Native CD test results Pavel Roskin
2008-03-27  6:37 ` [RFC PATCH] " Pavel Roskin
2008-03-30  4:59   ` Pavel Roskin
2008-03-27  8:24 ` Bean
2008-03-27 15:30   ` Pavel Roskin [this message]
2008-03-27 20:25     ` Bean
2008-03-27 20:48       ` Pavel Roskin
2008-03-27 21:46         ` Pavel Roskin
2008-03-27 21:55           ` Vesa Jääskeläinen
2008-03-27 22:08             ` Pavel Roskin
2008-03-28 17:40     ` Pavel Roskin
2008-03-29 11:13       ` Vesa Jääskeläinen
2008-03-30  4:08         ` Pavel Roskin
2008-04-13 11:08 ` Robert Millan
2008-04-14  1:09   ` Pavel Roskin
2008-04-14 12:08     ` Robert Millan
  -- strict thread matches above, loose matches on Subject: below --
2008-03-28  2:54 Kalamatee
2008-03-28 15:46 ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1206631822.2380.2.camel@dv \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.