From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Native CD test results
Date: Thu, 27 Mar 2008 17:46:03 -0400 [thread overview]
Message-ID: <1206654363.10959.11.camel@dv> (raw)
In-Reply-To: <1206650930.7377.16.camel@dv>
On Thu, 2008-03-27 at 16:48 -0400, Pavel Roskin wrote:
> On Fri, 2008-03-28 at 04:25 +0800, Bean wrote:
>
> > This patch add support for 16-bit png.
>
> Thanks was quick! It's working for me.
By the way, we should recognize images by their internal data, not by
the filenames. As it stands now, the jpeg reader only supports files
with ".jpeg" extension, not with ".jpg", which is more popular. And the
error message is unclear if the extension is unknown.
PNG begins with 89:50:4E:47, JPEG begins with FF:D8:FF:E0 and Targa can
start with 00:00:01:01, 00:00:02:00, 00:00:03:00, 00:00:09:01,
00:00:0A:00 and 00:00:0B:00.
If we have a good PNG support, we could drop Targa, which is rare and
obsolete.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-03-27 21:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-27 2:09 Native CD test results Pavel Roskin
2008-03-27 6:37 ` [RFC PATCH] " Pavel Roskin
2008-03-30 4:59 ` Pavel Roskin
2008-03-27 8:24 ` Bean
2008-03-27 15:30 ` Pavel Roskin
2008-03-27 20:25 ` Bean
2008-03-27 20:48 ` Pavel Roskin
2008-03-27 21:46 ` Pavel Roskin [this message]
2008-03-27 21:55 ` Vesa Jääskeläinen
2008-03-27 22:08 ` Pavel Roskin
2008-03-28 17:40 ` Pavel Roskin
2008-03-29 11:13 ` Vesa Jääskeläinen
2008-03-30 4:08 ` Pavel Roskin
2008-04-13 11:08 ` Robert Millan
2008-04-14 1:09 ` Pavel Roskin
2008-04-14 12:08 ` Robert Millan
-- strict thread matches above, loose matches on Subject: below --
2008-03-28 2:54 Kalamatee
2008-03-28 15:46 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206654363.10959.11.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.