All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vesa Jääskeläinen" <chaac@nic.fi>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Native CD test results
Date: Sat, 29 Mar 2008 13:13:22 +0200	[thread overview]
Message-ID: <47EE2452.80304@nic.fi> (raw)
In-Reply-To: <1206726009.20032.11.camel@dv>

Pavel Roskin wrote:
> And while "looking deeper", it turned out that there is a scary timebomb
> in kern/i386/pc/startup.S.  Only the initial part of that file is
> supposed to be uncompressed, but in fact, the error handlers of the
> decompression function itself were spilling into the compressed area.
> Adding even minimal debugging code would push the main part of
> lzo1x_decompress() beyond the boundary defined by
> GRUB_KERNEL_MACHINE_RAW_SIZE, which would crash even before "Welcome to
> GRUB".
> 
> So I've applied another patch that assures that to uncompressed code
> stays below GRUB_KERNEL_MACHINE_RAW_SIZE.  It would be nice to avoid any
> constant here and make grub-mkimage.c use a label in the image, but it
> would need more work and more testing.

Yeah... I noticed that too when I was playing with IDT's some time ago 
and Bean found out the reason. I think we need to update this so that it 
will never happen. Perhaps divide code to sections or so? We could 
provide this in LD variable... hmm... I could investigate what would be 
required for it... Good place to learn more about LD scripts.




  reply	other threads:[~2008-03-29 11:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27  2:09 Native CD test results Pavel Roskin
2008-03-27  6:37 ` [RFC PATCH] " Pavel Roskin
2008-03-30  4:59   ` Pavel Roskin
2008-03-27  8:24 ` Bean
2008-03-27 15:30   ` Pavel Roskin
2008-03-27 20:25     ` Bean
2008-03-27 20:48       ` Pavel Roskin
2008-03-27 21:46         ` Pavel Roskin
2008-03-27 21:55           ` Vesa Jääskeläinen
2008-03-27 22:08             ` Pavel Roskin
2008-03-28 17:40     ` Pavel Roskin
2008-03-29 11:13       ` Vesa Jääskeläinen [this message]
2008-03-30  4:08         ` Pavel Roskin
2008-04-13 11:08 ` Robert Millan
2008-04-14  1:09   ` Pavel Roskin
2008-04-14 12:08     ` Robert Millan
  -- strict thread matches above, loose matches on Subject: below --
2008-03-28  2:54 Kalamatee
2008-03-28 15:46 ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47EE2452.80304@nic.fi \
    --to=chaac@nic.fi \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.