[PATCH] update configure.ac to autoconf 2.61

[PATCH] update configure.ac to autoconf 2.61

[Felix Zielcke]

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

Attached patch is generated via `autoupdate --force' from autoconf 2.61
a svn-diff after ./autogen.sh doestn't show anything more, because
the ./configure script in SVN is already generated with autoconf 2.61.

autoconf 2.61 is dated 17.11.2006 on ftp.gnu.org

Debian etch + lenny have autoconf 2.61
etch has been released 8th April 2007
Ubuntu has it since feisty which has been released 19th April 2007

I haven't checked the others but I think this is recent enough for the
configure.ac (remember it's generated by ./autogen.sh anyway)

Yes I really want to get rid of old stuff and if you even only need to
call `autoupdate --force' ;)

Debian experimental has autoconf 2.62 which I normally use, there is
some other stuff deprecated and so changed by `autoupdate' but I'll
leave that for the future.

-- 
Felix Zielcke

[-- Attachment #2: configure.ac.diff --]
[-- Type: text/x-patch, Size: 1508 bytes --]

2008-09-03  Felix Zielcke  <fzielcke@z-51.de>

	* configure.ac (AC_INIT): Quote version number.
	(AC_PREREQ): Bumped to 2.61.
	(AC_TRY_COMPILE): Replace deprecated macro with ..
	(AC_COMPILE_IFELSE): ... this.

Index: configure.ac
===================================================================
--- configure.ac	(Revision 1845)
+++ configure.ac	(Arbeitskopie)
@@ -31,8 +31,8 @@ dnl (such as TARGET_CC, TARGET_CFLAGS, e
 dnl type.
 
 
-AC_INIT(GRUB, 1.96, [bug-grub@gnu.org])
-AC_PREREQ(2.53)
+AC_INIT([GRUB],[1.96],[bug-grub@gnu.org])
+AC_PREREQ(2.61)
 AC_CONFIG_SRCDIR([include/grub/dl.h])
 AC_CONFIG_HEADER([config.h])
 
@@ -266,7 +266,7 @@ if test "x$TARGET_CFLAGS" = x; then
   # optimization flags.
   AC_CACHE_CHECK([whether optimization for size works], grub_cv_cc_Os, [
     CFLAGS=-Os
-    AC_TRY_COMPILE(, , grub_cv_cc_Os=yes, grub_cv_cc_Os=no)
+    AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])],[grub_cv_cc_Os=yes],[grub_cv_cc_Os=no])
   ])
   if test "x$grub_cv_cc_Os" = xyes; then
     TARGET_CFLAGS="$TARGET_CFLAGS -Os"
@@ -278,7 +278,7 @@ if test "x$TARGET_CFLAGS" = x; then
   if test "x$target_cpu" = xi386; then
     AC_CACHE_CHECK([whether -falign-loops works], [grub_cv_cc_falign_loop], [
       CFLAGS="-falign-loops=1"
-      AC_TRY_COMPILE(, , [grub_cv_cc_falign_loop=yes], [grub_cv_cc_falign_loop=no])
+      AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])],[grub_cv_cc_falign_loop=yes],[grub_cv_cc_falign_loop=no])
     ])
 
     if test "x$grub_cv_cc_falign_loop" = xyes; then

Re: [PATCH] update configure.ac to autoconf 2.61

[Felix Zielcke]

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

Am Mittwoch, den 03.09.2008, 15:27 +0200 schrieb Felix Zielcke:
> Yes I really want to get rid of old stuff and if you even only need to
> call `autoupdate --force' ;)
> 

Oh and config.guess and config.sub have
timestamp='2007-07-22'

whereas the versions from automake 1.9 and 1.10 have
timestamp='2008-01-23

On a Debian system you find them in /usr/share/automake-<version>/

Any objection that I update these 2 files too?
Attached is a patch for these 2 files.

Not really necessary but well a bit outdated ;)

-- 
Felix Zielcke

[-- Attachment #2: config.sub_guess.diff --]
[-- Type: text/x-patch, Size: 6108 bytes --]

2008-09-03  Felix Zielcke  <fzielcke@z-51.de>

        * config.guess: Update to version from `2008-01-23'
        * config.sub: Likewise.

Index: config.guess
===================================================================
--- config.guess	(Revision 1846)
+++ config.guess	(Arbeitskopie)
@@ -1,10 +1,10 @@
 #! /bin/sh
 # Attempt to guess a canonical system name.
 #   Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
-#   2000, 2001, 2002, 2003, 2004, 2005, 2006 Free Software Foundation,
-#   Inc.
+#   2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008
+#   Free Software Foundation, Inc.
 
-timestamp='2007-07-22'
+timestamp='2008-01-23'
 
 # This file is free software; you can redistribute it and/or modify it
 # under the terms of the GNU General Public License as published by
@@ -56,8 +56,8 @@ version="\
 GNU config.guess ($timestamp)
 
 Originally written by Per Bothner.
-Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005
-Free Software Foundation, Inc.
+Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001,
+2002, 2003, 2004, 2005, 2006, 2007, 2008 Free Software Foundation, Inc.
 
 This is free software; see the source for copying conditions.  There is NO
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE."
@@ -532,7 +532,7 @@ EOF
 		echo rs6000-ibm-aix3.2
 	fi
 	exit ;;
-    *:AIX:*:[45])
+    *:AIX:*:[456])
 	IBM_CPU_ID=`/usr/sbin/lsdev -C -c processor -S available | sed 1q | awk '{ print $1 }'`
 	if /usr/sbin/lsattr -El ${IBM_CPU_ID} | grep ' POWER' >/dev/null 2>&1; then
 		IBM_ARCH=rs6000
@@ -799,6 +799,9 @@ EOF
 	    EM64T | authenticamd)
 		echo x86_64-unknown-interix${UNAME_RELEASE}
 		exit ;;
+	    IA64)
+		echo ia64-unknown-interix${UNAME_RELEASE}
+		exit ;;
 	esac ;;
     [345]86:Windows_95:* | [345]86:Windows_98:* | [345]86:Windows_NT:*)
 	echo i${UNAME_MACHINE}-pc-mks
@@ -833,7 +836,14 @@ EOF
 	echo ${UNAME_MACHINE}-pc-minix
 	exit ;;
     arm*:Linux:*:*)
-	echo ${UNAME_MACHINE}-unknown-linux-gnu
+	eval $set_cc_for_build
+	if echo __ARM_EABI__ | $CC_FOR_BUILD -E - 2>/dev/null \
+	    | grep -q __ARM_EABI__
+	then
+	    echo ${UNAME_MACHINE}-unknown-linux-gnu
+	else
+	    echo ${UNAME_MACHINE}-unknown-linux-gnueabi
+	fi
 	exit ;;
     avr32*:Linux:*:*)
 	echo ${UNAME_MACHINE}-unknown-linux-gnu
@@ -954,8 +964,8 @@ EOF
     x86_64:Linux:*:*)
 	echo x86_64-unknown-linux-gnu
 	exit ;;
-    xtensa:Linux:*:*)
-    	echo xtensa-unknown-linux-gnu
+    xtensa*:Linux:*:*)
+    	echo ${UNAME_MACHINE}-unknown-linux-gnu
 	exit ;;
     i*86:Linux:*:*)
 	# The BFD linker knows what the default object file format is, so
@@ -1474,9 +1484,9 @@ This script, last modified $timestamp, h
 the operating system you are using. It is advised that you
 download the most up to date version of the config scripts from
 
-  http://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.guess
+  http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=HEAD
 and
-  http://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.sub
+  http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.sub;hb=HEAD
 
 If the version you run ($0) is already up to date, please
 send the following data and any information you think might be
Index: config.sub
===================================================================
--- config.sub	(Revision 1846)
+++ config.sub	(Arbeitskopie)
@@ -1,10 +1,10 @@
 #! /bin/sh
 # Configuration validation subroutine script.
 #   Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
-#   2000, 2001, 2002, 2003, 2004, 2005, 2006 Free Software Foundation,
-#   Inc.
+#   2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008
+#   Free Software Foundation, Inc.
 
-timestamp='2007-06-28'
+timestamp='2008-01-16'
 
 # This file is (in principle) common to ALL GNU software.
 # The presence of a machine in this file suggests that SOME GNU software
@@ -72,8 +72,8 @@ Report bugs and patches to <config-patch
 version="\
 GNU config.sub ($timestamp)
 
-Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005
-Free Software Foundation, Inc.
+Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001,
+2002, 2003, 2004, 2005, 2006, 2007, 2008 Free Software Foundation, Inc.
 
 This is free software; see the source for copying conditions.  There is NO
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE."
@@ -369,10 +369,14 @@ case $basic_machine in
 	| v850-* | v850e-* | vax-* \
 	| we32k-* \
 	| x86-* | x86_64-* | xc16x-* | xps100-* | xscale-* | xscalee[bl]-* \
-	| xstormy16-* | xtensa-* \
+	| xstormy16-* | xtensa*-* \
 	| ymp-* \
 	| z8k-*)
 		;;
+	# Recognize the basic CPU types without company name, with glob match.
+	xtensa*)
+		basic_machine=$basic_machine-unknown
+		;;
 	# Recognize the various machine names and aliases which stand
 	# for a CPU type and a company and sometimes even an OS.
 	386bsd)
@@ -443,6 +447,14 @@ case $basic_machine in
 		basic_machine=ns32k-sequent
 		os=-dynix
 		;;
+	blackfin)
+		basic_machine=bfin-unknown
+		os=-linux
+		;;
+	blackfin-*)
+		basic_machine=bfin-`echo $basic_machine | sed 's/^[^-]*-//'`
+		os=-linux
+		;;
 	c90)
 		basic_machine=c90-cray
 		os=-unicos
@@ -668,6 +680,14 @@ case $basic_machine in
 		basic_machine=m68k-isi
 		os=-sysv
 		;;
+	m68knommu)
+		basic_machine=m68k-unknown
+		os=-linux
+		;;
+	m68knommu-*)
+		basic_machine=m68k-`echo $basic_machine | sed 's/^[^-]*-//'`
+		os=-linux
+		;;
 	m88k-omron*)
 		basic_machine=m88k-omron
 		;;
@@ -813,6 +833,14 @@ case $basic_machine in
 		basic_machine=i860-intel
 		os=-osf
 		;;
+	parisc)
+		basic_machine=hppa-unknown
+		os=-linux
+		;;
+	parisc-*)
+		basic_machine=hppa-`echo $basic_machine | sed 's/^[^-]*-//'`
+		os=-linux
+		;;
 	pbd)
 		basic_machine=sparc-tti
 		;;
@@ -1021,6 +1049,10 @@ case $basic_machine in
 		basic_machine=tic6x-unknown
 		os=-coff
 		;;
+	tile*)
+		basic_machine=tile-unknown
+		os=-linux-gnu
+		;;
 	tx39)
 		basic_machine=mipstx39-unknown
 		;;

Re: [PATCH] update configure.ac to autoconf 2.61

[Pavel Roskin]

On Wed, 2008-09-03 at 16:51 +0200, Felix Zielcke wrote:
> Am Mittwoch, den 03.09.2008, 15:27 +0200 schrieb Felix Zielcke:
> > Yes I really want to get rid of old stuff and if you even only need to
> > call `autoupdate --force' ;)
> > 
> 
> Oh and config.guess and config.sub have
> timestamp='2007-07-22'
> 
> whereas the versions from automake 1.9 and 1.10 have
> timestamp='2008-01-23

You can get the current config.* files from CVS:
cvs -d :pserver:anonymous@cvs.savannah.gnu.org:/sources/config co config

They are maintained in a very conservative matter, so it may be better
to use the CVS versions.  Actually, it's possible that they are the same
as those you have.

> On a Debian system you find them in /usr/share/automake-<version>/
> 
> Any objection that I update these 2 files too?
> Attached is a patch for these 2 files.
> 
> Not really necessary but well a bit outdated ;)

Fine with me.

-- 
Regards,
Pavel Roskin

Re: [PATCH] update configure.ac to autoconf 2.61

[Felix Zielcke]

Am Mittwoch, den 03.09.2008, 19:47 -0400 schrieb Pavel Roskin:

> You can get the current config.* files from CVS:
> cvs -d :pserver:anonymous@cvs.savannah.gnu.org:/sources/config co config

> They are maintained in a very conservative matter, so it may be better
> to use the CVS versions.  Actually, it's possible that they are the same
> as those you have.
They use now git as you can even see in the patch from my mail but I was
too lazy to check because I thought that automake-1.10 would have a
recent version.
But it seems not :)

> Fine with me.

Commited these 2 files.
Hurray a bit less outdated stuff now :)

-- 
Felix Zielcke

Re: [PATCH] update configure.ac to autoconf 2.61

[Pavel Roskin]

On Wed, 2008-09-03 at 15:27 +0200, Felix Zielcke wrote:
> Attached patch is generated via `autoupdate --force' from autoconf 2.61
> a svn-diff after ./autogen.sh doestn't show anything more, because
> the ./configure script in SVN is already generated with autoconf 2.61.
> 
> autoconf 2.61 is dated 17.11.2006 on ftp.gnu.org
> 
> Debian etch + lenny have autoconf 2.61
> etch has been released 8th April 2007
> Ubuntu has it since feisty which has been released 19th April 2007
> 
> I haven't checked the others but I think this is recent enough for the
> configure.ac (remember it's generated by ./autogen.sh anyway)
> 
> Yes I really want to get rid of old stuff and if you even only need to
> call `autoupdate --force' ;)

I don't see any old stuff being removed.  I don't see any justification
for any of the changes.  The new code is longer and less readable.  I
don't think AC_TRY_COMPILE is a big problem yet.  It's not like it won't
produce a valid test.

In any case, please try to avoid extra long lines where it can be easily
avoided.

Okuji wrote that he uses Autoconf 2.59, so it would be nice to check
that your changes would still work with that version.

-- 
Regards,
Pavel Roskin

Re: [PATCH] update configure.ac to autoconf 2.61

[Felix Zielcke]

[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]

Am Mittwoch, den 03.09.2008, 19:43 -0400 schrieb Pavel Roskin:
> 
> I don't see any old stuff being removed.  I don't see any justification
> for any of the changes.  The new code is longer and less readable.  I
> don't think AC_TRY_COMPILE is a big problem yet.  It's not like it won't
> produce a valid test.

http://www.gnu.org/software/autoconf/manual/autoconf.html#Autoconf-Macro-Index

AC_TRY_COMPILE is listed as `Obsolete Macro'.

I attached now even a diff with autoconf 2.62 which I won't commit, but
maybe you or someone else is interested.
Changelog says AC_GNU_SOURCE has been deprecated, though they're
currently no plans to remove it.

Currently it's not really needed but things get easily forgotten, even I
myself forgot a patch from me ..
We don't need to discuss running `autoupdate' in ./autogen.sh this is
really bad.
The Debian Build System has such a feature too but ftp-masters' reject
packages which uses it by default.

You only need to run autoconf -Wall then you see.
Ok they're not shown by default, but I don't like to have obsolte
deprecated stuff if it can be easily avoided like in this case.

> In any case, please try to avoid extra long lines where it can be easily
> avoided.

I hope the intention is now right, Emacs had a problem with it.

> Okuji wrote that he uses Autoconf 2.59, so it would be nice to check
> that your changes would still work with that version.

Luckly it's still avaible in Debian oldstable (sarge)
newest CentOS 5.2 even still has autoconf 2.59
Changes are the same as with 2.61 so 2.59 seems to be fine.


-- 
Felix Zielcke

[-- Attachment #2: autoconf.2.62 --]
[-- Type: text/x-patch, Size: 7563 bytes --]

Index: configure.ac
===================================================================
--- configure.ac	(Revision 1849)
+++ configure.ac	(Arbeitskopie)
@@ -31,8 +31,8 @@ dnl (such as TARGET_CC, TARGET_CFLAGS, e
 dnl type.
 
 
-AC_INIT(GRUB, 1.96, [bug-grub@gnu.org])
-AC_PREREQ(2.53)
+AC_INIT([GRUB],[1.96],[bug-grub@gnu.org])
+AC_PREREQ(2.62)
 AC_CONFIG_SRCDIR([include/grub/dl.h])
 AC_CONFIG_HEADER([config.h])
 
@@ -150,7 +150,7 @@ AC_PROG_CC
 # Must be GCC.
 test "x$GCC" = xyes || AC_MSG_ERROR([GCC is required])
 
-AC_GNU_SOURCE
+AC_USE_SYSTEM_EXTENSIONS
 AC_SYS_LARGEFILE
 
 # Identify characteristics of the host architecture.
@@ -266,7 +266,7 @@ if test "x$TARGET_CFLAGS" = x; then
   # optimization flags.
   AC_CACHE_CHECK([whether optimization for size works], grub_cv_cc_Os, [
     CFLAGS=-Os
-    AC_TRY_COMPILE(, , grub_cv_cc_Os=yes, grub_cv_cc_Os=no)
+    AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])],[grub_cv_cc_Os=yes],[grub_cv_cc_Os=no])
   ])
   if test "x$grub_cv_cc_Os" = xyes; then
     TARGET_CFLAGS="$TARGET_CFLAGS -Os"
@@ -278,7 +278,7 @@ if test "x$TARGET_CFLAGS" = x; then
   if test "x$target_cpu" = xi386; then
     AC_CACHE_CHECK([whether -falign-loops works], [grub_cv_cc_falign_loop], [
       CFLAGS="-falign-loops=1"
-      AC_TRY_COMPILE(, , [grub_cv_cc_falign_loop=yes], [grub_cv_cc_falign_loop=no])
+      AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])],[grub_cv_cc_falign_loop=yes],[grub_cv_cc_falign_loop=no])
     ])
 
     if test "x$grub_cv_cc_falign_loop" = xyes; then
Index: config.h.in
===================================================================
--- config.h.in	(Revision 1849)
+++ config.h.in	(Arbeitskopie)
@@ -109,17 +109,48 @@
 /* Define to 1 if you have the ANSI C header files. */
 #undef STDC_HEADERS
 
-/* Define to 1 if your processor stores words with the most significant byte
-   first (like Motorola and SPARC, unlike Intel and VAX). */
-#undef WORDS_BIGENDIAN
+/* Define WORDS_BIGENDIAN to 1 if your processor stores words with the most
+   significant byte first (like Motorola and SPARC, unlike Intel and VAX). */
+#if defined __BIG_ENDIAN__
+# define WORDS_BIGENDIAN 1
+#elif ! defined __LITTLE_ENDIAN__
+# undef WORDS_BIGENDIAN
+#endif
 
 /* Number of bits in a file offset, on hosts where this is settable. */
 #undef _FILE_OFFSET_BITS
 
+/* Define for large files, on AIX-style hosts. */
+#undef _LARGE_FILES
+
+/* Define to 1 if on MINIX. */
+#undef _MINIX
+
+/* Define to 2 if the system does not provide POSIX.1 features except with
+   this defined. */
+#undef _POSIX_1_SOURCE
+
+/* Define to 1 if you need to in order for `stat' and other things to work. */
+#undef _POSIX_SOURCE
+
+/* Enable extensions on AIX 3, Interix.  */
+#ifndef _ALL_SOURCE
+# undef _ALL_SOURCE
+#endif
 /* Enable GNU extensions on systems that have them.  */
 #ifndef _GNU_SOURCE
 # undef _GNU_SOURCE
 #endif
+/* Enable threading extensions on Solaris.  */
+#ifndef _POSIX_PTHREAD_SEMANTICS
+# undef _POSIX_PTHREAD_SEMANTICS
+#endif
+/* Enable extensions on HP NonStop.  */
+#ifndef _TANDEM_SOURCE
+# undef _TANDEM_SOURCE
+#endif
+/* Enable general extensions on Solaris.  */
+#ifndef __EXTENSIONS__
+# undef __EXTENSIONS__
+#endif
 
-/* Define for large files, on AIX-style hosts. */
-#undef _LARGE_FILES
Index: aclocal.m4
===================================================================
--- aclocal.m4	(Revision 1849)
+++ aclocal.m4	(Arbeitskopie)
@@ -2,9 +2,9 @@ dnl Check whether target compiler is wor
 AC_DEFUN(grub_PROG_TARGET_CC,
 [AC_MSG_CHECKING([whether target compiler is working])
 AC_CACHE_VAL(grub_cv_prog_target_cc,
-[AC_TRY_LINK([], [],
-   grub_cv_prog_target_cc=yes,
-   grub_cv_prog_target_cc=no)
+[AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[]])],
+[grub_cv_prog_target_cc=yes],
+[grub_cv_prog_target_cc=no])
 ])
 AC_MSG_RESULT([$grub_cv_prog_target_cc])
 
@@ -104,9 +104,9 @@ AC_DEFUN(grub_PROG_LD_BUILD_ID_NONE,
 AC_CACHE_VAL(grub_cv_prog_ld_build_id_none,
 [save_LDFLAGS="$LDFLAGS"
 LDFLAGS="$LDFLAGS -Wl,--build-id=none"
-AC_TRY_LINK([], [],
-   grub_cv_prog_ld_build_id_none=yes,
-   grub_cv_prog_ld_build_id_none=no)
+AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[]])],
+[grub_cv_prog_ld_build_id_none=yes],
+[grub_cv_prog_ld_build_id_none=no])
 LDFLAGS="$save_LDFLAGS"
 ])
 AC_MSG_RESULT([$grub_cv_prog_ld_build_id_none])
@@ -230,17 +230,17 @@ AC_DEFUN(grub_CHECK_START_SYMBOL,
 [AC_REQUIRE([AC_PROG_CC])
 AC_MSG_CHECKING([if start is defined by the compiler])
 AC_CACHE_VAL(grub_cv_check_start_symbol,
-[AC_TRY_LINK([], [asm ("incl start")],
-   grub_cv_check_start_symbol=yes,
-   grub_cv_check_start_symbol=no)])
+[AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[asm ("incl start")]])],
+[grub_cv_check_start_symbol=yes],
+[grub_cv_check_start_symbol=no])])
 
 AC_MSG_RESULT([$grub_cv_check_start_symbol])
 
 AC_MSG_CHECKING([if _start is defined by the compiler])
 AC_CACHE_VAL(grub_cv_check_uscore_start_symbol,
-[AC_TRY_LINK([], [asm ("incl _start")],
-   grub_cv_check_uscore_start_symbol=yes,
-   grub_cv_check_uscore_start_symbol=no)])
+[AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[asm ("incl _start")]])],
+[grub_cv_check_uscore_start_symbol=yes],
+[grub_cv_check_uscore_start_symbol=no])])
 
 AC_MSG_RESULT([$grub_cv_check_uscore_start_symbol])
 
@@ -261,25 +261,25 @@ AC_DEFUN(grub_CHECK_BSS_START_SYMBOL,
 [AC_REQUIRE([AC_PROG_CC])
 AC_MSG_CHECKING([if __bss_start is defined by the compiler])
 AC_CACHE_VAL(grub_cv_check_uscore_uscore_bss_start_symbol,
-[AC_TRY_LINK([], [asm ("incl __bss_start")],
-   grub_cv_check_uscore_uscore_bss_start_symbol=yes,
-   grub_cv_check_uscore_uscore_bss_start_symbol=no)])
+[AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[asm ("incl __bss_start")]])],
+[grub_cv_check_uscore_uscore_bss_start_symbol=yes],
+[grub_cv_check_uscore_uscore_bss_start_symbol=no])])
 
 AC_MSG_RESULT([$grub_cv_check_uscore_uscore_bss_start_symbol])
 
 AC_MSG_CHECKING([if edata is defined by the compiler])
 AC_CACHE_VAL(grub_cv_check_edata_symbol,
-[AC_TRY_LINK([], [asm ("incl edata")],
-   grub_cv_check_edata_symbol=yes,
-   grub_cv_check_edata_symbol=no)])
+[AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[asm ("incl edata")]])],
+[grub_cv_check_edata_symbol=yes],
+[grub_cv_check_edata_symbol=no])])
 
 AC_MSG_RESULT([$grub_cv_check_edata_symbol])
 
 AC_MSG_CHECKING([if _edata is defined by the compiler])
 AC_CACHE_VAL(grub_cv_check_uscore_edata_symbol,
-[AC_TRY_LINK([], [asm ("incl _edata")],
-   grub_cv_check_uscore_edata_symbol=yes,
-   grub_cv_check_uscore_edata_symbol=no)])
+[AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[asm ("incl _edata")]])],
+[grub_cv_check_uscore_edata_symbol=yes],
+[grub_cv_check_uscore_edata_symbol=no])])
 
 AC_MSG_RESULT([$grub_cv_check_uscore_edata_symbol])
 
@@ -302,17 +302,17 @@ AC_DEFUN(grub_CHECK_END_SYMBOL,
 [AC_REQUIRE([AC_PROG_CC])
 AC_MSG_CHECKING([if end is defined by the compiler])
 AC_CACHE_VAL(grub_cv_check_end_symbol,
-[AC_TRY_LINK([], [asm ("incl end")],
-   grub_cv_check_end_symbol=yes,
-   grub_cv_check_end_symbol=no)])
+[AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[asm ("incl end")]])],
+[grub_cv_check_end_symbol=yes],
+[grub_cv_check_end_symbol=no])])
 
 AC_MSG_RESULT([$grub_cv_check_end_symbol])
 
 AC_MSG_CHECKING([if _end is defined by the compiler])
 AC_CACHE_VAL(grub_cv_check_uscore_end_symbol,
-[AC_TRY_LINK([], [asm ("incl _end")],
-   grub_cv_check_uscore_end_symbol=yes,
-   grub_cv_check_uscore_end_symbol=no)])
+[AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[asm ("incl _end")]])],
+[grub_cv_check_uscore_end_symbol=yes],
+[grub_cv_check_uscore_end_symbol=no])])
 
 AC_MSG_RESULT([$grub_cv_check_uscore_end_symbol])
 

[-- Attachment #3: autoconf.diff.2 --]
[-- Type: text/x-patch, Size: 1327 bytes --]

Index: configure.ac
===================================================================
--- configure.ac	(Revision 1849)
+++ configure.ac	(Arbeitskopie)
@@ -31,8 +31,8 @@ dnl (such as TARGET_CC, TARGET_CFLAGS, e
 dnl type.
 
 
-AC_INIT(GRUB, 1.96, [bug-grub@gnu.org])
-AC_PREREQ(2.53)
+AC_INIT([GRUB],[1.96],[bug-grub@gnu.org])
+AC_PREREQ(2.59)
 AC_CONFIG_SRCDIR([include/grub/dl.h])
 AC_CONFIG_HEADER([config.h])
 
@@ -266,7 +266,9 @@ if test "x$TARGET_CFLAGS" = x; then
   # optimization flags.
   AC_CACHE_CHECK([whether optimization for size works], grub_cv_cc_Os, [
     CFLAGS=-Os
-    AC_TRY_COMPILE(, , grub_cv_cc_Os=yes, grub_cv_cc_Os=no)
+    AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])],
+		      [grub_cv_cc_Os=yes],
+		      [grub_cv_cc_Os=no])
   ])
   if test "x$grub_cv_cc_Os" = xyes; then
     TARGET_CFLAGS="$TARGET_CFLAGS -Os"
@@ -278,7 +280,9 @@ if test "x$TARGET_CFLAGS" = x; then
   if test "x$target_cpu" = xi386; then
     AC_CACHE_CHECK([whether -falign-loops works], [grub_cv_cc_falign_loop], [
       CFLAGS="-falign-loops=1"
-      AC_TRY_COMPILE(, , [grub_cv_cc_falign_loop=yes], [grub_cv_cc_falign_loop=no])
+      AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])],
+			[grub_cv_cc_falign_loop=yes],
+			[grub_cv_cc_falign_loop=no])
     ])
 
     if test "x$grub_cv_cc_falign_loop" = xyes; then

Re: [PATCH] update configure.ac to autoconf 2.61

[Pavel Roskin]

On Thu, 2008-09-04 at 09:45 +0200, Felix Zielcke wrote:

> > Okuji wrote that he uses Autoconf 2.59, so it would be nice to check
> > that your changes would still work with that version.
> 
> Luckly it's still avaible in Debian oldstable (sarge)
> newest CentOS 5.2 even still has autoconf 2.59
> Changes are the same as with 2.61 so 2.59 seems to be fine.

I'm fine with the shorter patch, but I'd like you to wait a couple of
days in case there are any objections.

By the way, config.h.in is a generated file, so changes to it don't need
to be published.  The same applies to configure and *.mk files.

-- 
Regards,
Pavel Roskin

Re: [PATCH] update configure.ac to autoconf 2.61

[Felix Zielcke]

Am Donnerstag, den 04.09.2008, 12:49 -0400 schrieb Pavel Roskin:

> I'm fine with the shorter patch, but I'd like you to wait a couple of
> days in case there are any objections.

Vesa said already on IRC to me that it's fine for me to but he suggests
waiting vor Okuji or Marco which I wanted to do anyway (at least with
the 2.61 requirement)

Now 2.59 shouldn't be any problem at all but yeah just in case :)

> By the way, config.h.in is a generated file, so changes to it don't need
> to be published.  The same applies to configure and *.mk files.

Yep Autoheader generates it, I just wanted to show the difference with
the newer `AC_USE_SYSTEM_EXTENSIONS' in case someone is interested :)
I saw it now even in the docs it's only supported with autoconf >= 2.60

and because I just don't know enough if it would be safe for us to just
start using it I downgraded autoconf to 2.61 for `autupdate'.

It would be better if we use for the SVN ./configure only one autoconf
version.

I just noticed that with current SVN and a ./autogen.sh with autoconf
2.62 creates the config.h.in in my 2.62 patch, which is the only
difference.
So this means that AC_GNU_SOURCE will be in the future just an alias to
it.
A little thing we maybe shouldn't forget totally :)
But for now this is really too early to change configure.ac to it.

-- 
Felix Zielcke

Re: [PATCH] update configure.ac to autoconf 2.61

[Felix Zielcke]

Well, commited.

Am Donnerstag, den 04.09.2008, 09:45 +0200 schrieb Felix Zielcke:
> Am Mittwoch, den 03.09.2008, 19:43 -0400 schrieb Pavel Roskin:
> > 
> > I don't see any old stuff being removed.  I don't see any justification
> > for any of the changes.  The new code is longer and less readable.  I
> > don't think AC_TRY_COMPILE is a big problem yet.  It's not like it won't
> > produce a valid test.
> 
> http://www.gnu.org/software/autoconf/manual/autoconf.html#Autoconf-Macro-Index
> 
> AC_TRY_COMPILE is listed as `Obsolete Macro'.
> 
> I attached now even a diff with autoconf 2.62 which I won't commit, but
> maybe you or someone else is interested.
> Changelog says AC_GNU_SOURCE has been deprecated, though they're
> currently no plans to remove it.
> 
> Currently it's not really needed but things get easily forgotten, even I
> myself forgot a patch from me ..
> We don't need to discuss running `autoupdate' in ./autogen.sh this is
> really bad.
> The Debian Build System has such a feature too but ftp-masters' reject
> packages which uses it by default.
> 
> You only need to run autoconf -Wall then you see.
> Ok they're not shown by default, but I don't like to have obsolte
> deprecated stuff if it can be easily avoided like in this case.
> 
> > In any case, please try to avoid extra long lines where it can be easily
> > avoided.
> 
> I hope the intention is now right, Emacs had a problem with it.
> 
> > Okuji wrote that he uses Autoconf 2.59, so it would be nice to check
> > that your changes would still work with that version.
> 
> Luckly it's still avaible in Debian oldstable (sarge)
> newest CentOS 5.2 even still has autoconf 2.59
> Changes are the same as with 2.61 so 2.59 seems to be fine.
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel