All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Oren Laadan <orenl@cs.columbia.edu>,
	jeremy@goop.org, arnd@arndb.de,
	containers@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [RFC v6][PATCH 0/9] Kernel based checkpoint/restart
Date: Thu, 09 Oct 2008 06:34:06 -0700	[thread overview]
Message-ID: <1223559246.11830.23.camel@nimitz> (raw)
In-Reply-To: <20081009131701.GA21112@elte.hu>

On Thu, 2008-10-09 at 15:17 +0200, Ingo Molnar wrote:
> * Dave Hansen <dave@linux.vnet.ibm.com> wrote
> > On Thu, 2008-10-09 at 14:46 +0200, Ingo Molnar wrote:
> > > i'm wondering about the following productization aspect: it would be 
> > > very useful to applications and users if they knew whether it is safe to 
> > > checkpoint a given app. I.e. whether that app has any state that cannot 
> > > be stored/restored yet.
> > 
> > Absolutely!
> > 
> > My first inclination was to do this at checkpoint time: detect and 
> > tell users why an app or container can't actually be checkpointed.  
> > But, if I get you right, you're talking about something that happens 
> > more during the runtime of the app than during the checkpoint.  This 
> > sounds like a wonderful approach to me, and much better than what I 
> > was thinking of.
> > 
> > What kind of mechanism do you have in mind?
> > 
> > int sys_remap_file_pages(...)
> > {
> >       ...
> >       oh_crap_we_dont_support_this_yet(current);
> > }
> > 
> > Then the oh_crap..() function sets a task flag or something?
> 
> yeah, something like that. A key aspect of it is that is has to be very 
> low-key on the source code level - we dont want to sprinkle the kernel 
> with anything ugly. Perhaps something pretty explicit:
> 
>   current->flags |= PF_NOCR;

Am I miscounting, or are we out of these suckers on 32-bit platforms?

> as we do the same thing today for certain facilities:
> 
>   current->flags |= PF_NOFREEZE;
> 
> you probably want to hide it behind:
> 
>   set_current_nocr();

Yeah, that all looks reasonable.  Letting this be a dynamic thing where
you can move back and forth between the two states would make a lot of
sense too.  But, for now, I guess it can be a one-way trip.

I'll cook something up real fast.

-- Dave


WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Oren Laadan <orenl@cs.columbia.edu>,
	jeremy@goop.org, arnd@arndb.de,
	containers@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [RFC v6][PATCH 0/9] Kernel based checkpoint/restart
Date: Thu, 09 Oct 2008 06:34:06 -0700	[thread overview]
Message-ID: <1223559246.11830.23.camel@nimitz> (raw)
In-Reply-To: <20081009131701.GA21112@elte.hu>

On Thu, 2008-10-09 at 15:17 +0200, Ingo Molnar wrote:
> * Dave Hansen <dave@linux.vnet.ibm.com> wrote
> > On Thu, 2008-10-09 at 14:46 +0200, Ingo Molnar wrote:
> > > i'm wondering about the following productization aspect: it would be 
> > > very useful to applications and users if they knew whether it is safe to 
> > > checkpoint a given app. I.e. whether that app has any state that cannot 
> > > be stored/restored yet.
> > 
> > Absolutely!
> > 
> > My first inclination was to do this at checkpoint time: detect and 
> > tell users why an app or container can't actually be checkpointed.  
> > But, if I get you right, you're talking about something that happens 
> > more during the runtime of the app than during the checkpoint.  This 
> > sounds like a wonderful approach to me, and much better than what I 
> > was thinking of.
> > 
> > What kind of mechanism do you have in mind?
> > 
> > int sys_remap_file_pages(...)
> > {
> >       ...
> >       oh_crap_we_dont_support_this_yet(current);
> > }
> > 
> > Then the oh_crap..() function sets a task flag or something?
> 
> yeah, something like that. A key aspect of it is that is has to be very 
> low-key on the source code level - we dont want to sprinkle the kernel 
> with anything ugly. Perhaps something pretty explicit:
> 
>   current->flags |= PF_NOCR;

Am I miscounting, or are we out of these suckers on 32-bit platforms?

> as we do the same thing today for certain facilities:
> 
>   current->flags |= PF_NOFREEZE;
> 
> you probably want to hide it behind:
> 
>   set_current_nocr();

Yeah, that all looks reasonable.  Letting this be a dynamic thing where
you can move back and forth between the two states would make a lot of
sense too.  But, for now, I guess it can be a one-way trip.

I'll cook something up real fast.

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-10-09 13:37 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-08 10:19 [RFC v6][PATCH 0/9] Kernel based checkpoint/restart Oren Laadan
2008-10-08 10:19 ` Oren Laadan
2008-10-08 10:19 ` [RFC v6][PATCH 1/9] Create syscalls: sys_checkpoint, sys_restart Oren Laadan
2008-10-08 10:19   ` Oren Laadan
2008-10-08 10:19 ` [RFC v6][PATCH 2/9] General infrastructure for checkpoint restart Oren Laadan
2008-10-08 10:19   ` Oren Laadan
2008-10-08 10:19 ` [RFC v6][PATCH 3/9] x86 support for checkpoint/restart Oren Laadan
2008-10-08 10:19   ` Oren Laadan
2008-10-10 10:21   ` Cedric Le Goater
2008-10-10 10:21     ` Cedric Le Goater
2008-10-10 10:24     ` Oren Laadan
2008-10-10 10:24       ` Oren Laadan
     [not found]     ` <48EF2CB3.9040900-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-10-10 10:24       ` Oren Laadan
     [not found]   ` <1223461197-11513-4-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2008-10-10 10:21     ` Cedric Le Goater
2008-10-08 10:19 ` [RFC v6][PATCH 4/9] Dump memory address space Oren Laadan
2008-10-08 10:19   ` Oren Laadan
2008-10-08 10:19 ` [RFC v6][PATCH 5/9] Restore " Oren Laadan
2008-10-08 10:19   ` Oren Laadan
     [not found]   ` <1223461197-11513-6-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2008-10-08 15:35     ` Dave Hansen
2008-10-08 15:35   ` Dave Hansen
2008-10-08 15:35     ` Dave Hansen
2008-10-08 10:19 ` [RFC v6][PATCH 6/9] Checkpoint/restart: initial documentation Oren Laadan
2008-10-08 10:19   ` Oren Laadan
     [not found] ` <1223461197-11513-1-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2008-10-08 10:19   ` [RFC v6][PATCH 1/9] Create syscalls: sys_checkpoint, sys_restart Oren Laadan
2008-10-08 10:19   ` [RFC v6][PATCH 2/9] General infrastructure for checkpoint restart Oren Laadan
2008-10-08 10:19   ` [RFC v6][PATCH 3/9] x86 support for checkpoint/restart Oren Laadan
2008-10-08 10:19   ` [RFC v6][PATCH 4/9] Dump memory address space Oren Laadan
2008-10-08 10:19   ` [RFC v6][PATCH 5/9] Restore " Oren Laadan
2008-10-08 10:19   ` [RFC v6][PATCH 6/9] Checkpoint/restart: initial documentation Oren Laadan
2008-10-08 10:19   ` [RFC v6][PATCH 7/9] Infrastructure for shared objects Oren Laadan
2008-10-08 10:19   ` [RFC v6][PATCH 8/9] Dump open file descriptors Oren Laadan
2008-10-08 10:19   ` [RFC v6][PATCH 9/9] Restore open file descriprtors Oren Laadan
2008-10-09 12:46   ` [RFC v6][PATCH 0/9] Kernel based checkpoint/restart Ingo Molnar
2008-10-08 10:19 ` [RFC v6][PATCH 7/9] Infrastructure for shared objects Oren Laadan
2008-10-08 10:19   ` Oren Laadan
2008-10-08 10:19 ` [RFC v6][PATCH 8/9] Dump open file descriptors Oren Laadan
2008-10-08 10:19   ` Oren Laadan
2008-10-08 10:19 ` [RFC v6][PATCH 9/9] Restore open file descriprtors Oren Laadan
2008-10-08 10:19   ` Oren Laadan
2008-10-09 12:46 ` [RFC v6][PATCH 0/9] Kernel based checkpoint/restart Ingo Molnar
2008-10-09 12:46   ` Ingo Molnar
     [not found]   ` <20081009124658.GE2952-X9Un+BFzKDI@public.gmane.org>
2008-10-09 12:58     ` Dave Hansen
2008-10-09 12:58       ` Dave Hansen
2008-10-09 12:58       ` Dave Hansen
2008-10-09 13:17       ` Ingo Molnar
2008-10-09 13:17         ` Ingo Molnar
2008-10-09 13:34         ` Dave Hansen [this message]
2008-10-09 13:34           ` Dave Hansen
2008-10-09 13:44           ` Ingo Molnar
2008-10-09 13:44             ` Ingo Molnar
2008-10-09 13:44             ` Ingo Molnar
     [not found]             ` <20081009134415.GA12135-X9Un+BFzKDI@public.gmane.org>
2008-10-09 16:50               ` Dave Hansen
2008-10-09 16:50             ` Dave Hansen
2008-10-09 16:50               ` Dave Hansen
2008-10-10 15:39               ` Ingo Molnar
2008-10-10 15:39               ` Ingo Molnar
2008-10-10 15:39                 ` Ingo Molnar
     [not found]                 ` <20081010153951.GD28977-X9Un+BFzKDI@public.gmane.org>
2008-10-13  8:13                   ` Cedric Le Goater
2008-10-13  8:13                 ` Cedric Le Goater
2008-10-13  8:13                   ` Cedric Le Goater
     [not found]                   ` <48F30315.1070909-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-10-13 16:12                     ` Oren Laadan
2008-10-13 16:43                     ` Dave Hansen
2008-10-13 16:12                   ` Oren Laadan
2008-10-13 16:12                     ` Oren Laadan
2008-10-15 15:13                     ` Cedric Le Goater
2008-10-15 15:13                       ` Cedric Le Goater
2008-10-15 23:59                       ` Oren Laadan
2008-10-15 23:59                         ` Oren Laadan
     [not found]                       ` <48F60891.1070807-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-10-15 23:59                         ` Oren Laadan
     [not found]                     ` <48F3737B.6070904-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2008-10-15 15:13                       ` Cedric Le Goater
2008-10-13 16:43                   ` Dave Hansen
2008-10-13 16:43                     ` Dave Hansen
2008-10-15 15:15                     ` Cedric Le Goater
2008-10-15 15:15                       ` Cedric Le Goater
2008-10-16  0:06                       ` Oren Laadan
2008-10-16  0:06                         ` Oren Laadan
     [not found]                         ` <48F685A3.1060804-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2008-10-16 12:35                           ` Daniel Lezcano
2008-10-16 12:35                         ` Daniel Lezcano
2008-10-16 12:35                           ` Daniel Lezcano
     [not found]                           ` <48F7352F.3020700-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-10-16 13:49                             ` Oren Laadan
2008-10-16 13:49                           ` Oren Laadan
2008-10-16 13:49                             ` Oren Laadan
2008-10-16 22:51                             ` Peter Chubb
2008-10-16 22:51                               ` Peter Chubb
2008-10-17  6:30                               ` David Newall
2008-10-17  6:30                                 ` David Newall
     [not found]                                 ` <48F83121.7070705-KzQzY1MbaKjAHznzqCTclw@public.gmane.org>
2008-10-20 17:17                                   ` Dave Hansen
2008-10-20 17:17                                     ` Dave Hansen
2008-10-20 17:17                                     ` Dave Hansen
     [not found]                               ` <87r66g8875.wl%peter-LkDQP0DxSMGxwJ88Py/mJxCuuivNXqWP@public.gmane.org>
2008-10-17  6:30                                 ` David Newall
2008-10-17  6:44                                 ` Cedric Le Goater
2008-10-17  7:08                                 ` Oren Laadan
2008-10-17  6:44                               ` Cedric Le Goater
2008-10-17  6:44                                 ` Cedric Le Goater
2008-10-17  7:08                               ` Oren Laadan
2008-10-17  7:08                                 ` Oren Laadan
     [not found]                             ` <48F74674.20202-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2008-10-16 22:51                               ` Peter Chubb
     [not found]                       ` <48F6092D.6050400-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-10-16  0:06                         ` Oren Laadan
2008-10-15 15:15                     ` Cedric Le Goater
     [not found]         ` <20081009131701.GA21112-X9Un+BFzKDI@public.gmane.org>
2008-10-09 13:34           ` Dave Hansen
2008-10-09 21:59           ` Greg Kurz
2008-10-09 21:59         ` Greg Kurz
2008-10-09 21:59           ` Greg Kurz
2008-10-09 13:17       ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2008-10-08 10:19 Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1223559246.11830.23.camel@nimitz \
    --to=dave@linux.vnet.ibm.com \
    --cc=arnd@arndb.de \
    --cc=containers@lists.linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=orenl@cs.columbia.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.