All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Trond Myklebust
	<trond.myklebust-41N18TsMXrtuMpJDpNschA@public.gmane.org>
Cc: Linux Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	"J. Bruce Fields"
	<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
	Cedric Le Goater <clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	"Eric W. Biederman"
	<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
	Linux Containers
	<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: Re: [RFC][PATCH 4/4] Represent RPC Callers
Date: Tue, 06 Jan 2009 15:05:19 -0800	[thread overview]
Message-ID: <1231283119.14345.130.camel@localhost> (raw)
In-Reply-To: <1231247062.7127.36.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>

On Tue, 2009-01-06 at 08:04 -0500, Trond Myklebust wrote:
> On Mon, 2009-01-05 at 17:13 -0800, Matt Helsley wrote:
> > plain text document attachment (move-rpc-client-nodename-cache.patch)
> > Currently RPC needs to know the nodename (often the same as the hostname) which
> > should be used for UNIX-style authentication and file-lock tracking. Because
> > hostname can change between RPC calls and some sequences of RPC calls may
> > require consistent names between calls RPC currently saves the nodename with
> > the RPC client structure.
> > 
> > This is doesn't always work because RPC clients may be discarded over the
> > lifetime of a higher level service -- like those that compose NFS. Specifically
> > this is known to happen during shutdown.
> > 
> > Hence RPC should expect the nodename to be saved by the caller when sequences
> > of RPC calls requiring consistent nodenames may be needed (e.g. NFS). To enable
> > this we introduce an RPC caller structure that allows RPC to query the caller
> > for this information.
> > 
> > This patch is not complete but is meant to indicate the direction I'm planning
> > on going. I'd like to know if there are any objections or if anyone sees a
> > better way to handle this.
> 
> You're planning on slowing down every RPC call in order to fix a problem
> on client shutdown? Why?

	I figured that the network latencies would be much larger than the
amount of time it takes to make a function call which, in the cases I
know of, would reduce to a strcpy().

Cheers,
	-Matt Helsley

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Matt Helsley <matthltc@us.ibm.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Linux Containers <containers@lists.linux-foundation.org>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Cedric Le Goater <clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-nfs@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Linux Containers
	<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: Re: [RFC][PATCH 4/4] Represent RPC Callers
Date: Tue, 06 Jan 2009 15:05:19 -0800	[thread overview]
Message-ID: <1231283119.14345.130.camel@localhost> (raw)
In-Reply-To: <1231247062.7127.36.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>

On Tue, 2009-01-06 at 08:04 -0500, Trond Myklebust wrote:
> On Mon, 2009-01-05 at 17:13 -0800, Matt Helsley wrote:
> > plain text document attachment (move-rpc-client-nodename-cache.patch)
> > Currently RPC needs to know the nodename (often the same as the hostname) which
> > should be used for UNIX-style authentication and file-lock tracking. Because
> > hostname can change between RPC calls and some sequences of RPC calls may
> > require consistent names between calls RPC currently saves the nodename with
> > the RPC client structure.
> > 
> > This is doesn't always work because RPC clients may be discarded over the
> > lifetime of a higher level service -- like those that compose NFS. Specifically
> > this is known to happen during shutdown.
> > 
> > Hence RPC should expect the nodename to be saved by the caller when sequences
> > of RPC calls requiring consistent nodenames may be needed (e.g. NFS). To enable
> > this we introduce an RPC caller structure that allows RPC to query the caller
> > for this information.
> > 
> > This patch is not complete but is meant to indicate the direction I'm planning
> > on going. I'd like to know if there are any objections or if anyone sees a
> > better way to handle this.
> 
> You're planning on slowing down every RPC call in order to fix a problem
> on client shutdown? Why?

	I figured that the network latencies would be much larger than the
amount of time it takes to make a function call which, in the cases I
know of, would reduce to a strcpy().

Cheers,
	-Matt Helsley


WARNING: multiple messages have this Message-ID (diff)
From: Matt Helsley <matthltc@us.ibm.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Linux Containers <containers@lists.linux-foundation.org>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Cedric Le Goater <clg@fr.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-nfs@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Linux Containers <containers@lists.osdl.org>
Subject: Re: [RFC][PATCH 4/4] Represent RPC Callers
Date: Tue, 06 Jan 2009 15:05:19 -0800	[thread overview]
Message-ID: <1231283119.14345.130.camel@localhost> (raw)
In-Reply-To: <1231247062.7127.36.camel@heimdal.trondhjem.org>

On Tue, 2009-01-06 at 08:04 -0500, Trond Myklebust wrote:
> On Mon, 2009-01-05 at 17:13 -0800, Matt Helsley wrote:
> > plain text document attachment (move-rpc-client-nodename-cache.patch)
> > Currently RPC needs to know the nodename (often the same as the hostname) which
> > should be used for UNIX-style authentication and file-lock tracking. Because
> > hostname can change between RPC calls and some sequences of RPC calls may
> > require consistent names between calls RPC currently saves the nodename with
> > the RPC client structure.
> > 
> > This is doesn't always work because RPC clients may be discarded over the
> > lifetime of a higher level service -- like those that compose NFS. Specifically
> > this is known to happen during shutdown.
> > 
> > Hence RPC should expect the nodename to be saved by the caller when sequences
> > of RPC calls requiring consistent nodenames may be needed (e.g. NFS). To enable
> > this we introduce an RPC caller structure that allows RPC to query the caller
> > for this information.
> > 
> > This patch is not complete but is meant to indicate the direction I'm planning
> > on going. I'd like to know if there are any objections or if anyone sees a
> > better way to handle this.
> 
> You're planning on slowing down every RPC call in order to fix a problem
> on client shutdown? Why?

	I figured that the network latencies would be much larger than the
amount of time it takes to make a function call which, in the cases I
know of, would reduce to a strcpy().

Cheers,
	-Matt Helsley


  parent reply	other threads:[~2009-01-06 23:05 UTC|newest]

Thread overview: 135+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-06  1:13 [RFC][PATCH 0/4] utsns: RPC/NFS bug rework Matt Helsley
2009-01-06  1:13 ` [RFC][PATCH 1/4] Remove useless utsname.h includes Matt Helsley
2009-01-06  1:13 ` Matt Helsley
2009-01-06  1:13   ` Matt Helsley
2009-01-06  1:13 ` [RFC][PATCH 2/4] sunrpc: Use utsnamespaces Matt Helsley
2009-01-06  1:13   ` Matt Helsley
2009-01-06  1:13   ` Matt Helsley
     [not found]   ` <20090106011314.961946803-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-01-06 20:02     ` Serge E. Hallyn
2009-01-06 20:02       ` Serge E. Hallyn
2009-01-06 20:02       ` Serge E. Hallyn
     [not found]       ` <20090106200229.GA17031-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-01-06 20:20         ` J. Bruce Fields
2009-01-06 20:20           ` J. Bruce Fields
2009-01-06 20:20           ` J. Bruce Fields
     [not found]           ` <20090106202046.GF5901-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2009-01-06 21:53             ` Serge E. Hallyn
2009-01-06 21:53               ` Serge E. Hallyn
2009-01-06 21:53               ` Serge E. Hallyn
     [not found]               ` <20090106215324.GD18147-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-01-06 23:35                 ` Matt Helsley
2009-01-06 23:35                   ` Matt Helsley
2009-01-06 23:35                   ` Matt Helsley
2009-01-06 22:43             ` Matt Helsley
2009-01-06 22:43               ` Matt Helsley
2009-01-06 22:43               ` Matt Helsley
2009-01-06 20:44         ` Trond Myklebust
2009-01-06 20:44           ` Trond Myklebust
2009-01-06 20:44           ` Trond Myklebust
     [not found]           ` <1231274682.20316.65.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-06 21:58             ` Serge E. Hallyn
2009-01-06 21:58               ` Serge E. Hallyn
2009-01-06 21:58               ` Serge E. Hallyn
2009-01-06 22:42               ` Trond Myklebust
     [not found]                 ` <1231281732.4173.6.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-07  0:08                   ` Matt Helsley
2009-01-07  0:08                     ` Matt Helsley
2009-01-07  0:08                     ` Matt Helsley
2009-01-07  0:20                     ` Trond Myklebust
2009-01-07  0:20                       ` Trond Myklebust
2009-01-07  0:20                       ` Trond Myklebust
     [not found]                       ` <1231287619.11487.2.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-07  0:43                         ` Matt Helsley
2009-01-07  0:43                           ` Matt Helsley
2009-01-07  0:43                           ` Matt Helsley
2009-01-07  1:10                           ` Trond Myklebust
2009-01-07  1:10                             ` Trond Myklebust
2009-01-07  1:10                             ` Trond Myklebust
2009-01-07  0:20                     ` J. Bruce Fields
2009-01-07  0:20                       ` J. Bruce Fields
2009-01-07  0:20                       ` J. Bruce Fields
     [not found]                       ` <20090107002024.GJ13785-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2009-01-07  0:23                         ` Trond Myklebust
2009-01-07  0:23                           ` Trond Myklebust
2009-01-07  0:23                           ` Trond Myklebust
     [not found]                           ` <1231287791.11487.4.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-07  3:44                             ` Matt Helsley
2009-01-07  3:44                               ` Matt Helsley
2009-01-07  3:44                               ` Matt Helsley
     [not found]               ` <20090106215831.GE18147-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-01-06 23:04                 ` Eric W. Biederman
2009-01-06 23:04                   ` Eric W. Biederman
2009-01-06 23:04                   ` Eric W. Biederman
     [not found]                   ` <m1eizg11fy.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2009-01-06 23:15                     ` Trond Myklebust
2009-01-06 23:15                       ` Trond Myklebust
2009-01-06 23:15                       ` Trond Myklebust
     [not found]                       ` <1231283734.8041.6.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-06 23:32                         ` J. Bruce Fields
2009-01-06 23:32                           ` J. Bruce Fields
2009-01-06 23:32                           ` J. Bruce Fields
     [not found]                           ` <20090106233238.GD13785-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2009-01-06 23:35                             ` Trond Myklebust
2009-01-06 23:35                               ` Trond Myklebust
2009-01-06 23:35                               ` Trond Myklebust
     [not found]                               ` <1231284943.8041.8.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-06 23:48                                 ` Matt Helsley
2009-01-06 23:48                                   ` Matt Helsley
2009-01-06 23:48                                   ` Matt Helsley
2009-01-06 23:51                                 ` Chuck Lever
2009-01-06 23:51                                   ` Chuck Lever
2009-01-06 23:51                                   ` Chuck Lever
2009-01-06 23:53                                 ` J. Bruce Fields
2009-01-06 23:53                                   ` J. Bruce Fields
2009-01-06 23:53                                   ` J. Bruce Fields
     [not found]                                   ` <20090106235322.GE13785-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2009-01-07  0:07                                     ` Matt Helsley
2009-01-07  0:07                                       ` Matt Helsley
2009-01-07  0:07                                       ` Matt Helsley
2009-01-07  0:55                                       ` Eric W. Biederman
2009-01-07  0:55                                         ` Eric W. Biederman
2009-01-07  0:55                                         ` Eric W. Biederman
2009-01-07  0:20                                     ` Trond Myklebust
2009-01-07  0:20                                       ` Trond Myklebust
2009-01-07  0:20                                       ` Trond Myklebust
2009-01-07  0:20                                 ` Trond Myklebust
2009-01-07  0:20                                   ` Trond Myklebust
2009-01-07  0:20                                   ` Trond Myklebust
     [not found]                                   ` <1231287607.11487.0.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-07  0:26                                     ` J. Bruce Fields
2009-01-07  0:26                                       ` J. Bruce Fields
2009-01-07  0:26                                       ` J. Bruce Fields
     [not found]                                       ` <20090107002608.GK13785-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2009-01-07  0:38                                         ` Trond Myklebust
2009-01-07  0:38                                           ` Trond Myklebust
2009-01-07  0:38                                           ` Trond Myklebust
     [not found]                                           ` <1231288706.11487.15.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-07  1:44                                             ` J. Bruce Fields
2009-01-07  1:44                                               ` J. Bruce Fields
2009-01-07  1:44                                               ` J. Bruce Fields
     [not found]                                               ` <20090107014422.GA17913-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2009-01-07  1:50                                                 ` Trond Myklebust
2009-01-07  1:50                                                   ` Trond Myklebust
2009-01-07  1:50                                                   ` Trond Myklebust
2009-01-07  2:37                                                 ` Eric W. Biederman
2009-01-07  2:37                                                   ` Eric W. Biederman
2009-01-07  2:37                                                   ` Eric W. Biederman
2009-01-06 23:30                 ` Matt Helsley
2009-01-06 23:30                   ` Matt Helsley
2009-01-06 23:30                   ` Matt Helsley
2009-01-06 23:18             ` Matt Helsley
2009-01-06 23:18               ` Matt Helsley
2009-01-06 23:18               ` Matt Helsley
2009-01-06 23:43               ` Trond Myklebust
2009-01-06 23:43                 ` Trond Myklebust
2009-01-06 23:43                 ` Trond Myklebust
     [not found]                 ` <1231285417.8041.15.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-06 23:58                   ` Matt Helsley
2009-01-06 23:58                     ` Matt Helsley
2009-01-06 23:58                     ` Matt Helsley
2009-01-06 22:29         ` Chuck Lever
2009-01-06 22:29           ` Chuck Lever
2009-01-06 22:29           ` Chuck Lever
     [not found]           ` <FB1BAB9F-25D4-449F-A66D-D1CC705F3741-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-01-07  0:01             ` Serge E. Hallyn
2009-01-07  0:01               ` Serge E. Hallyn
2009-01-07  0:01               ` Serge E. Hallyn
2009-01-06  1:13 ` [RFC][PATCH 3/4] sunrpc: Improve UTS namespace workaround Matt Helsley
2009-01-06  1:13   ` Matt Helsley
2009-01-06  1:13   ` Matt Helsley
     [not found]   ` <20090106011315.100081168-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-01-06 16:02     ` Chuck Lever
2009-01-06 16:02       ` Chuck Lever
     [not found]       ` <E184097A-C995-4C92-9608-A97B43E750E0-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-01-07  0:28         ` Matt Helsley
2009-01-07  0:28           ` Matt Helsley
2009-01-07  0:28           ` Matt Helsley
2009-01-07  3:02         ` Matt Helsley
2009-01-07  3:02           ` Matt Helsley
2009-01-07  3:02           ` Matt Helsley
2009-01-06  1:13 ` [RFC][PATCH 4/4] Represent RPC Callers Matt Helsley
2009-01-06  1:13   ` Matt Helsley
2009-01-06  1:13   ` Matt Helsley
     [not found]   ` <20090106011315.229045829-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-01-06 13:04     ` Trond Myklebust
2009-01-06 13:04       ` Trond Myklebust
     [not found]       ` <1231247062.7127.36.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-01-06 23:05         ` Matt Helsley [this message]
2009-01-06 23:05           ` Matt Helsley
2009-01-06 23:05           ` Matt Helsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1231283119.14345.130.camel@localhost \
    --to=matthltc-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org \
    --cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=trond.myklebust-41N18TsMXrtuMpJDpNschA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.