From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp
Date: Wed, 21 Jan 2009 12:30:57 -0500 [thread overview]
Message-ID: <1232559057.17462.2.camel@dv> (raw)
In-Reply-To: <49771040.7010509@impulze.org>
On Wed, 2009-01-21 at 13:08 +0100, Daniel Mierswa wrote:
> Hi list,
> during testing I found that the UUID is checked case-dependend in
> search.c, which is probably not wanted (I hope).
> Also the grub_strncasecmp function returned (int) *s1 - (int) *s2 which
> is wrong if you compare it to the C library strncasecmp.
I agree, that's definitely wrong. Good catch!
> I fixed that and used the same algorithm which is used in grub_strncmp
> (Taking a grub_size_t instead of int and checked the decremented value
> in the loop). I also added strcasecmp for consistency reasons which is
> used by search.c now.
> I'd appreciate your your replies.
The patch looks good to me. I would split changes to commands/search.c
into a separate commit.
Please provide ChangeLog entries for the patches.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-01-21 17:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 12:08 [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp Daniel Mierswa
2009-01-21 17:30 ` Pavel Roskin [this message]
2009-01-23 9:51 ` Daniel Mierswa
2009-01-26 4:41 ` Pavel Roskin
2009-01-26 18:28 ` Daniel Mierswa
2009-01-28 1:49 ` Pavel Roskin
2009-01-28 4:02 ` Pavel Roskin
2009-01-28 8:31 ` ebik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232559057.17462.2.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.