From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp
Date: Sun, 25 Jan 2009 23:41:49 -0500 [thread overview]
Message-ID: <1232944909.1604.18.camel@dv> (raw)
In-Reply-To: <49799320.1000300@impulze.org>
On Fri, 2009-01-23 at 10:51 +0100, Daniel Mierswa wrote:
> Am 01/21/09 18:30, Pavel Roskin schrieb:
> > The patch looks good to me. I would split changes to commands/search.c
> > into a separate commit.
> >
> > Please provide ChangeLog entries for the patches.
> >
> I will comply. Thanks for your quick response.
I'll appreciate if you write your Changelog entries according to the GNU
coding standards. In particular, please don't abbreviate function
names.
> 2009-01-23 Daniel Mierswa <impulze@impulze.org>
> * commands/search.c: caseless UUID comparing
We have a very similar function search_fs_uuid() in disk/fs_uuid.c, and
it still uses grub_strcmp(). Should it be using grub_strcasecmp() as
well? Can we export that function to reuse it in commands/search.c?
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-01-26 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 12:08 [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp Daniel Mierswa
2009-01-21 17:30 ` Pavel Roskin
2009-01-23 9:51 ` Daniel Mierswa
2009-01-26 4:41 ` Pavel Roskin [this message]
2009-01-26 18:28 ` Daniel Mierswa
2009-01-28 1:49 ` Pavel Roskin
2009-01-28 4:02 ` Pavel Roskin
2009-01-28 8:31 ` ebik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232944909.1604.18.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.