From: ebik <ebik@drak.ucw.cz>
To: grub-devel@gnu.org
Subject: Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp
Date: Wed, 28 Jan 2009 09:31:17 +0100 [thread overview]
Message-ID: <20090128093117.63a94857@Logran.cub> (raw)
In-Reply-To: <1233115372.2431.51.camel@dv>
On Tue, 27 Jan 2009 23:02:52 -0500
Pavel Roskin <proski@gnu.org> wrote:
> P.S. The reuse would be impractical. fs_uuid is a separate module,
> not the core. Reusing search_fs_uuid() would make the "search" module
> depend on "fs_uuid". In my opinion, it's not worth the trouble to
> introduce that dependency. It's not like we would save a lot of code.
Inlining or macro may be considered at that point. (I.e., reusing code
via .h file.) If someone will try to change such function (e.g., to
provide HisNewFs) then he need not to patch two places.
--
Tomáš 'ebík' Ebenlendr
http://get.to/ebik
PF 2009.07504223744
prev parent reply other threads:[~2009-01-28 8:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 12:08 [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp Daniel Mierswa
2009-01-21 17:30 ` Pavel Roskin
2009-01-23 9:51 ` Daniel Mierswa
2009-01-26 4:41 ` Pavel Roskin
2009-01-26 18:28 ` Daniel Mierswa
2009-01-28 1:49 ` Pavel Roskin
2009-01-28 4:02 ` Pavel Roskin
2009-01-28 8:31 ` ebik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090128093117.63a94857@Logran.cub \
--to=ebik@drak.ucw.cz \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.