Re: [PATCH] swap real_to_prot() and prot_to_real() (Re: [PATCH] i386-qemu port)

[Pavel Roskin <proski@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

On Sun, 2009-06-21 at 21:52 +0200, Robert Millan wrote:
> When doing the i386-coreboot port I made this choice completely backwards.
> 
> I thought real_to_prot() was only useful on i386-pc, because we needed it
> for returning from BIOS, and prot_to_real() was useful elsewhere, because
> the Linux loader would use it.
> 
> Turns out we need real_to_prot() on i386-qemu for the initial transition
> to i386 mode, AND we don't need prot_to_real() anywhere other than i386-pc,
> because OSes that expect to be loaded in i8086 mode are going to rely on
> BIOS calls.
> 
> So this patch swaps them.  real_to_prot() goes to realmode.S and
> prot_to_real() back to startup.S.

You have my approval as long as it compiles and doesn't introduce any
warnings.

I'm attaching the script I'm using to test all platforms at once.  The
compiler path needs to be adjusted, as well as the target names, as they
affect search for the target compiler.  That's the version with qemu
support.  If every Log2make is empty, please go ahead.

-- 
Regards,
Pavel Roskin

[-- Attachment #2: grub-all-qemu --]
[-- Type: application/x-shellscript, Size: 620 bytes --]