Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port))

[Pavel Roskin <proski@gnu.org>]

On Thu, 2009-06-25 at 22:31 +0200, Robert Millan wrote:

> You mean for efiemu?  Seems fine.  But I wouldn't use "target/host"
> naming, since it doesn't match with existing usage of those names
> elsewhere, which makes it very confusing.
> 
> How about "native/cross"?

Fine with me.  Whatever is meaningful.

> I agree there's no point in making all architectures do this.  However,
> note that we'll probably see more architectures with read-only modules
> in the future (other qemu ports, but also any port where GRUB runs
> standalone).
> 
> I was thinking that we could just #ifdef the symtab allocation (and the
> symtab field declaration as well).  Since it's just a few lines, I think
> it'll look readable.

I'd like to avoid preprocessor conditionals in kern/ARCH/dl.c files if
possible.  There is no harm in keeping mod->symtab and using it instead
of the local "symtab" variables.

-- 
Regards,
Pavel Roskin