From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] rename kernel.elf to kernel.img (Re: [PATCH] i386-qemu port)
Date: Sun, 21 Jun 2009 22:20:04 -0400 [thread overview]
Message-ID: <1245637204.9864.78.camel@mj> (raw)
In-Reply-To: <20090621191934.GA21827@thorin>
On Sun, 2009-06-21 at 21:19 +0200, Robert Millan wrote:
> If you check my earlier patch, you'll see i386-qemu.rmk is just a stub
> that includes i386-coreboot.rmk. This is to reduce code duplication
> (untill we have a more flexible build system).
>
> This patch renames kernel.elf to kernel.img in ELF platforms, so that
> more variables / etc can be shared with non-ELF ones.
No objections as long as it compiles without warnings. Sharing more
code is a good thing.
By please note that I had to add kernel_elf_ASFLAGS in
i386-ieee1275.rmk, or with would not compile on x86_64, as some compiler
invocations would miss -m32. So you patch will need to be adjusted for
that.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-06-22 2:20 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-21 18:17 [PATCH] i386-qemu port Robert Millan
2009-06-21 18:50 ` does module area require alignment? (Re: [PATCH] i386-qemu port) Robert Millan
2009-06-21 19:08 ` Pavel Roskin
2009-06-21 19:33 ` Robert Millan
2009-06-22 12:31 ` [PATCH] define GRUB_MOD_ALIGN to 0 on non-ieee1275 (Re: does module area require alignment? (Re: [PATCH] i386-qemu port)) Robert Millan
2009-06-22 19:43 ` Pavel Roskin
2009-06-22 20:41 ` Robert Millan
2009-06-22 20:51 ` Pavel Roskin
2009-06-22 21:22 ` Robert Millan
2009-06-22 21:45 ` Pavel Roskin
2009-06-22 22:31 ` Robert Millan
2009-06-22 19:51 ` does module area require alignment? (Re: [PATCH] i386-qemu port) Pavel Roskin
2009-06-22 22:50 ` Vladimir 'phcoder' Serbinenko
2009-06-23 0:10 ` Pavel Roskin
2009-06-21 18:54 ` [PATCH] move grub_stop() " Robert Millan
2009-06-21 19:05 ` Pavel Roskin
2009-06-21 19:25 ` Robert Millan
2009-06-22 2:14 ` Pavel Roskin
2009-06-22 10:10 ` Robert Millan
2009-06-22 16:16 ` Pavel Roskin
2009-06-22 18:05 ` Robert Millan
2009-06-21 19:00 ` [PATCH] i386-qemu port Pavel Roskin
2009-06-21 19:30 ` Robert Millan
2009-06-22 12:45 ` Robert Millan
2009-06-21 20:34 ` Robert Millan
2009-06-21 20:40 ` Vladimir 'phcoder' Serbinenko
2009-06-21 19:19 ` [PATCH] rename kernel.elf to kernel.img (Re: [PATCH] i386-qemu port) Robert Millan
2009-06-22 2:20 ` Pavel Roskin [this message]
2009-06-22 10:27 ` Robert Millan
2009-06-21 19:52 ` [PATCH] swap real_to_prot() and prot_to_real() " Robert Millan
2009-06-22 1:56 ` Pavel Roskin
2009-06-22 10:45 ` Robert Millan
2009-06-21 20:22 ` [PATCH] i386-qemu port Robert Millan
2009-06-22 1:50 ` Pavel Roskin
2009-06-22 10:57 ` Robert Millan
2009-06-21 22:53 ` [PATCH] access gdtdesc on segment 0 unconditionally (Re: [PATCH] i386-qemu port) Robert Millan
2009-06-22 1:22 ` Pavel Roskin
2009-06-22 9:52 ` Robert Millan
2009-06-22 19:39 ` Pavel Roskin
2009-06-22 20:52 ` Robert Millan
2009-06-22 21:32 ` Robert Millan
2009-06-22 21:44 ` Pavel Roskin
2009-06-22 22:43 ` Robert Millan
2009-06-23 0:53 ` Pavel Roskin
2009-06-23 11:02 ` Robert Millan
2009-06-22 21:36 ` Pavel Roskin
2009-06-22 22:52 ` Robert Millan
2009-06-22 10:26 ` about Apple compiler (Re: [PATCH] access gdtdesc on segment 0 unconditionally (Re: [PATCH] i386-qemu port)) Robert Millan
2009-06-22 16:10 ` Pavel Roskin
2009-06-22 15:02 ` [PATCH] s/GRUB_MEMORY_MACHINE_LINK_ADDR/GRUB_KERNEL_MACHINE_LINK_ADDR/g (Re: [PATCH] i386-qemu port) Robert Millan
2009-06-22 19:00 ` Pavel Roskin
2009-06-22 23:07 ` clean patch for i386-qemu port " Robert Millan
2009-06-23 1:29 ` Pavel Roskin
2009-06-23 11:38 ` Robert Millan
2009-06-23 12:13 ` Robert Millan
2009-06-24 1:00 ` Robert Millan
2009-06-24 23:10 ` [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)) Robert Millan
2009-06-25 19:53 ` Pavel Roskin
2009-06-25 20:31 ` Robert Millan
2009-06-25 20:51 ` Pavel Roskin
2009-06-26 14:41 ` Robert Millan
2009-06-26 16:44 ` Pavel Roskin
2009-06-26 17:03 ` Robert Millan
2009-06-26 17:16 ` Pavel Roskin
2009-06-26 17:43 ` Robert Millan
2009-06-26 19:52 ` Pavel Roskin
2009-06-26 22:26 ` Pavel Roskin
2009-06-26 23:57 ` Robert Millan
2009-06-27 3:08 ` Pavel Roskin
2009-06-27 11:18 ` Robert Millan
2009-06-29 3:48 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245637204.9864.78.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.