Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port))

[Pavel Roskin <proski@gnu.org>]

On Sat, 2009-06-27 at 01:57 +0200, Robert Millan wrote:
> On Fri, Jun 26, 2009 at 06:26:57PM -0400, Pavel Roskin wrote:
> > --- a/include/grub/elf.h
> > +++ b/include/grub/elf.h
> > @@ -2330,4 +2330,48 @@ typedef Elf32_Addr Elf32_Conflict;
> >  
> >  #define R_X86_64_NUM		24
> >  
> > +#ifndef DEFAULT_ELF_BITS
> > +#define DEFAULT_ELF_BITS (8 * GRUB_TARGET_SIZEOF_VOID_P)
> > +#endif
> 
> Nice trick.  But it's not ELF-specific, so why not put it in the
> same header that defines GRUB_TARGET_SIZEOF_VOID_P ? (with a different
> name of course)

Good idea!  Now it's GRUB_TARGET_WORDSIZE.  The first patch has been
committed.  The second patch should probably go after the qemu patch.

-- 
Regards,
Pavel Roskin