From: Artem Bityutskiy <dedekind@infradead.org>
To: subrata@linux.vnet.ibm.com
Cc: Sachin P Sant <sachinp@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux-mtd@lists.infradead.org,
Adrian Hunter <adrian.hunter@nokia.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>
Subject: Re: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c
Date: Thu, 16 Jul 2009 14:12:45 +0300 [thread overview]
Message-ID: <1247742765.11353.114.camel@localhost.localdomain> (raw)
In-Reply-To: <1247742274.5572.8.camel@subratamodak.linux.ibm.com>
On Thu, 2009-07-16 at 16:34 +0530, Subrata Modak wrote:
> Correct. There has been other warning fixes i have sent to LKML, where i
> have tweaked the code to fix the compilation, but, code tweaking may not
> be possible in this case. However , i would still investigate.
I do not think that in _general_ it is a good idea to tweak code just
to have gcc pleased, granted the code is correct. In this case it is
more preferable to shut it up, e.g., using 'unitialized_var()'.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind@infradead.org>
To: subrata@linux.vnet.ibm.com
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux-mtd@lists.infradead.org,
Adrian Hunter <adrian.hunter@nokia.com>,
Sachin P Sant <sachinp@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c
Date: Thu, 16 Jul 2009 14:12:45 +0300 [thread overview]
Message-ID: <1247742765.11353.114.camel@localhost.localdomain> (raw)
In-Reply-To: <1247742274.5572.8.camel@subratamodak.linux.ibm.com>
On Thu, 2009-07-16 at 16:34 +0530, Subrata Modak wrote:
> Correct. There has been other warning fixes i have sent to LKML, where i
> have tweaked the code to fix the compilation, but, code tweaking may not
> be possible in this case. However , i would still investigate.
I do not think that in _general_ it is a good idea to tweak code just
to have gcc pleased, granted the code is correct. In this case it is
more preferable to shut it up, e.g., using 'unitialized_var()'.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2009-07-16 11:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 2:19 [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c Subrata Modak
2009-07-15 2:19 ` Subrata Modak
2009-07-15 6:52 ` Artem Bityutskiy
2009-07-15 6:52 ` Artem Bityutskiy
2009-07-15 18:16 ` Stefan Richter
2009-07-15 18:16 ` Stefan Richter
2009-07-16 9:57 ` Artem Bityutskiy
2009-07-16 9:57 ` Artem Bityutskiy
2009-07-16 11:04 ` Subrata Modak
2009-07-16 11:04 ` Subrata Modak
2009-07-16 11:12 ` Artem Bityutskiy [this message]
2009-07-16 11:12 ` Artem Bityutskiy
2009-07-16 11:21 ` Subrata Modak
2009-07-16 11:21 ` Subrata Modak
2009-07-16 11:46 ` Stefan Richter
2009-07-16 11:46 ` Stefan Richter
2009-07-16 11:29 ` Stefan Richter
2009-07-16 11:29 ` Stefan Richter
2009-07-16 11:57 ` Stefan Richter
2009-07-16 11:57 ` Stefan Richter
2009-07-16 12:11 ` Artem Bityutskiy
2009-07-16 12:11 ` Artem Bityutskiy
2009-07-16 12:09 ` Artem Bityutskiy
2009-07-16 12:09 ` Artem Bityutskiy
-- strict thread matches above, loose matches on Subject: below --
2009-07-16 12:41 Subrata Modak
2009-07-16 12:41 ` Subrata Modak
2009-07-16 12:54 ` Artem Bityutskiy
2009-07-16 12:54 ` Artem Bityutskiy
2009-07-16 13:10 ` Subrata Modak
2009-07-16 13:10 ` Subrata Modak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247742765.11353.114.camel@localhost.localdomain \
--to=dedekind@infradead.org \
--cc=adrian.hunter@nokia.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=sachinp@linux.vnet.ibm.com \
--cc=stefanr@s5r6.in-berlin.de \
--cc=subrata@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.