From: Subrata Modak <subrata@linux.vnet.ibm.com>
To: dedekind@infradead.org
Cc: Sachin P Sant <sachinp@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux-mtd@lists.infradead.org,
Adrian Hunter <adrian.hunter@nokia.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>
Subject: Re: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c
Date: Thu, 16 Jul 2009 18:40:18 +0530 [thread overview]
Message-ID: <1247749820.5572.14.camel@subratamodak.linux.ibm.com> (raw)
In-Reply-To: <1247748885.11353.156.camel@localhost.localdomain>
On Thu, 2009-07-16 at 15:54 +0300, Artem Bityutskiy wrote:
> On Thu, 2009-07-16 at 18:11 +0530, Subrata Modak wrote:
> > does not use:
> > "const struct ubifs_info *c"
> > inside the inline function. I do not see any practical usage of
> > "const struct ubifs_info *c" in the functions key_read() and key_write().
> > Is there something which i am missing to understand ?
> >
> > When i applied the following patch, still the "fs/ubifs/" code compiled fine.
> > If the below fix is correct, i can try fixing some other functions i saw
> > having similar defects.
>
> Yeah, I think the reason why we have this extra argument there is that
> we assumed there will be several key schemes. It is possible to add more
> than one, but we use only one.
>
> Since you have already spent your time for this, could you please check
> if removing this 'c' makes the code smaller? If not, I'd prefer not to
Ok. I would let you know soon.
Regards--
Subrata
> remove it.
>
WARNING: multiple messages have this Message-ID (diff)
From: Subrata Modak <subrata@linux.vnet.ibm.com>
To: dedekind@infradead.org
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
Adrian Hunter <adrian.hunter@nokia.com>,
Sachin P Sant <sachinp@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
linux-mtd@lists.infradead.org,
Balbir Singh <balbir@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c
Date: Thu, 16 Jul 2009 18:40:18 +0530 [thread overview]
Message-ID: <1247749820.5572.14.camel@subratamodak.linux.ibm.com> (raw)
In-Reply-To: <1247748885.11353.156.camel@localhost.localdomain>
On Thu, 2009-07-16 at 15:54 +0300, Artem Bityutskiy wrote:
> On Thu, 2009-07-16 at 18:11 +0530, Subrata Modak wrote:
> > does not use:
> > "const struct ubifs_info *c"
> > inside the inline function. I do not see any practical usage of
> > "const struct ubifs_info *c" in the functions key_read() and key_write().
> > Is there something which i am missing to understand ?
> >
> > When i applied the following patch, still the "fs/ubifs/" code compiled fine.
> > If the below fix is correct, i can try fixing some other functions i saw
> > having similar defects.
>
> Yeah, I think the reason why we have this extra argument there is that
> we assumed there will be several key schemes. It is possible to add more
> than one, but we use only one.
>
> Since you have already spent your time for this, could you please check
> if removing this 'c' makes the code smaller? If not, I'd prefer not to
Ok. I would let you know soon.
Regards--
Subrata
> remove it.
>
next prev parent reply other threads:[~2009-07-16 13:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 12:41 [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c Subrata Modak
2009-07-16 12:41 ` Subrata Modak
2009-07-16 12:54 ` Artem Bityutskiy
2009-07-16 12:54 ` Artem Bityutskiy
2009-07-16 13:10 ` Subrata Modak [this message]
2009-07-16 13:10 ` Subrata Modak
-- strict thread matches above, loose matches on Subject: below --
2009-07-15 2:19 Subrata Modak
2009-07-15 2:19 ` Subrata Modak
2009-07-15 6:52 ` Artem Bityutskiy
2009-07-15 6:52 ` Artem Bityutskiy
2009-07-15 18:16 ` Stefan Richter
2009-07-15 18:16 ` Stefan Richter
2009-07-16 9:57 ` Artem Bityutskiy
2009-07-16 9:57 ` Artem Bityutskiy
2009-07-16 11:04 ` Subrata Modak
2009-07-16 11:04 ` Subrata Modak
2009-07-16 11:12 ` Artem Bityutskiy
2009-07-16 11:12 ` Artem Bityutskiy
2009-07-16 11:21 ` Subrata Modak
2009-07-16 11:21 ` Subrata Modak
2009-07-16 11:46 ` Stefan Richter
2009-07-16 11:46 ` Stefan Richter
2009-07-16 11:29 ` Stefan Richter
2009-07-16 11:29 ` Stefan Richter
2009-07-16 11:57 ` Stefan Richter
2009-07-16 11:57 ` Stefan Richter
2009-07-16 12:11 ` Artem Bityutskiy
2009-07-16 12:11 ` Artem Bityutskiy
2009-07-16 12:09 ` Artem Bityutskiy
2009-07-16 12:09 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247749820.5572.14.camel@subratamodak.linux.ibm.com \
--to=subrata@linux.vnet.ibm.com \
--cc=adrian.hunter@nokia.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=dedekind@infradead.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=sachinp@linux.vnet.ibm.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.