Patch to compile boot.img properly on OSX

Patch to compile boot.img properly on OSX

[Yves Blusseau]

Hi,

Pavel, is it ok to commit the patch so we can generate boot.img from  
OSX ? (using L_ label as far as i remember).

Regards,
Yves Blusseau

Re: Patch to compile boot.img properly on OSX

[Pavel Roskin]

On Wed, 2009-07-29 at 11:14 +0200, Yves Blusseau wrote:
> Hi,
> 
> Pavel, is it ok to commit the patch so we can generate boot.img from  
> OSX ? (using L_ label as far as i remember).

In response to that patch, I was requested to create a private grub
repository with separate branches for every patch.

I'll need to do that or write an explanation why I won't do it.  At the
moment, I don't have time for either of that.

I don't think it would be a good idea to commit a patch if there is a
pending request for action and no approvals, especially since it was a
request for testing.

Besides, this patch only fixes one file.  We have several images that
need the same treatment.  Also, the problem with lnxboot.S spilled into
the build system.  This will need to be cleaned up as well.

-- 
Regards,
Pavel Roskin

Re: Patch to compile boot.img properly on OSX

[Vladimir 'phcoder' Serbinenko]

On Thu, Jul 30, 2009 at 7:37 AM, Pavel Roskin<proski@gnu.org> wrote:
> On Wed, 2009-07-29 at 11:14 +0200, Yves Blusseau wrote:
>> Hi,
>>
>> Pavel, is it ok to commit the patch so we can generate boot.img from
>> OSX ? (using L_ label as far as i remember).
>
> In response to that patch, I was requested to create a private grub
> repository with separate branches for every patch.
>
> I'll need to do that or write an explanation why I won't do it.  At the
> moment, I don't have time for either of that.
>
This wasn't specific for the patch. Neither was it a requirement, but
more an idea. It's your work and you can choose to do it the way you
like.
> I don't think it would be a good idea to commit a patch if there is a
> pending request for action and no approvals, especially since it was a
> request for testing.
>
> Besides, this patch only fixes one file.  We have several images that
> need the same treatment.
Since Yves is interested perhaps he could do the "dirty job" of
applying repetitive fixes and testing different images? And submit a
patch then?
> Also, the problem with lnxboot.S spilled into
> the build system.  This will need to be cleaned up as well.
>
> --
> Regards,
> Pavel Roskin
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git

Re: Patch to compile boot.img properly on OSX

[Pavel Roskin]

On Thu, 2009-07-30 at 11:57 +0200, Vladimir 'phcoder' Serbinenko wrote:

> This wasn't specific for the patch. Neither was it a requirement, but
> more an idea. It's your work and you can choose to do it the way you
> like.

OK then.  The patches have been committed.

> Since Yves is interested perhaps he could do the "dirty job" of
> applying repetitive fixes and testing different images? And submit a
> patch then?

Fine with me.

-- 
Regards,
Pavel Roskin

Re: Patch to compile boot.img properly on OSX

[Pavel Roskin]

On Thu, 2009-08-13 at 02:24 -0400, Pavel Roskin wrote:

> > Since Yves is interested perhaps he could do the "dirty job" of
> > applying repetitive fixes and testing different images? And submit a
> > patch then?
> 
> Fine with me.

I have fixed the *.img files other than kernel.img, but there is still a
lot of APPLE_CC in other *.S files, so there is enough work for everyone
interested.

Fixings lnxboot.S wasn't exactly trivial.

By the way, it should be possible to remove -static from
TARGET_IMG_CFLAGS if some data labels in lnxboot.S are also marked
local.  That's a good thing since my Darwin cross-compiler fails
silently with -static trying to link kernel.exec.  But I'd like to
understand it better first.

-- 
Regards,
Pavel Roskin

Re: Patch to compile boot.img properly on OSX

[Yves Blusseau]

Le 14 août 09 à 23:55, Pavel Roskin a écrit :

> On Thu, 2009-08-13 at 02:24 -0400, Pavel Roskin wrote:
>
>>> Since Yves is interested perhaps he could do the "dirty job" of
>>> applying repetitive fixes and testing different images? And submit a
>>> patch then?
>>
>> Fine with me.
>
> I have fixed the *.img files other than kernel.img, but there is  
> still a
> lot of APPLE_CC in other *.S files, so there is enough work for  
> everyone
> interested.
>
> Fixings lnxboot.S wasn't exactly trivial.
>
> By the way, it should be possible to remove -static from
> TARGET_IMG_CFLAGS if some data labels in lnxboot.S are also marked
> local.  That's a good thing since my Darwin cross-compiler fails
> silently with -static trying to link kernel.exec.  But I'd like to
> understand it better first.

I will try to remove apple specific declarations with the LOCAL macro  
in others files like:

./commands/i386/pc/drivemap_int13h.S
./kern/i386/pc/startup.S
./kern/i386/qemu/startup.S
./loader/i386/linux_trampoline.S
./loader/i386/xnu_helper.S
./mmap/i386/pc/mmap_helper.S

and send the patch on the ML for testing.

Regards,
Yves