[PATCH] c/r: Fix no-dot-config-targets pattern in linux/Makefile

[PATCH] c/r: Fix no-dot-config-targets pattern in linux/Makefile

[John Dykstra]

Oren, I'm not sure who you're accepting patches from, but...

--
Kernel builds that specify targets in the checkpoint/ directory will
fail or be incorrect because the autoconfig files were not included.
One way to reproduce the problem is:

	make checkpoint/sys.s

The problem is that this pattern in linux/Makefile matches files in the
checkpoint/ directory:

no-dot-config-targets := clean mrproper distclean \
                         cscope TAGS tags help %docs check% \
                         include/linux/version.h headers_% \
                         kernelrelease kernelversion

Make the pattern more exact, per the current set of linux build targets.

Signed-off-by: John Dykstra <john.dykstra1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index cf631d7..17445a6 100644
--- a/Makefile
+++ b/Makefile
@@ -400,7 +400,7 @@ endif
 # of make so .config is not included in this case either (for *config).
 
 no-dot-config-targets := clean mrproper distclean \
-			 cscope TAGS tags help %docs check% \
+			 cscope TAGS tags help %docs checkstack \
 			 include/linux/version.h headers_% \
 			 kernelrelease kernelversion
 
-- 
1.5.4.3

Re: [PATCH] c/r: Fix no-dot-config-targets pattern in linux/Makefile

[Oren Laadan]

John Dykstra wrote:
> Oren, I'm not sure who you're accepting patches from, but...

I accept any good patch  :)
(pushed to ckpt-v17-dev)

Oren.


> 
> --
> Kernel builds that specify targets in the checkpoint/ directory will
> fail or be incorrect because the autoconfig files were not included.
> One way to reproduce the problem is:
> 
> 	make checkpoint/sys.s
> 
> The problem is that this pattern in linux/Makefile matches files in the
> checkpoint/ directory:
> 
> no-dot-config-targets := clean mrproper distclean \
>                          cscope TAGS tags help %docs check% \
>                          include/linux/version.h headers_% \
>                          kernelrelease kernelversion
> 
> Make the pattern more exact, per the current set of linux build targets.
> 
> Signed-off-by: John Dykstra <john.dykstra1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index cf631d7..17445a6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -400,7 +400,7 @@ endif
>  # of make so .config is not included in this case either (for *config).
>  
>  no-dot-config-targets := clean mrproper distclean \
> -			 cscope TAGS tags help %docs check% \
> +			 cscope TAGS tags help %docs checkstack \
>  			 include/linux/version.h headers_% \
>  			 kernelrelease kernelversion
>  

Re: [PATCH] c/r: Fix no-dot-config-targets pattern in linux/Makefile

[John Dykstra]

On Tue, 2009-08-04 at 04:20 -0400, Oren Laadan wrote:
> 
> I accept any good patch  :)

What's a good way to package the patch on the list so that you'll notice
it, but it will still be clear that it's not intended for mainline?

  --  John

Re: [PATCH] c/r: Fix no-dot-config-targets pattern in linux/Makefile

[Oren Laadan]

John Dykstra wrote:
> On Tue, 2009-08-04 at 04:20 -0400, Oren Laadan wrote:
>> I accept any good patch  :)
> 
> What's a good way to package the patch on the list so that you'll notice
> it, but it will still be clear that it's not intended for mainline?

Since c/r is not (yet) in mainline, 'c/r' prefix and cc'ing me should
make it visible enough.

Thanks,

Oren.