All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Lucas Meneghel Rodrigues <mrodrigu@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH KVM-AUTOTEST 2/2] Convert images to JPEG using PIL instead of an external program
Date: Wed, 12 Aug 2009 12:01:48 -0300	[thread overview]
Message-ID: <1250089308.2921.55.camel@localhost.localdomain> (raw)
In-Reply-To: <4A82C4C0.1040605@redhat.com>

On Wed, 2009-08-12 at 16:33 +0300, Avi Kivity wrote:
> On 08/12/2009 04:26 PM, Lucas Meneghel Rodrigues wrote:
> > But I prefer to follow the project policy when possible. The reason why
> > I accepted the original code that Michael wrote to perform the
> > conversion was graceful degradation of functionality (if you don't have
> > ImageMagick installed, the test will not abort).
> >    
> 
> Well, policy is policy.  See the attached (untested).

Ok Avi, I've spotted other places where we are also making unneeded
calls to rm and mogrify, so I changed them, combined the patches,
changed the exception trap only to catch the exceptions we are waiting
for, and send the patch to the mailing list. Please let me know what you
think.

Lucas


  reply	other threads:[~2009-08-12 15:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-12  9:34 [PATCH KVM-AUTOTEST 0/2] Remove some external command callouts Avi Kivity
2009-08-12  9:34 ` [PATCH KVM-AUTOTEST 1/2] Replace subprocess 'rm *.ppm' by equivalent Python code Avi Kivity
2009-08-12  9:34 ` [PATCH KVM-AUTOTEST 2/2] Convert images to JPEG using PIL instead of an external program Avi Kivity
2009-08-12 12:44   ` Lucas Meneghel Rodrigues
2009-08-12 13:00     ` Avi Kivity
2009-08-12 13:26       ` Lucas Meneghel Rodrigues
2009-08-12 13:33         ` Avi Kivity
2009-08-12 15:01           ` Lucas Meneghel Rodrigues [this message]
2009-08-12 15:05             ` Avi Kivity
     [not found] <1587932675.1809681250071942865.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-08-12 10:13 ` Michael Goldish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250089308.2921.55.camel@localhost.localdomain \
    --to=lmr@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mrodrigu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.