All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: [PATCH 2/7] KVM: x86: Add missing locking to arch specific vcpu ioctls
Date: Thu, 13 May 2010 11:17:34 +0000	[thread overview]
Message-ID: <1273749459-622-3-git-send-email-avi@redhat.com> (raw)

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 arch/x86/kvm/x86.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 4b1433f..f54ec24 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1844,6 +1844,7 @@ static int kvm_vcpu_ioctl_get_cpuid2(struct kvm_vcpu *vcpu,
 {
 	int r;
 
+	vcpu_load(vcpu);
 	r = -E2BIG;
 	if (cpuid->nent < vcpu->arch.cpuid_nent)
 		goto out;
@@ -1855,6 +1856,7 @@ static int kvm_vcpu_ioctl_get_cpuid2(struct kvm_vcpu *vcpu,
 
 out:
 	cpuid->nent = vcpu->arch.cpuid_nent;
+	vcpu_put(vcpu);
 	return r;
 }
 
@@ -2145,6 +2147,7 @@ static int kvm_vcpu_ioctl_x86_setup_mce(struct kvm_vcpu *vcpu,
 	int r;
 	unsigned bank_num = mcg_cap & 0xff, bank;
 
+	vcpu_load(vcpu);
 	r = -EINVAL;
 	if (!bank_num || bank_num >= KVM_MAX_MCE_BANKS)
 		goto out;
@@ -2159,6 +2162,7 @@ static int kvm_vcpu_ioctl_x86_setup_mce(struct kvm_vcpu *vcpu,
 	for (bank = 0; bank < bank_num; bank++)
 		vcpu->arch.mce_banks[bank*4] = ~(u64)0;
 out:
+	vcpu_put(vcpu);
 	return r;
 }
 
@@ -2467,7 +2471,9 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
 		r = -EFAULT;
 		if (copy_from_user(&mce, argp, sizeof mce))
 			goto out;
+		vcpu_load(vcpu);
 		r = kvm_vcpu_ioctl_x86_set_mce(vcpu, &mce);
+		vcpu_put(vcpu);
 		break;
 	}
 	case KVM_GET_VCPU_EVENTS: {
-- 
1.7.0.4


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti
	<mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org
Subject: [PATCH 2/7] KVM: x86: Add missing locking to arch specific vcpu ioctls
Date: Thu, 13 May 2010 11:17:34 +0000	[thread overview]
Message-ID: <1273749459-622-3-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1273749459-622-1-git-send-email-avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 arch/x86/kvm/x86.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 4b1433f..f54ec24 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1844,6 +1844,7 @@ static int kvm_vcpu_ioctl_get_cpuid2(struct kvm_vcpu *vcpu,
 {
 	int r;
 
+	vcpu_load(vcpu);
 	r = -E2BIG;
 	if (cpuid->nent < vcpu->arch.cpuid_nent)
 		goto out;
@@ -1855,6 +1856,7 @@ static int kvm_vcpu_ioctl_get_cpuid2(struct kvm_vcpu *vcpu,
 
 out:
 	cpuid->nent = vcpu->arch.cpuid_nent;
+	vcpu_put(vcpu);
 	return r;
 }
 
@@ -2145,6 +2147,7 @@ static int kvm_vcpu_ioctl_x86_setup_mce(struct kvm_vcpu *vcpu,
 	int r;
 	unsigned bank_num = mcg_cap & 0xff, bank;
 
+	vcpu_load(vcpu);
 	r = -EINVAL;
 	if (!bank_num || bank_num >= KVM_MAX_MCE_BANKS)
 		goto out;
@@ -2159,6 +2162,7 @@ static int kvm_vcpu_ioctl_x86_setup_mce(struct kvm_vcpu *vcpu,
 	for (bank = 0; bank < bank_num; bank++)
 		vcpu->arch.mce_banks[bank*4] = ~(u64)0;
 out:
+	vcpu_put(vcpu);
 	return r;
 }
 
@@ -2467,7 +2471,9 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
 		r = -EFAULT;
 		if (copy_from_user(&mce, argp, sizeof mce))
 			goto out;
+		vcpu_load(vcpu);
 		r = kvm_vcpu_ioctl_x86_set_mce(vcpu, &mce);
+		vcpu_put(vcpu);
 		break;
 	}
 	case KVM_GET_VCPU_EVENTS: {
-- 
1.7.0.4


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Marcelo Tosatti
	<mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org
Subject: [PATCH 2/7] KVM: x86: Add missing locking to arch specific vcpu ioctls
Date: Thu, 13 May 2010 14:17:34 +0300	[thread overview]
Message-ID: <1273749459-622-3-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1273749459-622-1-git-send-email-avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Signed-off-by: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 arch/x86/kvm/x86.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 4b1433f..f54ec24 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1844,6 +1844,7 @@ static int kvm_vcpu_ioctl_get_cpuid2(struct kvm_vcpu *vcpu,
 {
 	int r;
 
+	vcpu_load(vcpu);
 	r = -E2BIG;
 	if (cpuid->nent < vcpu->arch.cpuid_nent)
 		goto out;
@@ -1855,6 +1856,7 @@ static int kvm_vcpu_ioctl_get_cpuid2(struct kvm_vcpu *vcpu,
 
 out:
 	cpuid->nent = vcpu->arch.cpuid_nent;
+	vcpu_put(vcpu);
 	return r;
 }
 
@@ -2145,6 +2147,7 @@ static int kvm_vcpu_ioctl_x86_setup_mce(struct kvm_vcpu *vcpu,
 	int r;
 	unsigned bank_num = mcg_cap & 0xff, bank;
 
+	vcpu_load(vcpu);
 	r = -EINVAL;
 	if (!bank_num || bank_num >= KVM_MAX_MCE_BANKS)
 		goto out;
@@ -2159,6 +2162,7 @@ static int kvm_vcpu_ioctl_x86_setup_mce(struct kvm_vcpu *vcpu,
 	for (bank = 0; bank < bank_num; bank++)
 		vcpu->arch.mce_banks[bank*4] = ~(u64)0;
 out:
+	vcpu_put(vcpu);
 	return r;
 }
 
@@ -2467,7 +2471,9 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
 		r = -EFAULT;
 		if (copy_from_user(&mce, argp, sizeof mce))
 			goto out;
+		vcpu_load(vcpu);
 		r = kvm_vcpu_ioctl_x86_set_mce(vcpu, &mce);
+		vcpu_put(vcpu);
 		break;
 	}
 	case KVM_GET_VCPU_EVENTS: {
-- 
1.7.0.4

             reply	other threads:[~2010-05-13 11:17 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13 11:17 Avi Kivity [this message]
2010-05-13 11:17 ` [PATCH 2/7] KVM: x86: Add missing locking to arch specific vcpu ioctls Avi Kivity
2010-05-13 11:17 ` Avi Kivity
  -- strict thread matches above, loose matches on Subject: below --
2010-05-13 11:17 [PATCH 7/7] KVM: Consolidate arch specific vcpu ioctl locking Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 [PATCH 6/7] KVM: PPC: Centralize locking of arch specific vcpu ioctls Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 [PATCH 5/7] KVM: s390: Centrally lock " Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 [PATCH 4/7] KVM: x86: Lock arch specific vcpu ioctls centrally Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 [PATCH 1/7] KVM: PPC: Add missing vcpu_load()/vcpu_put() in vcpu ioctls Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 [PATCH 0/7] Consolidate vcpu ioctl locking Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` [PATCH 3/7] KVM: move vcpu locking to dispatcher for generic vcpu ioctls Avi Kivity
2010-05-13 11:17   ` Avi Kivity
2010-05-13 11:17   ` Avi Kivity
2010-05-15  0:03   ` Marcelo Tosatti
2010-05-16 11:22   ` [PATCH 3/7] KVM: move vcpu locking to dispatcher for generic Avi Kivity
2010-05-16 11:22     ` [PATCH 3/7] KVM: move vcpu locking to dispatcher for generic vcpu ioctls Avi Kivity
2010-05-16 11:22     ` [PATCH 3/7] KVM: move vcpu locking to dispatcher for generic Avi Kivity
2010-05-13 11:57 ` [PATCH 0/7] Consolidate vcpu ioctl locking Alexander Graf
2010-05-13 11:57   ` Alexander Graf
2010-05-13 11:57   ` Alexander Graf
2010-05-13 12:01 ` Avi Kivity
2010-05-13 12:01   ` Avi Kivity
2010-05-13 12:01   ` Avi Kivity
2010-05-13 12:03 ` Avi Kivity
2010-05-13 12:03   ` Avi Kivity
2010-05-13 12:03   ` Avi Kivity
2010-05-13 12:03 ` Avi Kivity
2010-05-13 12:03   ` Avi Kivity
2010-05-13 12:03   ` Avi Kivity
2010-05-13 12:18 ` Alexander Graf
2010-05-13 12:18   ` Alexander Graf
2010-05-13 12:18   ` Alexander Graf
2010-05-13 12:29 ` Avi Kivity
2010-05-13 12:29   ` Avi Kivity
2010-05-13 12:29   ` Avi Kivity
2010-05-13 19:49 ` Alexander Graf
2010-05-13 19:49   ` Alexander Graf
2010-05-13 19:49   ` Alexander Graf
     [not found]   ` <B2627FBE-BB5E-45E2-8E67-E5859B6380A5-l3A5Bk7waGM@public.gmane.org>
2010-05-15  6:16     ` Avi Kivity
     [not found]       ` <4BEE3C56.2070007-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-05-15  6:21         ` Alexander Graf
     [not found]           ` <F7406BC6-90A8-43B9-A57F-6B9350B6D356-l3A5Bk7waGM@public.gmane.org>
2010-05-15  7:59             ` Avi Kivity
     [not found]               ` <4BEE544B.50405-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-05-15  8:26                 ` Alexander Graf
2010-05-15 17:30 ` Avi Kivity
2010-05-15 17:30   ` Avi Kivity
2010-05-15 17:30   ` Avi Kivity
2010-05-16  1:00 ` Alexander Graf
2010-05-16  1:00   ` Alexander Graf
2010-05-16  1:00   ` Alexander Graf
2010-05-16  8:23 ` Avi Kivity
2010-05-16  8:23   ` Avi Kivity
2010-05-16  8:23   ` Avi Kivity
2010-05-16  9:01 ` Alexander Graf
2010-05-16  9:01   ` Alexander Graf
2010-05-16  9:01   ` Alexander Graf
2010-05-16  9:09 ` Avi Kivity
2010-05-16  9:09   ` Avi Kivity
2010-05-16  9:09   ` Avi Kivity
2010-05-16  9:35 ` Alexander Graf
2010-05-16  9:35   ` Alexander Graf
2010-05-16  9:35   ` Alexander Graf
2010-05-16  9:47 ` Avi Kivity
2010-05-16  9:47   ` Avi Kivity
2010-05-16  9:47   ` Avi Kivity
2010-05-16 10:19 ` Alexander Graf
2010-05-16 10:19   ` Alexander Graf
2010-05-16 10:19   ` Alexander Graf
2010-05-21  7:35 ` Carsten Otte
2010-05-21  7:35   ` Carsten Otte
2010-05-21  7:35   ` Carsten Otte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273749459-622-3-git-send-email-avi@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.