From: Carsten Otte <carsteno@de.ibm.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH 0/7] Consolidate vcpu ioctl locking
Date: Fri, 21 May 2010 07:35:03 +0000 [thread overview]
Message-ID: <4BF637A7.3010203@de.ibm.com> (raw)
In-Reply-To: <1273749459-622-1-git-send-email-avi@redhat.com>
On 15.05.2010 10:26, Alexander Graf wrote:
> On S390, I'm also still sceptical if the implementation we have really works. A device injects an S390_INTERRUPT with its address and on the next vcpu_run, an according interrupt is issued. But what happens if two devices trigger an S390_INTERRUPT before the vcpu_run? We'd have lost an interrupt by then...
We're safe on that: the interrupt info field in both struct kvm (for
floating interrupts) and struct vcpu (for cpu local interrupts) have
their own locking and can queue up interrupts.
cheers,
Carsten
WARNING: multiple messages have this Message-ID (diff)
From: Carsten Otte <carsteno@de.ibm.com>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Marcelo Tosatti
<mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 0/7] Consolidate vcpu ioctl locking
Date: Fri, 21 May 2010 07:35:03 +0000 [thread overview]
Message-ID: <4BF637A7.3010203@de.ibm.com> (raw)
In-Reply-To: <20442124-2400-4273-A256-6846017D3141-l3A5Bk7waGM@public.gmane.org>
On 15.05.2010 10:26, Alexander Graf wrote:
> On S390, I'm also still sceptical if the implementation we have really works. A device injects an S390_INTERRUPT with its address and on the next vcpu_run, an according interrupt is issued. But what happens if two devices trigger an S390_INTERRUPT before the vcpu_run? We'd have lost an interrupt by then...
We're safe on that: the interrupt info field in both struct kvm (for
floating interrupts) and struct vcpu (for cpu local interrupts) have
their own locking and can queue up interrupts.
cheers,
Carsten
WARNING: multiple messages have this Message-ID (diff)
From: Carsten Otte <carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Marcelo Tosatti
<mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 0/7] Consolidate vcpu ioctl locking
Date: Fri, 21 May 2010 09:35:03 +0200 [thread overview]
Message-ID: <4BF637A7.3010203@de.ibm.com> (raw)
In-Reply-To: <20442124-2400-4273-A256-6846017D3141-l3A5Bk7waGM@public.gmane.org>
On 15.05.2010 10:26, Alexander Graf wrote:
> On S390, I'm also still sceptical if the implementation we have really works. A device injects an S390_INTERRUPT with its address and on the next vcpu_run, an according interrupt is issued. But what happens if two devices trigger an S390_INTERRUPT before the vcpu_run? We'd have lost an interrupt by then...
We're safe on that: the interrupt info field in both struct kvm (for
floating interrupts) and struct vcpu (for cpu local interrupts) have
their own locking and can queue up interrupts.
cheers,
Carsten
next prev parent reply other threads:[~2010-05-21 7:35 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 11:17 [PATCH 0/7] Consolidate vcpu ioctl locking Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` [PATCH 3/7] KVM: move vcpu locking to dispatcher for generic vcpu ioctls Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-15 0:03 ` Marcelo Tosatti
2010-05-16 11:22 ` [PATCH 3/7] KVM: move vcpu locking to dispatcher for generic Avi Kivity
2010-05-16 11:22 ` [PATCH 3/7] KVM: move vcpu locking to dispatcher for generic vcpu ioctls Avi Kivity
2010-05-16 11:22 ` [PATCH 3/7] KVM: move vcpu locking to dispatcher for generic Avi Kivity
2010-05-13 11:57 ` [PATCH 0/7] Consolidate vcpu ioctl locking Alexander Graf
2010-05-13 11:57 ` Alexander Graf
2010-05-13 11:57 ` Alexander Graf
2010-05-13 12:01 ` Avi Kivity
2010-05-13 12:01 ` Avi Kivity
2010-05-13 12:01 ` Avi Kivity
2010-05-13 12:03 ` Avi Kivity
2010-05-13 12:03 ` Avi Kivity
2010-05-13 12:03 ` Avi Kivity
2010-05-13 12:03 ` Avi Kivity
2010-05-13 12:03 ` Avi Kivity
2010-05-13 12:03 ` Avi Kivity
2010-05-13 12:18 ` Alexander Graf
2010-05-13 12:18 ` Alexander Graf
2010-05-13 12:18 ` Alexander Graf
2010-05-13 12:29 ` Avi Kivity
2010-05-13 12:29 ` Avi Kivity
2010-05-13 12:29 ` Avi Kivity
2010-05-13 19:49 ` Alexander Graf
2010-05-13 19:49 ` Alexander Graf
2010-05-13 19:49 ` Alexander Graf
[not found] ` <B2627FBE-BB5E-45E2-8E67-E5859B6380A5-l3A5Bk7waGM@public.gmane.org>
2010-05-15 6:16 ` Avi Kivity
[not found] ` <4BEE3C56.2070007-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-05-15 6:21 ` Alexander Graf
[not found] ` <F7406BC6-90A8-43B9-A57F-6B9350B6D356-l3A5Bk7waGM@public.gmane.org>
2010-05-15 7:59 ` Avi Kivity
[not found] ` <4BEE544B.50405-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-05-15 8:26 ` Alexander Graf
2010-05-15 17:30 ` Avi Kivity
2010-05-15 17:30 ` Avi Kivity
2010-05-15 17:30 ` Avi Kivity
2010-05-16 1:00 ` Alexander Graf
2010-05-16 1:00 ` Alexander Graf
2010-05-16 1:00 ` Alexander Graf
2010-05-16 8:23 ` Avi Kivity
2010-05-16 8:23 ` Avi Kivity
2010-05-16 8:23 ` Avi Kivity
2010-05-16 9:01 ` Alexander Graf
2010-05-16 9:01 ` Alexander Graf
2010-05-16 9:01 ` Alexander Graf
2010-05-16 9:09 ` Avi Kivity
2010-05-16 9:09 ` Avi Kivity
2010-05-16 9:09 ` Avi Kivity
2010-05-16 9:35 ` Alexander Graf
2010-05-16 9:35 ` Alexander Graf
2010-05-16 9:35 ` Alexander Graf
2010-05-16 9:47 ` Avi Kivity
2010-05-16 9:47 ` Avi Kivity
2010-05-16 9:47 ` Avi Kivity
2010-05-16 10:19 ` Alexander Graf
2010-05-16 10:19 ` Alexander Graf
2010-05-16 10:19 ` Alexander Graf
2010-05-21 7:35 ` Carsten Otte [this message]
2010-05-21 7:35 ` Carsten Otte
2010-05-21 7:35 ` Carsten Otte
-- strict thread matches above, loose matches on Subject: below --
2010-05-13 11:17 [PATCH 1/7] KVM: PPC: Add missing vcpu_load()/vcpu_put() in vcpu ioctls Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 [PATCH 2/7] KVM: x86: Add missing locking to arch specific " Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 [PATCH 4/7] KVM: x86: Lock arch specific vcpu ioctls centrally Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 [PATCH 5/7] KVM: s390: Centrally lock arch specific vcpu ioctls Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 [PATCH 6/7] KVM: PPC: Centralize locking of " Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 [PATCH 7/7] KVM: Consolidate arch specific vcpu ioctl locking Avi Kivity
2010-05-13 11:17 ` Avi Kivity
2010-05-13 11:17 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF637A7.3010203@de.ibm.com \
--to=carsteno@de.ibm.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.