From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Greg KH <gregkh@suse.de>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Andi Kleen <ak@linux.intel.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org, haicheng.li@linux.intel.com,
shaohui.zheng@linux.intel.com
Subject: Re: [RFC, 6/7] NUMA hotplug emulator
Date: Thu, 13 May 2010 11:49:38 -0700 [thread overview]
Message-ID: <1273776578.13285.7820.camel@nimitz> (raw)
In-Reply-To: <20100513181539.GA26597@suse.de>
On Thu, 2010-05-13 at 11:15 -0700, Greg KH wrote:
> > echo "physical_address=0x40000000 numa_node=3" > memory/probe
> >
> > I'd *GREATLY* prefer that over this new syntax. The existing mechanism
> > is obtuse enough, and the ',3' makes it more so.
> >
> > We should have the code around to parse arguments like that, too, since
> > we use it for the boot command-line.
>
> If you are going to be doing something like this, please use configfs,
> that is what it is designed for, not sysfs.
That's probably a really good point, especially since configfs didn't
even exist when we made this 'probe' file thingy. It never was a great
fit for sysfs anyway.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Greg KH <gregkh@suse.de>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Andi Kleen <ak@linux.intel.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org, haicheng.li@linux.intel.com,
shaohui.zheng@linux.intel.com
Subject: Re: [RFC, 6/7] NUMA hotplug emulator
Date: Thu, 13 May 2010 11:49:38 -0700 [thread overview]
Message-ID: <1273776578.13285.7820.camel@nimitz> (raw)
In-Reply-To: <20100513181539.GA26597@suse.de>
On Thu, 2010-05-13 at 11:15 -0700, Greg KH wrote:
> > echo "physical_address=0x40000000 numa_node=3" > memory/probe
> >
> > I'd *GREATLY* prefer that over this new syntax. The existing mechanism
> > is obtuse enough, and the ',3' makes it more so.
> >
> > We should have the code around to parse arguments like that, too, since
> > we use it for the boot command-line.
>
> If you are going to be doing something like this, please use configfs,
> that is what it is designed for, not sysfs.
That's probably a really good point, especially since configfs didn't
even exist when we made this 'probe' file thingy. It never was a great
fit for sysfs anyway.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-13 18:49 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 12:00 [RFC, 6/7] NUMA hotplug emulator Shaohui Zheng
2010-05-13 12:00 ` Shaohui Zheng
2010-05-13 16:56 ` Greg KH
2010-05-13 16:56 ` Greg KH
2010-05-13 18:02 ` Dave Hansen
2010-05-13 18:02 ` Dave Hansen
2010-05-13 18:15 ` Greg KH
2010-05-13 18:15 ` Greg KH
2010-05-13 18:49 ` Dave Hansen [this message]
2010-05-13 18:49 ` Dave Hansen
2010-05-13 18:58 ` Greg KH
2010-05-13 18:58 ` Greg KH
2010-05-13 19:16 ` Dave Hansen
2010-05-13 19:16 ` Dave Hansen
2010-05-13 19:21 ` Greg KH
2010-05-13 19:21 ` Greg KH
2010-05-18 5:41 ` Shaohui Zheng
2010-05-18 5:41 ` Shaohui Zheng
2010-05-18 7:27 ` Dave Hansen
2010-05-18 7:27 ` Dave Hansen
2010-05-18 7:56 ` Shaohui Zheng
2010-05-18 7:56 ` Shaohui Zheng
2010-05-18 8:55 ` Andi Kleen
2010-05-18 8:55 ` Andi Kleen
2010-05-18 15:46 ` Dave Hansen
2010-05-18 15:46 ` Dave Hansen
2010-05-18 7:44 ` Nicholas A. Bellinger
2010-05-18 7:44 ` Nicholas A. Bellinger
2010-05-18 7:44 ` Paul Mundt
2010-05-18 7:44 ` Paul Mundt
2010-05-18 8:08 ` Shaohui Zheng
2010-05-18 8:08 ` Shaohui Zheng
2010-05-14 1:49 ` Shaohui Zheng
2010-05-14 1:49 ` Shaohui Zheng
2010-05-14 2:05 ` Wu Fengguang
2010-05-14 2:05 ` Wu Fengguang
2010-05-14 2:08 ` Shaohui Zheng
2010-05-14 2:08 ` Shaohui Zheng
2010-05-21 10:11 ` Ankita Garg
2010-05-21 10:11 ` Ankita Garg
2010-05-24 1:26 ` Shaohui Zheng
2010-05-24 1:26 ` Shaohui Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273776578.13285.7820.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=gregkh@suse.de \
--cc=haicheng.li@linux.intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=shaohui.zheng@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.