Re: [RFC, 6/7] NUMA hotplug emulator

[Shaohui Zheng <shaohui.zheng@intel.com>]

On Fri, May 14, 2010 at 10:05:26AM +0800, Wu Fengguang wrote:
> On Fri, May 14, 2010 at 09:49:02AM +0800, Zheng, Shaohui wrote:
> > On Thu, May 13, 2010 at 09:56:03AM -0700, Greg KH wrote:
> > > On Thu, May 13, 2010 at 08:00:16PM +0800, Shaohui Zheng wrote:
> > > > hotplug emulator:extend memory probe interface to support NUMA
> > > > 
> > > > Extend memory probe interface to support an extra paramter nid,
> > > > the reserved memory can be added into this node if node exists.
> > > > 
> > > > Add a memory section(128M) to node 3(boots with mem=1024m)
> > > > 
> > > > 	echo 0x40000000,3 > memory/probe
> > > > 
> > > > And more we make it friendly, it is possible to add memory to do
> > > > 
> > > > 	echo 3g > memory/probe
> > > > 	echo 1024m,3 > memory/probe
> > > > 
> > > > It maintains backwards compatibility.
> > > 
> > > Again, please document this.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > okay
> 
> Shaohui, it's useless to document a wrong interface.
> Better to fix the interface _first_, then document becomes meaningful.
Fenggunag,
	greg reminds me to add the docment into Documentation/ABI/, We miss it in
the RFC. Currently, the interface format is not finalized, when we decide the
final interface, the last step is documenting it in.
> 
> Thanks,
> Fengguang

-- 
Thanks & Regards,
Shaohui