From: Andi Kleen <ak@linux.intel.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Shaohui Zheng <shaohui.zheng@intel.com>, Greg KH <gregkh@suse.de>,
akpm@linux-foundation.org, linux-mm@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org, haicheng.li@linux.intel.com,
shaohui.zheng@linux.intel.com
Subject: Re: [RFC, 6/7] NUMA hotplug emulator
Date: Tue, 18 May 2010 10:55:15 +0200 [thread overview]
Message-ID: <4BF255F3.9040002@linux.intel.com> (raw)
In-Reply-To: <1274167625.17463.17.camel@nimitz>
>
> Maybe configfs isn't the way to go. I just think extending the 'probe'
> file is a bad idea, especially in the way your patch did it. I'm open
> to other alternatives. Since this is only for testing, perhaps debugfs
> applies better. What other alternatives have you explored? How about a
> Systemtap set to do it? :)
First this is a debugging interface. It doesn't need to have the
most pretty interface in the world, because it will be only used for
QA by a few people.
Requiring setting parameters in two different file systems doesn't
sound that appealing to me.
systemtap for configuration also doesn't seem right.
I liked Dave's earlier proposal to do a command line parameter like interface
for "probe". Perhaps that can be done. It shouldn't need a lot of code.
In fact there are already two different parser libraries for this:
lib/parser.c and lib/params.c. One could chose the one that one likes
better :-)
Anything that needs a lot of code is a bad idea for this I think.
A simple parser using one of the existing libraries should be simple
enough though.
Again it's just a QA interface, not the next generation of POSIX.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@linux.intel.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Shaohui Zheng <shaohui.zheng@intel.com>, Greg KH <gregkh@suse.de>,
akpm@linux-foundation.org, linux-mm@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org, haicheng.li@linux.intel.com,
shaohui.zheng@linux.intel.com
Subject: Re: [RFC, 6/7] NUMA hotplug emulator
Date: Tue, 18 May 2010 10:55:15 +0200 [thread overview]
Message-ID: <4BF255F3.9040002@linux.intel.com> (raw)
In-Reply-To: <1274167625.17463.17.camel@nimitz>
>
> Maybe configfs isn't the way to go. I just think extending the 'probe'
> file is a bad idea, especially in the way your patch did it. I'm open
> to other alternatives. Since this is only for testing, perhaps debugfs
> applies better. What other alternatives have you explored? How about a
> Systemtap set to do it? :)
First this is a debugging interface. It doesn't need to have the
most pretty interface in the world, because it will be only used for
QA by a few people.
Requiring setting parameters in two different file systems doesn't
sound that appealing to me.
systemtap for configuration also doesn't seem right.
I liked Dave's earlier proposal to do a command line parameter like interface
for "probe". Perhaps that can be done. It shouldn't need a lot of code.
In fact there are already two different parser libraries for this:
lib/parser.c and lib/params.c. One could chose the one that one likes
better :-)
Anything that needs a lot of code is a bad idea for this I think.
A simple parser using one of the existing libraries should be simple
enough though.
Again it's just a QA interface, not the next generation of POSIX.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-18 8:55 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 12:00 [RFC, 6/7] NUMA hotplug emulator Shaohui Zheng
2010-05-13 12:00 ` Shaohui Zheng
2010-05-13 16:56 ` Greg KH
2010-05-13 16:56 ` Greg KH
2010-05-13 18:02 ` Dave Hansen
2010-05-13 18:02 ` Dave Hansen
2010-05-13 18:15 ` Greg KH
2010-05-13 18:15 ` Greg KH
2010-05-13 18:49 ` Dave Hansen
2010-05-13 18:49 ` Dave Hansen
2010-05-13 18:58 ` Greg KH
2010-05-13 18:58 ` Greg KH
2010-05-13 19:16 ` Dave Hansen
2010-05-13 19:16 ` Dave Hansen
2010-05-13 19:21 ` Greg KH
2010-05-13 19:21 ` Greg KH
2010-05-18 5:41 ` Shaohui Zheng
2010-05-18 5:41 ` Shaohui Zheng
2010-05-18 7:27 ` Dave Hansen
2010-05-18 7:27 ` Dave Hansen
2010-05-18 7:56 ` Shaohui Zheng
2010-05-18 7:56 ` Shaohui Zheng
2010-05-18 8:55 ` Andi Kleen [this message]
2010-05-18 8:55 ` Andi Kleen
2010-05-18 15:46 ` Dave Hansen
2010-05-18 15:46 ` Dave Hansen
2010-05-18 7:44 ` Nicholas A. Bellinger
2010-05-18 7:44 ` Nicholas A. Bellinger
2010-05-18 7:44 ` Paul Mundt
2010-05-18 7:44 ` Paul Mundt
2010-05-18 8:08 ` Shaohui Zheng
2010-05-18 8:08 ` Shaohui Zheng
2010-05-14 1:49 ` Shaohui Zheng
2010-05-14 1:49 ` Shaohui Zheng
2010-05-14 2:05 ` Wu Fengguang
2010-05-14 2:05 ` Wu Fengguang
2010-05-14 2:08 ` Shaohui Zheng
2010-05-14 2:08 ` Shaohui Zheng
2010-05-21 10:11 ` Ankita Garg
2010-05-21 10:11 ` Ankita Garg
2010-05-24 1:26 ` Shaohui Zheng
2010-05-24 1:26 ` Shaohui Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF255F3.9040002@linux.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=gregkh@suse.de \
--cc=haicheng.li@linux.intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=shaohui.zheng@intel.com \
--cc=shaohui.zheng@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.