From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Michal Simek <monstr@monstr.eu>,
microblaze-uclinux@itee.uq.edu.au,
devicetree-discuss@lists.ozlabs.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 5/5] of/irq: merge of_irq_map_one()
Date: Fri, 11 Jun 2010 11:17:52 +1000 [thread overview]
Message-ID: <1276219072.1962.82.camel@pasglop> (raw)
In-Reply-To: <AANLkTinmDFBvAjcjrgf3RHuiXgNxVV20yLzBaqhE5lrk@mail.gmail.com>
On Thu, 2010-06-10 at 17:36 -0600, Grant Likely wrote:
>
> Okay. I had been trying to avoid #ifdefs in the common code, but
> you're probably right. I'll rework.
Not even ifdef's ... just move the quirk map there. You can always
#define the quirk variable to 0 on archs that have no quirks, to
make it compile away if you believe it represents bloat, but they
are simple well localized things so I doubt it matters.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH 5/5] of/irq: merge of_irq_map_one()
Date: Fri, 11 Jun 2010 11:17:52 +1000 [thread overview]
Message-ID: <1276219072.1962.82.camel@pasglop> (raw)
In-Reply-To: <AANLkTinmDFBvAjcjrgf3RHuiXgNxVV20yLzBaqhE5lrk-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, 2010-06-10 at 17:36 -0600, Grant Likely wrote:
>
> Okay. I had been trying to avoid #ifdefs in the common code, but
> you're probably right. I'll rework.
Not even ifdef's ... just move the quirk map there. You can always
#define the quirk variable to 0 on archs that have no quirks, to
make it compile away if you believe it represents bloat, but they
are simple well localized things so I doubt it matters.
Cheers,
Ben.
next prev parent reply other threads:[~2010-06-11 1:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 21:21 [PATCH 1/5] of/irq: Move irq_of_parse_and_map() to common code Grant Likely
2010-06-04 21:21 ` Grant Likely
2010-06-04 21:21 ` Grant Likely
2010-06-04 21:21 ` [PATCH 2/5] of/microblaze: strip out of_irq_workarounds code Grant Likely
2010-06-04 21:21 ` [PATCH 3/5] of/irq: merge of_irq_find_parent() Grant Likely
2010-06-04 21:21 ` Grant Likely
2010-06-10 6:38 ` Benjamin Herrenschmidt
2010-06-10 6:38 ` Benjamin Herrenschmidt
2010-06-21 21:11 ` Grant Likely
2010-06-21 21:11 ` Grant Likely
2010-06-04 21:21 ` [PATCH 4/5] of/irq: Merge of_irq_map_raw() Grant Likely
2010-06-04 21:21 ` Grant Likely
2010-06-10 6:38 ` Benjamin Herrenschmidt
2010-06-10 6:38 ` Benjamin Herrenschmidt
2010-06-04 21:21 ` [PATCH 5/5] of/irq: merge of_irq_map_one() Grant Likely
2010-06-04 21:21 ` Grant Likely
2010-06-10 6:40 ` Benjamin Herrenschmidt
2010-06-10 6:40 ` Benjamin Herrenschmidt
2010-06-10 23:36 ` Grant Likely
2010-06-10 23:36 ` Grant Likely
2010-06-11 1:17 ` Benjamin Herrenschmidt [this message]
2010-06-11 1:17 ` Benjamin Herrenschmidt
2010-06-11 1:30 ` PCIe bus seems work while 'dma' can't under linux jxnuxdy
2010-06-11 7:21 ` Benjamin Herrenschmidt
2010-06-11 7:21 ` Benjamin Herrenschmidt
2010-06-15 7:05 ` jxnuxdy
2010-06-15 7:05 ` jxnuxdy
2010-06-15 7:12 ` Benjamin Herrenschmidt
2010-06-15 7:12 ` Benjamin Herrenschmidt
2010-06-17 23:11 ` [PATCH 5/5] of/irq: merge of_irq_map_one() Grant Likely
2010-06-17 23:11 ` Grant Likely
2010-06-17 23:57 ` Benjamin Herrenschmidt
2010-06-17 23:57 ` Benjamin Herrenschmidt
2010-06-18 0:39 ` Grant Likely
2010-06-18 0:39 ` Grant Likely
2010-06-10 6:33 ` [PATCH 1/5] of/irq: Move irq_of_parse_and_map() to common code Benjamin Herrenschmidt
2010-06-10 6:33 ` Benjamin Herrenschmidt
2010-06-10 6:33 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276219072.1962.82.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.