From: john stultz <johnstul@us.ibm.com>
To: "Patrick J. LoPresti" <lopresti@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Proposal: Use hi-res clock for file timestamps
Date: Fri, 13 Aug 2010 12:09:39 -0700 [thread overview]
Message-ID: <1281726579.2810.10.camel@localhost.localdomain> (raw)
In-Reply-To: <AANLkTin-dksybH0ANypheovXXubwd+SRCpurdVRU7-Z=@mail.gmail.com>
On Fri, 2010-08-13 at 11:57 -0700, Patrick J. LoPresti wrote:
> On Fri, Aug 13, 2010 at 11:45 AM, john stultz <johnstul@us.ibm.com> wrote:
> > On those TSC broken systems that use the hpet or acpi_pm, a
> > getnstimeofday call can take 0.5-1.3us, so the penalty can be quite
> > severe.
>
> So you are saying my proposal is a bad idea forever? (But then why
> even bother having nanosecond resolution on ext4?)
>
> Or that it is a bad idea for now?
I'm not judging the idea as good/bad, just providing information for
context.
> Or that it needs to be refined? Maybe use hi-res precision on systems
> where it is known to be fast?
>
> > And even with the TSC, expect some performance impact, as
> > reading hardware and doing the multiply is more costly then just
> > fetching a value from memory.
>
> Relative to file system operations? Seriously? What performance hit
> would you expect on real-world applications?
> Something like 0.1% (10 nsec / 10 usec) worst case?
If you can show this does not affect performance in benchmarks, etc, I'm
sure it will be easier to push the patch. As outside of performance, I
don't think there's much of an issue with the change.
So other then "show some numbers", my only thought that might make the
patch more attractive is that rather than a global change, or a static
CONFIG_ option, would it maybe make more sense as a mount option?
thanks
-john
WARNING: multiple messages have this Message-ID (diff)
From: john stultz <johnstul-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: "Patrick J. LoPresti" <lopresti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Proposal: Use hi-res clock for file timestamps
Date: Fri, 13 Aug 2010 12:09:39 -0700 [thread overview]
Message-ID: <1281726579.2810.10.camel@localhost.localdomain> (raw)
In-Reply-To: <AANLkTin-dksybH0ANypheovXXubwd+SRCpurdVRU7-Z=@mail.gmail.com>
On Fri, 2010-08-13 at 11:57 -0700, Patrick J. LoPresti wrote:
> On Fri, Aug 13, 2010 at 11:45 AM, john stultz <johnstul-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> wrote:
> > On those TSC broken systems that use the hpet or acpi_pm, a
> > getnstimeofday call can take 0.5-1.3us, so the penalty can be quite
> > severe.
>
> So you are saying my proposal is a bad idea forever? (But then why
> even bother having nanosecond resolution on ext4?)
>
> Or that it is a bad idea for now?
I'm not judging the idea as good/bad, just providing information for
context.
> Or that it needs to be refined? Maybe use hi-res precision on systems
> where it is known to be fast?
>
> > And even with the TSC, expect some performance impact, as
> > reading hardware and doing the multiply is more costly then just
> > fetching a value from memory.
>
> Relative to file system operations? Seriously? What performance hit
> would you expect on real-world applications?
> Something like 0.1% (10 nsec / 10 usec) worst case?
If you can show this does not affect performance in benchmarks, etc, I'm
sure it will be easier to push the patch. As outside of performance, I
don't think there's much of an issue with the change.
So other then "show some numbers", my only thought that might make the
patch more attractive is that rather than a global change, or a static
CONFIG_ option, would it maybe make more sense as a mount option?
thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-08-13 19:09 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 18:25 Proposal: Use hi-res clock for file timestamps Patrick J. LoPresti
2010-08-13 18:45 ` john stultz
2010-08-13 18:45 ` john stultz
2010-08-13 18:57 ` Patrick J. LoPresti
2010-08-13 19:09 ` john stultz [this message]
2010-08-13 19:09 ` john stultz
2010-08-13 20:53 ` Patrick J. LoPresti
2010-08-13 20:53 ` Patrick J. LoPresti
2010-08-14 16:45 ` Patrick J. LoPresti
2010-08-15 1:50 ` Bret Towe
2010-08-13 19:57 ` Jim Rees
2010-08-13 20:26 ` john stultz
2010-08-13 20:52 ` Jim Rees
2010-08-17 14:54 ` Andi Kleen
2010-08-17 14:54 ` Andi Kleen
2010-08-17 17:41 ` J. Bruce Fields
2010-08-17 17:41 ` J. Bruce Fields
2010-08-17 18:29 ` Andi Kleen
2010-08-17 18:29 ` Andi Kleen
2010-08-17 18:50 ` Patrick J. LoPresti
2010-08-17 18:50 ` Patrick J. LoPresti
2010-08-17 19:04 ` J. Bruce Fields
2010-08-17 19:18 ` Patrick J. LoPresti
2010-08-17 19:18 ` Patrick J. LoPresti
2010-08-17 19:39 ` Alan Cox
2010-08-17 19:39 ` Alan Cox
2010-08-17 19:29 ` J. Bruce Fields
2010-08-17 19:29 ` J. Bruce Fields
2010-08-17 19:52 ` Alan Cox
2010-08-17 19:52 ` Alan Cox
2010-08-18 5:53 ` Neil Brown
2010-08-18 5:53 ` Neil Brown
2010-08-18 14:46 ` Patrick J. LoPresti
2010-08-18 14:46 ` Patrick J. LoPresti
2010-08-18 17:32 ` J. Bruce Fields
2010-08-18 17:32 ` J. Bruce Fields
2010-08-18 18:15 ` Chuck Lever
2010-08-18 18:15 ` Chuck Lever
2010-08-18 23:41 ` Neil Brown
2010-08-18 23:41 ` Neil Brown
2010-08-19 0:52 ` Neil Brown
2010-08-19 0:52 ` Neil Brown
2010-08-19 2:08 ` J. Bruce Fields
2010-08-19 2:08 ` J. Bruce Fields
2010-08-19 2:44 ` Neil Brown
2010-08-19 2:44 ` Neil Brown
2010-08-19 22:46 ` J. Bruce Fields
2010-08-19 22:46 ` J. Bruce Fields
2010-08-18 23:47 ` Neil Brown
2010-08-18 23:47 ` Neil Brown
2010-08-18 17:50 ` Andi Kleen
2010-08-18 17:50 ` Andi Kleen
2010-08-18 18:54 ` J. Bruce Fields
2010-08-18 19:25 ` Andi Kleen
2010-08-18 19:30 ` J. Bruce Fields
2010-08-17 19:34 ` Patrick J. LoPresti
2010-08-17 19:34 ` Patrick J. LoPresti
2010-08-17 19:54 ` Alan Cox
2010-08-17 19:43 ` Patrick J. LoPresti
2010-08-17 19:43 ` Patrick J. LoPresti
2010-08-17 19:45 ` J. Bruce Fields
2010-08-17 19:45 ` J. Bruce Fields
2010-08-18 18:12 ` J. Bruce Fields
2010-08-18 18:12 ` J. Bruce Fields
2010-08-19 1:41 ` john stultz
2010-08-19 1:41 ` john stultz
2010-08-19 2:31 ` J. Bruce Fields
2010-08-19 2:31 ` J. Bruce Fields
2010-08-19 3:17 ` john stultz
2010-08-19 3:17 ` john stultz
2010-08-19 22:53 ` J. Bruce Fields
2010-08-18 18:20 ` David Woodhouse
2010-08-18 18:20 ` David Woodhouse
2010-08-18 18:32 ` Patrick J. LoPresti
2010-08-18 18:32 ` Patrick J. LoPresti
2010-08-18 18:53 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281726579.2810.10.camel@localhost.localdomain \
--to=johnstul@us.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lopresti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.