From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, Rupjyoti Sarmah <rsarmah@amcc.com>,
rsarmah@apm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ppc44x:PHY fixup for USB on canyonlands board
Date: Thu, 11 Nov 2010 01:38:51 +1100 [thread overview]
Message-ID: <1289399931.2147.1392.camel@pasglop> (raw)
In-Reply-To: <20101110141914.GC26193@zod.rchland.ibm.com>
On Wed, 2010-11-10 at 09:19 -0500, Josh Boyer wrote:
> With this being an arch_initcall, it will get called for every kind of
> platform in a multi-board kernel. Another reason to only call it from
> a
> board specific probe function if it really is canyonlands specific.
Right. Time to take canyonlands out of ppc4xx_simple and have its own
board file again. Do the fixups there.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: Rupjyoti Sarmah <rsarmah@amcc.com>,
linuxppc-dev@ozlabs.org, rsarmah@apm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ppc44x:PHY fixup for USB on canyonlands board
Date: Thu, 11 Nov 2010 01:38:51 +1100 [thread overview]
Message-ID: <1289399931.2147.1392.camel@pasglop> (raw)
In-Reply-To: <20101110141914.GC26193@zod.rchland.ibm.com>
On Wed, 2010-11-10 at 09:19 -0500, Josh Boyer wrote:
> With this being an arch_initcall, it will get called for every kind of
> platform in a multi-board kernel. Another reason to only call it from
> a
> board specific probe function if it really is canyonlands specific.
Right. Time to take canyonlands out of ppc4xx_simple and have its own
board file again. Do the fixups there.
Cheers,
Ben.
next prev parent reply other threads:[~2010-11-10 14:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 11:37 [PATCH] ppc44x:PHY fixup for USB on canyonlands board Rupjyoti Sarmah
2010-11-10 14:19 ` Josh Boyer
2010-11-10 14:19 ` Josh Boyer
2010-11-10 14:38 ` Benjamin Herrenschmidt [this message]
2010-11-10 14:38 ` Benjamin Herrenschmidt
2010-11-10 14:43 ` Rupjyoti Sarmah
2010-11-10 15:22 ` Benjamin Herrenschmidt
2010-11-10 15:22 ` Benjamin Herrenschmidt
2010-11-10 14:50 ` Stefan Roese
2010-11-10 14:50 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289399931.2147.1392.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rsarmah@amcc.com \
--cc=rsarmah@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.