From: Stefan Roese <sr@denx.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: linuxppc-dev@ozlabs.org, Rupjyoti Sarmah <rsarmah@amcc.com>,
rsarmah@apm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ppc44x:PHY fixup for USB on canyonlands board
Date: Wed, 10 Nov 2010 15:50:15 +0100 [thread overview]
Message-ID: <201011101550.16093.sr@denx.de> (raw)
In-Reply-To: <201011101137.oAABbFoc015547@amcc.com>
On Wednesday 10 November 2010 12:37:15 Rupjyoti Sarmah wrote:
> This fix is a reset for USB PHY that requires some amount of time for power
> to be stable on Canyonlands.
>
> Signed-off-by: Rupjyoti Sarmah <rsarmah@apm.com>
> ---
> arch/powerpc/boot/dts/canyonlands.dts | 11 ++++
> arch/powerpc/platforms/44x/44x.h | 5 ++
> arch/powerpc/platforms/44x/Kconfig | 7 ++
> arch/powerpc/platforms/44x/Makefile | 1 +
> arch/powerpc/platforms/44x/ppc44x_fixup.c | 90
> +++++++++++++++++++++++++++++ 5 files changed, 114 insertions(+), 0
> deletions(-)
> create mode 100644 arch/powerpc/platforms/44x/ppc44x_fixup.c
>
> diff --git a/arch/powerpc/boot/dts/canyonlands.dts
> b/arch/powerpc/boot/dts/canyonlands.dts index a303703..d6e9ba2 100644
> --- a/arch/powerpc/boot/dts/canyonlands.dts
> +++ b/arch/powerpc/boot/dts/canyonlands.dts
> @@ -171,6 +171,11 @@
> 0x5 0x4>; /* AHBDMA */
> };
>
> + CPLD: cpld@e1000000 {
> + compatible = "apm, ppc460ex-bcsr";
> + reg = <4 0xe1000000 0x9>;
> + };
This node should be moved to the EBC section. It would look something like
this then (note the reg property change here):
CPLD: cpld@2,0 {
...
reg = <2 0x0 0x9>;
};
Cheers,
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Roese <sr@denx.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: Rupjyoti Sarmah <rsarmah@amcc.com>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
rsarmah@apm.com
Subject: Re: [PATCH] ppc44x:PHY fixup for USB on canyonlands board
Date: Wed, 10 Nov 2010 15:50:15 +0100 [thread overview]
Message-ID: <201011101550.16093.sr@denx.de> (raw)
In-Reply-To: <201011101137.oAABbFoc015547@amcc.com>
On Wednesday 10 November 2010 12:37:15 Rupjyoti Sarmah wrote:
> This fix is a reset for USB PHY that requires some amount of time for power
> to be stable on Canyonlands.
>
> Signed-off-by: Rupjyoti Sarmah <rsarmah@apm.com>
> ---
> arch/powerpc/boot/dts/canyonlands.dts | 11 ++++
> arch/powerpc/platforms/44x/44x.h | 5 ++
> arch/powerpc/platforms/44x/Kconfig | 7 ++
> arch/powerpc/platforms/44x/Makefile | 1 +
> arch/powerpc/platforms/44x/ppc44x_fixup.c | 90
> +++++++++++++++++++++++++++++ 5 files changed, 114 insertions(+), 0
> deletions(-)
> create mode 100644 arch/powerpc/platforms/44x/ppc44x_fixup.c
>
> diff --git a/arch/powerpc/boot/dts/canyonlands.dts
> b/arch/powerpc/boot/dts/canyonlands.dts index a303703..d6e9ba2 100644
> --- a/arch/powerpc/boot/dts/canyonlands.dts
> +++ b/arch/powerpc/boot/dts/canyonlands.dts
> @@ -171,6 +171,11 @@
> 0x5 0x4>; /* AHBDMA */
> };
>
> + CPLD: cpld@e1000000 {
> + compatible = "apm, ppc460ex-bcsr";
> + reg = <4 0xe1000000 0x9>;
> + };
This node should be moved to the EBC section. It would look something like
this then (note the reg property change here):
CPLD: cpld@2,0 {
...
reg = <2 0x0 0x9>;
};
Cheers,
Stefan
next prev parent reply other threads:[~2010-11-10 14:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 11:37 [PATCH] ppc44x:PHY fixup for USB on canyonlands board Rupjyoti Sarmah
2010-11-10 14:19 ` Josh Boyer
2010-11-10 14:19 ` Josh Boyer
2010-11-10 14:38 ` Benjamin Herrenschmidt
2010-11-10 14:38 ` Benjamin Herrenschmidt
2010-11-10 14:43 ` Rupjyoti Sarmah
2010-11-10 15:22 ` Benjamin Herrenschmidt
2010-11-10 15:22 ` Benjamin Herrenschmidt
2010-11-10 14:50 ` Stefan Roese [this message]
2010-11-10 14:50 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011101550.16093.sr@denx.de \
--to=sr@denx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rsarmah@amcc.com \
--cc=rsarmah@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.