From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Rupjyoti Sarmah <rsarmah@apm.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH] ppc44x:PHY fixup for USB on canyonlands board
Date: Thu, 11 Nov 2010 02:22:55 +1100 [thread overview]
Message-ID: <1289402575.2147.1399.camel@pasglop> (raw)
In-Reply-To: <59d17e399e4efb295e802572f16cc395@mail.gmail.com>
On Wed, 2010-11-10 at 20:13 +0530, Rupjyoti Sarmah wrote:
> >Is this just for canyonlands? If so, it's probably better off in a
> >caynonlands specific file, or a function that gets called in the common
> >platform file if the model matches canyonlands. It seems a bit overkill
> >to introduce an entire new file and Kconfig option for this.
>
>
> We want to have a file that will have fixup codes for all the ppc44x
> specific boards. Within this ppc44x_fixup.c file we would like to place
> any fixup code that
> might come later for any of the ppc44x based boards. Although I released
> it only with Canyonlands code, it would be ppc44x specific file.
>
> Do let me know if that is ok.
No. You should have a file per board that needs fixup. Take them out of
ppc4xx_simple.c and create a board file.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Rupjyoti Sarmah <rsarmah@apm.com>
Cc: Josh Boyer <jwboyer@linux.vnet.ibm.com>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH] ppc44x:PHY fixup for USB on canyonlands board
Date: Thu, 11 Nov 2010 02:22:55 +1100 [thread overview]
Message-ID: <1289402575.2147.1399.camel@pasglop> (raw)
In-Reply-To: <59d17e399e4efb295e802572f16cc395@mail.gmail.com>
On Wed, 2010-11-10 at 20:13 +0530, Rupjyoti Sarmah wrote:
> >Is this just for canyonlands? If so, it's probably better off in a
> >caynonlands specific file, or a function that gets called in the common
> >platform file if the model matches canyonlands. It seems a bit overkill
> >to introduce an entire new file and Kconfig option for this.
>
>
> We want to have a file that will have fixup codes for all the ppc44x
> specific boards. Within this ppc44x_fixup.c file we would like to place
> any fixup code that
> might come later for any of the ppc44x based boards. Although I released
> it only with Canyonlands code, it would be ppc44x specific file.
>
> Do let me know if that is ok.
No. You should have a file per board that needs fixup. Take them out of
ppc4xx_simple.c and create a board file.
Cheers,
Ben.
next prev parent reply other threads:[~2010-11-10 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 11:37 [PATCH] ppc44x:PHY fixup for USB on canyonlands board Rupjyoti Sarmah
2010-11-10 14:19 ` Josh Boyer
2010-11-10 14:19 ` Josh Boyer
2010-11-10 14:38 ` Benjamin Herrenschmidt
2010-11-10 14:38 ` Benjamin Herrenschmidt
2010-11-10 14:43 ` Rupjyoti Sarmah
2010-11-10 15:22 ` Benjamin Herrenschmidt [this message]
2010-11-10 15:22 ` Benjamin Herrenschmidt
2010-11-10 14:50 ` Stefan Roese
2010-11-10 14:50 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289402575.2147.1399.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rsarmah@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.