From: Joe Perches <joe@perches.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "L. Alberto Giménez" <agimenez@sysvalve.es>,
devel@linuxdriverproject.org,
"Greg Kroah-Hartman" <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Staging: rt2860: include KERN_* in printk
Date: Sun, 12 Dec 2010 22:03:37 -0800 [thread overview]
Message-ID: <1292220217.26970.2.camel@Joe-Laptop> (raw)
In-Reply-To: <20101213055637.GA1620@bicker>
On Mon, 2010-12-13 at 08:56 +0300, Dan Carpenter wrote:
> On Sun, Dec 12, 2010 at 11:04:28AM -0800, Joe Perches wrote:
> > On Sun, 2010-12-12 at 18:56 +0100, L. Alberto Giménez wrote:
> > for(...)
> > []
> > if (i && i % 4 == 0) {
> > printk(KERN_CONT "\n");
> > printk(KERN_DEBUG "Block %x: ", i / 8);
> > }
> > printk(KERN_CONT " %04x", InBuf[2]);
> > }
> > printk(KERN_CONT "\n");
> This is dead code anyway. Just remove the whole set_eFusedump_Proc()
> function.
That was just to be instructive.
I think the entire staging rt2860 is dead code.
next prev parent reply other threads:[~2010-12-13 6:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-12 17:56 [PATCH 0/3] Staging: rt2860: Fix checkpatch issues L. Alberto Giménez
2010-12-12 17:56 ` [PATCH 1/3] Staging: rt2860: Clean spaces before tabs L. Alberto Giménez
2010-12-13 6:05 ` Dan Carpenter
2010-12-12 17:56 ` [PATCH 2/3] Staging: rt2860: Avoid extern in .c file L. Alberto Giménez
2010-12-12 17:56 ` [PATCH 3/3] Staging: rt2860: include KERN_* in printk L. Alberto Giménez
2010-12-12 19:04 ` Joe Perches
2010-12-12 19:25 ` L. Alberto Giménez
2010-12-12 19:46 ` Joe Perches
2010-12-13 0:01 ` L. Alberto Giménez
2010-12-13 3:13 ` Joe Perches
2010-12-13 5:56 ` Dan Carpenter
2010-12-13 6:03 ` Joe Perches [this message]
2010-12-12 23:58 ` [PATCH v2] " L. Alberto Giménez
2010-12-13 18:30 ` Greg KH
2010-12-13 20:24 ` L. Alberto Giménez
2010-12-13 21:15 ` Greg KH
2010-12-13 21:53 ` Joe Perches
2010-12-13 22:17 ` Greg KH
2010-12-14 1:01 ` [PATCH 1/2][RESEND] " L. Alberto Giménez
2010-12-14 1:01 ` [PATCH 2/2][RESEND] Staging: rt2860: Sanitize DBGPRINT_ERR macro L. Alberto Giménez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292220217.26970.2.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=agimenez@sysvalve.es \
--cc=devel@linuxdriverproject.org \
--cc=error27@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.