From: Greg KH <greg@kroah.com>
To: Joe Perches <joe@perches.com>
Cc: "L. Alberto Giménez" <agimenez@sysvalve.es>,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
"Greg Kroah-Hartman" <gregkh@suse.de>
Subject: Re: [PATCH v2] Staging: rt2860: include KERN_* in printk
Date: Mon, 13 Dec 2010 14:17:49 -0800 [thread overview]
Message-ID: <20101213221749.GA22029@kroah.com> (raw)
In-Reply-To: <1292277192.26970.65.camel@Joe-Laptop>
On Mon, Dec 13, 2010 at 01:53:12PM -0800, Joe Perches wrote:
> On Mon, 2010-12-13 at 13:15 -0800, Greg KH wrote:
> > On Mon, Dec 13, 2010 at 09:24:30PM +0100, L. Alberto Giménez wrote:
> > > +#define DBGPRINT_ERR(fmt, args...) printk(KERN_ERR fmt, ##args)
> > > Recommended by Joe. I agree that it is cleaner and more compliant.
> > Not really, it should be replaced with dev_err() or some such universal
> > replacement.
>
> It's used with and without access to a struct device.
>
> The uses that have a struct device available should be
> dev_<foo> and with a struct net_device should be netdev_<foo>
> though that's a wider change.
>
> It's also used in consecutive calls without newline where
> KERN_CONT should be used instead.
>
> Greg, you replied to the list but not the sender.
> Please don't drop the sender.
If you look at the original message I responded to, the sender asked
_not_ to be included based on the headers of the message, so my email
client did the correct thing.
next prev parent reply other threads:[~2010-12-13 22:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-12 17:56 [PATCH 0/3] Staging: rt2860: Fix checkpatch issues L. Alberto Giménez
2010-12-12 17:56 ` [PATCH 1/3] Staging: rt2860: Clean spaces before tabs L. Alberto Giménez
2010-12-13 6:05 ` Dan Carpenter
2010-12-12 17:56 ` [PATCH 2/3] Staging: rt2860: Avoid extern in .c file L. Alberto Giménez
2010-12-12 17:56 ` [PATCH 3/3] Staging: rt2860: include KERN_* in printk L. Alberto Giménez
2010-12-12 19:04 ` Joe Perches
2010-12-12 19:25 ` L. Alberto Giménez
2010-12-12 19:46 ` Joe Perches
2010-12-13 0:01 ` L. Alberto Giménez
2010-12-13 3:13 ` Joe Perches
2010-12-13 5:56 ` Dan Carpenter
2010-12-13 6:03 ` Joe Perches
2010-12-12 23:58 ` [PATCH v2] " L. Alberto Giménez
2010-12-13 18:30 ` Greg KH
2010-12-13 20:24 ` L. Alberto Giménez
2010-12-13 21:15 ` Greg KH
2010-12-13 21:53 ` Joe Perches
2010-12-13 22:17 ` Greg KH [this message]
2010-12-14 1:01 ` [PATCH 1/2][RESEND] " L. Alberto Giménez
2010-12-14 1:01 ` [PATCH 2/2][RESEND] Staging: rt2860: Sanitize DBGPRINT_ERR macro L. Alberto Giménez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101213221749.GA22029@kroah.com \
--to=greg@kroah.com \
--cc=agimenez@sysvalve.es \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.