From: Dan Carpenter <error27@gmail.com>
To: "L. Alberto Giménez" <agimenez@sysvalve.es>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 1/3] Staging: rt2860: Clean spaces before tabs
Date: Mon, 13 Dec 2010 09:05:03 +0300 [thread overview]
Message-ID: <20101213060503.GB1620@bicker> (raw)
In-Reply-To: <1292176591-26081-2-git-send-email-agimenez@sysvalve.es>
On Sun, Dec 12, 2010 at 06:56:29PM +0100, L. Alberto Giménez wrote:
> #define RT_QUERY_SIGNAL_CONTEXT 0x0402
> -#define RT_SET_IAPP_PID 0x0404
> +#define RT_SET_IAPP_PID 0x0404
> #define RT_SET_APD_PID 0x0405
> #define RT_SET_DEL_MAC_ENTRY 0x0406
> #define RT_QUERY_EVENT_TABLE 0x0407
Haha.
Those constants are supposed to be in a line instead of all just
higgledy-piggledy. Please can you fix this properly.
regards,
dan carpenter
next prev parent reply other threads:[~2010-12-13 6:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-12 17:56 [PATCH 0/3] Staging: rt2860: Fix checkpatch issues L. Alberto Giménez
2010-12-12 17:56 ` [PATCH 1/3] Staging: rt2860: Clean spaces before tabs L. Alberto Giménez
2010-12-13 6:05 ` Dan Carpenter [this message]
2010-12-12 17:56 ` [PATCH 2/3] Staging: rt2860: Avoid extern in .c file L. Alberto Giménez
2010-12-12 17:56 ` [PATCH 3/3] Staging: rt2860: include KERN_* in printk L. Alberto Giménez
2010-12-12 19:04 ` Joe Perches
2010-12-12 19:25 ` L. Alberto Giménez
2010-12-12 19:46 ` Joe Perches
2010-12-13 0:01 ` L. Alberto Giménez
2010-12-13 3:13 ` Joe Perches
2010-12-13 5:56 ` Dan Carpenter
2010-12-13 6:03 ` Joe Perches
2010-12-12 23:58 ` [PATCH v2] " L. Alberto Giménez
2010-12-13 18:30 ` Greg KH
2010-12-13 20:24 ` L. Alberto Giménez
2010-12-13 21:15 ` Greg KH
2010-12-13 21:53 ` Joe Perches
2010-12-13 22:17 ` Greg KH
2010-12-14 1:01 ` [PATCH 1/2][RESEND] " L. Alberto Giménez
2010-12-14 1:01 ` [PATCH 2/2][RESEND] Staging: rt2860: Sanitize DBGPRINT_ERR macro L. Alberto Giménez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101213060503.GB1620@bicker \
--to=error27@gmail.com \
--cc=agimenez@sysvalve.es \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.