From: Greg KH <greg@kroah.com>
To: "L. Alberto Giménez" <agimenez@sysvalve.es>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH v2] Staging: rt2860: include KERN_* in printk
Date: Mon, 13 Dec 2010 10:30:32 -0800 [thread overview]
Message-ID: <20101213183032.GA6147@kroah.com> (raw)
In-Reply-To: <1292198324-12072-1-git-send-email-agimenez@sysvalve.es>
On Mon, Dec 13, 2010 at 12:58:44AM +0100, L. Alberto Giménez wrote:
> Fix checkpatch complains.
>
> The change of the DBGPRINT_ERR macro causes the change on the callers.
What change?
>
> Signed-off-by: L. Alberto Giménez <agimenez@sysvalve.es>
> ---
> drivers/staging/rt2860/chip/rtmp_phy.h | 14 ++++++------
> drivers/staging/rt2860/common/ba_action.c | 6 ++--
> drivers/staging/rt2860/common/cmm_data.c | 2 +-
> drivers/staging/rt2860/common/cmm_mac_pci.c | 10 ++++----
> drivers/staging/rt2860/common/cmm_mac_usb.c | 2 +-
> drivers/staging/rt2860/common/cmm_wpa.c | 22 +++++++-----------
> drivers/staging/rt2860/common/ee_efuse.c | 15 +++++++++---
> drivers/staging/rt2860/common/mlme.c | 13 +++++------
> drivers/staging/rt2860/common/rt_rf.c | 3 +-
> drivers/staging/rt2860/common/rtmp_init.c | 24 ++++++++-----------
> drivers/staging/rt2860/common/rtmp_mcu.c | 4 +-
> drivers/staging/rt2860/common/spectrum.c | 2 +-
> drivers/staging/rt2860/pci_main_dev.c | 2 +-
> drivers/staging/rt2860/rt_linux.c | 21 ++++++++---------
> drivers/staging/rt2860/rt_linux.h | 6 +----
> drivers/staging/rt2860/rt_main_dev.c | 2 +-
> drivers/staging/rt2860/rt_usb.c | 32 +++++++++++++-------------
> drivers/staging/rt2860/sta/assoc.c | 2 +-
> drivers/staging/rt2860/sta/auth.c | 3 +-
> drivers/staging/rt2860/sta/connect.c | 3 +-
> drivers/staging/rt2860/sta/rtmp_data.c | 2 +-
> drivers/staging/rt2860/sta/sync.c | 6 ++--
> drivers/staging/rt2860/usb_main_dev.c | 12 +++++-----
> 23 files changed, 99 insertions(+), 109 deletions(-)
That's a lot of different changes all in one patch. Care to break it up
into a few different patches so it makes more sense?
thanks,
greg k-h
next prev parent reply other threads:[~2010-12-13 18:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-12 17:56 [PATCH 0/3] Staging: rt2860: Fix checkpatch issues L. Alberto Giménez
2010-12-12 17:56 ` [PATCH 1/3] Staging: rt2860: Clean spaces before tabs L. Alberto Giménez
2010-12-13 6:05 ` Dan Carpenter
2010-12-12 17:56 ` [PATCH 2/3] Staging: rt2860: Avoid extern in .c file L. Alberto Giménez
2010-12-12 17:56 ` [PATCH 3/3] Staging: rt2860: include KERN_* in printk L. Alberto Giménez
2010-12-12 19:04 ` Joe Perches
2010-12-12 19:25 ` L. Alberto Giménez
2010-12-12 19:46 ` Joe Perches
2010-12-13 0:01 ` L. Alberto Giménez
2010-12-13 3:13 ` Joe Perches
2010-12-13 5:56 ` Dan Carpenter
2010-12-13 6:03 ` Joe Perches
2010-12-12 23:58 ` [PATCH v2] " L. Alberto Giménez
2010-12-13 18:30 ` Greg KH [this message]
2010-12-13 20:24 ` L. Alberto Giménez
2010-12-13 21:15 ` Greg KH
2010-12-13 21:53 ` Joe Perches
2010-12-13 22:17 ` Greg KH
2010-12-14 1:01 ` [PATCH 1/2][RESEND] " L. Alberto Giménez
2010-12-14 1:01 ` [PATCH 2/2][RESEND] Staging: rt2860: Sanitize DBGPRINT_ERR macro L. Alberto Giménez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101213183032.GA6147@kroah.com \
--to=greg@kroah.com \
--cc=agimenez@sysvalve.es \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.