From: Tejun Heo <tj@kernel.org>
To: linux-kernel@vger.kernel.org, x86@kernel.org, yinghai@kernel.org,
brgerst@gmail.com, gorcunov@gmail.com, shaohui.zheng@intel.com,
rientjes@google.com, mingo@elte.hu, hpa@linux.intel.com
Subject: [PATCHSET x86/numa] x86-64, NUMA: bring sanity to NUMA configuration
Date: Sat, 12 Feb 2011 18:10:37 +0100 [thread overview]
Message-ID: <1297530663-26234-1-git-send-email-tj@kernel.org> (raw)
Hello,
Currently, x86-64 NUMA configuration is unnecessarily complicated with
srat_64, amdtopology_64, dummy and emulation all doing about the same
things in slightly different ways. This makes the code difficult to
comprehend, maintain and extend.
The worst offender is the NUMA emulation which maps and reverse maps
things in quite chaotic ways. For example, CPU node remapping is done
by finding out the node the CPU is mapped to, taking the start address
and looking up the containing physical node, and then again looking
for emulated nodes which fall in the physical node. Another
interesting example is node distance remapping whem the system is
using amdtopology - it generates pseudo ACPI PXM mapping.
This is the first of two patchset series. This one cleans up x86-64
NUMA configuration so that specific implementations - srat,
amdtopology and dummy - only have to supply the information about the
actul configuration. All the mangling and massaging are done inside
numa_64.c proper using the provided information.
This patchset implements all the infrastructure to make NUMA emulation
sane but doesn't actually update NUMA emulation. It will be done by
the next patchset. As it still retains old code and glues to keep
them working, LOC is increased by 60 lines. After the second
patchset, the net LOC change will be -123 lines.
Once the x86-64 update is settled, x86-32 will be moved over to share
the new infrastructure.
This patchset is on top of the current tip/x86/numa[1] and contains
the following 26 patches.
Tested on an opteron NUMA machine which can do both ACPI and AMD
configs. All NUMA configs, emulation, !NUMA and UP work as expected.
0001-x86-64-NUMA-Make-dummy-node-initialization-path-simi.patch
0002-x86-64-NUMA-Simplify-hotplug-node-handling-in-acpi_n.patch
0003-x86-64-NUMA-Drop-start-last_pfn-from-initmem_init.patch
0004-x86-64-NUMA-Unify-acpi-amd-_-numa_init-scan_nodes-ar.patch
0005-x86-64-NUMA-Wrap-acpi_numa_init-so-that-failure-can-.patch
0006-x86-64-NUMA-Move-_numa_init-invocations-into-initmem.patch
0007-x86-64-NUMA-Restructure-initmem_init.patch
0008-x86-64-NUMA-Use-common-cpu-mem-_nodes_parsed.patch
0009-x86-64-NUMA-Remove-local-variable-found-from-amd_num.patch
0010-x86-64-NUMA-Move-apicid-to-numa-mapping-initializati.patch
0011-x86-64-NUMA-Use-common-numa_nodes.patch
0012-x86-64-NUMA-Kill-acpi-amd-_get_nodes.patch
0013-x86-64-NUMA-Factor-out-memblk-handling-into-numa_-ad.patch
0014-x86-64-NUMA-Unify-use-of-memblk-in-all-init-methods.patch
0015-x86-64-NUMA-Unify-the-rest-of-memblk-registration.patch
0016-x86-64-NUMA-Kill-acpi-amd-dummy-_scan_nodes.patch
0017-x86-64-NUMA-Remove-NULL-nodeids-handling-from-comput.patch
0018-x86-64-NUMA-Introduce-struct-numa_meminfo.patch
0019-x86-64-NUMA-Separate-out-numa_cleanup_meminfo.patch
0020-x86-64-NUMA-make-numa_cleanup_meminfo-prettier.patch
0021-x86-64-NUMA-consolidate-and-improve-memblk-sanity-ch.patch
0022-x86-64-NUMA-Add-common-find_node_by_addr.patch
0023-x86-64-NUMA-kill-numa_nodes.patch
0024-x86-64-NUMA-Rename-cpu_nodes_parsed-to-numa_nodes_pa.patch
0025-x86-64-NUMA-Kill-mem_nodes_parsed.patch
0026-x86-64-NUMA-Implement-generic-node-distance-handling.patch
The patchset is also available in the following git branch.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git x86_64-numa-unify
Diffstat follows.
arch/x86/include/asm/acpi.h | 6
arch/x86/include/asm/amd_nb.h | 4
arch/x86/include/asm/numa_64.h | 11
arch/x86/include/asm/page_types.h | 3
arch/x86/include/asm/topology.h | 2
arch/x86/kernel/setup.c | 16 -
arch/x86/mm/amdtopology_64.c | 117 ++------
arch/x86/mm/init_64.c | 5
arch/x86/mm/numa_64.c | 507 ++++++++++++++++++++++++++++++++------
arch/x86/mm/srat_64.c | 290 +--------------------
drivers/acpi/numa.c | 9
11 files changed, 515 insertions(+), 455 deletions(-)
Thanks.
--
tejun
[1] eff9073790e1286aa12bf1c65814d3e0132b12e1 (x86: Rename incorrectly
named parameter of numa_cpu_node())
next reply other threads:[~2011-02-12 17:11 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-12 17:10 Tejun Heo [this message]
2011-02-12 17:10 ` [PATCH 01/26] x86-64, NUMA: Make dummy node initialization path similar to non-dummy ones Tejun Heo
2011-02-12 17:52 ` Yinghai Lu
2011-02-12 17:10 ` [PATCH 02/26] x86-64, NUMA: Simplify hotplug node handling in acpi_numa_memory_affinity_init() Tejun Heo
2011-02-12 17:47 ` Yinghai Lu
2011-02-12 17:56 ` Tejun Heo
2011-02-12 18:04 ` Yinghai Lu
2011-02-12 18:06 ` Tejun Heo
2011-02-12 18:13 ` Yinghai Lu
2011-02-14 11:25 ` Tejun Heo
2011-02-14 16:12 ` Yinghai Lu
2011-02-12 17:10 ` [PATCH 03/26] x86-64, NUMA: Drop @start/last_pfn from initmem_init() Tejun Heo
2011-02-12 17:58 ` Yinghai Lu
2011-02-12 18:03 ` Tejun Heo
2011-02-14 13:50 ` [PATCH UPDATED 03/26] x86, NUMA: Drop @start/last_pfn from initmem_init() initmem_init() Tejun Heo
2011-02-14 14:20 ` Ingo Molnar
2011-02-14 14:58 ` Tejun Heo
2011-02-14 19:03 ` Yinghai Lu
2011-02-14 19:31 ` Tejun Heo
2011-02-15 2:29 ` Ingo Molnar
2011-02-12 17:10 ` [PATCH 04/26] x86-64, NUMA: Unify {acpi|amd}_{numa_init|scan_nodes}() arguments and return values Tejun Heo
2011-02-12 18:39 ` Yinghai Lu
2011-02-14 11:29 ` Tejun Heo
2011-02-14 16:14 ` Yinghai Lu
2011-02-14 16:18 ` Tejun Heo
2011-02-14 18:00 ` Yinghai Lu
2011-02-12 17:10 ` [PATCH 05/26] x86-64, NUMA: Wrap acpi_numa_init() so that failure can be indicated by return value Tejun Heo
2011-02-12 17:10 ` [PATCH 06/26] x86-64, NUMA: Move *_numa_init() invocations into initmem_init() Tejun Heo
2011-02-14 6:10 ` Ankita Garg
2011-02-14 11:09 ` Tejun Heo
2011-02-14 13:51 ` [PATCH UPDATED 06/26] x86, " Tejun Heo
2011-02-14 14:21 ` Ingo Molnar
2011-02-12 17:10 ` [PATCH 07/26] x86-64, NUMA: Restructure initmem_init() Tejun Heo
2011-02-12 17:10 ` [PATCH 08/26] x86-64, NUMA: Use common {cpu|mem}_nodes_parsed Tejun Heo
2011-02-12 17:10 ` [PATCH 09/26] x86-64, NUMA: Remove local variable found from amd_numa_init() Tejun Heo
2011-02-12 17:10 ` [PATCH 10/26] x86-64, NUMA: Move apicid to numa mapping initialization from amd_scan_nodes() to amd_numa_init() Tejun Heo
2011-02-14 22:59 ` Cyrill Gorcunov
2011-02-15 9:36 ` Tejun Heo
2011-02-15 17:31 ` Cyrill Gorcunov
2011-02-15 17:54 ` Yinghai Lu
2011-02-15 18:01 ` Cyrill Gorcunov
2011-02-15 18:27 ` Cyrill Gorcunov
2011-02-15 19:41 ` Yinghai Lu
2011-02-12 17:10 ` [PATCH 11/26] x86-64, NUMA: Use common numa_nodes[] Tejun Heo
2011-02-12 17:10 ` [PATCH 12/26] x86-64, NUMA: Kill {acpi|amd}_get_nodes() Tejun Heo
2011-02-12 17:10 ` [PATCH 13/26] x86-64, NUMA: Factor out memblk handling into numa_{add|register}_memblk() Tejun Heo
2011-02-12 17:10 ` [PATCH 14/26] x86-64, NUMA: Unify use of memblk in all init methods Tejun Heo
2011-02-12 17:10 ` [PATCH 15/26] x86-64, NUMA: Unify the rest of memblk registration Tejun Heo
2011-02-13 0:45 ` Yinghai Lu
2011-02-14 11:32 ` Tejun Heo
2011-02-14 16:08 ` Yinghai Lu
2011-02-14 16:12 ` Tejun Heo
2011-02-14 16:17 ` Yinghai Lu
2011-02-14 16:22 ` Tejun Heo
2011-02-14 18:14 ` Yinghai Lu
2011-02-14 18:27 ` Tejun Heo
2011-02-14 19:07 ` Yinghai Lu
2011-02-14 19:30 ` Tejun Heo
2011-02-14 19:35 ` Yinghai Lu
2011-02-15 9:11 ` Tejun Heo
2011-02-15 9:43 ` Ingo Molnar
2011-02-15 16:49 ` Tejun Heo
2011-02-16 8:41 ` Ingo Molnar
2011-02-16 8:48 ` Ingo Molnar
2011-02-16 9:01 ` Tejun Heo
2011-02-16 9:31 ` Ingo Molnar
2011-02-12 17:10 ` [PATCH 16/26] x86-64, NUMA: Kill {acpi|amd|dummy}_scan_nodes() Tejun Heo
2011-02-12 17:10 ` [PATCH 17/26] x86-64, NUMA: Remove %NULL @nodeids handling from compute_hash_shift() Tejun Heo
2011-02-12 17:10 ` [PATCH 18/26] x86-64, NUMA: Introduce struct numa_meminfo Tejun Heo
2011-02-12 17:10 ` [PATCH 19/26] x86-64, NUMA: Separate out numa_cleanup_meminfo() Tejun Heo
2011-02-12 17:10 ` [PATCH 20/26] x86-64, NUMA: make numa_cleanup_meminfo() prettier Tejun Heo
2011-02-12 17:10 ` [PATCH 21/26] x86-64, NUMA: consolidate and improve memblk sanity checks Tejun Heo
2011-02-12 17:10 ` [PATCH 22/26] x86-64, NUMA: Add common find_node_by_addr() Tejun Heo
2011-02-12 17:11 ` [PATCH 23/26] x86-64, NUMA: kill numa_nodes[] Tejun Heo
2011-02-12 17:11 ` [PATCH 24/26] x86-64, NUMA: Rename cpu_nodes_parsed to numa_nodes_parsed Tejun Heo
2011-02-12 17:11 ` [PATCH 25/26] x86-64, NUMA: Kill mem_nodes_parsed Tejun Heo
2011-02-12 17:11 ` [PATCH 26/26] x86-64, NUMA: Implement generic node distance handling Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297530663-26234-1-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=brgerst@gmail.com \
--cc=gorcunov@gmail.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rientjes@google.com \
--cc=shaohui.zheng@intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.