From: Ben Hutchings <bhutchings@solarflare.com>
To: aquini@linux.com
Cc: kernel-janitors@vger.kernel.org, Jay Vosburgh <fubar@us.ibm.com>,
David Miller <davem@davemloft.net>,
Andy Gospodarek <andy@greyhouse.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] bond_3ad.c: switch MAC_ADDRESS_COMPARE macro for
Date: Tue, 31 May 2011 01:10:22 +0000 [thread overview]
Message-ID: <1306804222.4277.66.camel@localhost> (raw)
In-Reply-To: <20110531004418.GA22937@optiplex.tchesoft.com>
On Mon, 2011-05-30 at 21:44 -0300, Rafael Aquini wrote:
> Converts all uses of MAC_ADDRESS_COMPARE macro to compare_ether_addr() and delete the macro.
[...]
Given all the casts you have to add, this doesn't seem like an
improvement.
How about replacing struct mac_addr with u8[ETH_ALEN] at the same time?
You should also be able to get rid of null_mac_addr and use
is_zero_ether_addr() instead.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
WARNING: multiple messages have this Message-ID (diff)
From: Ben Hutchings <bhutchings@solarflare.com>
To: aquini@linux.com
Cc: kernel-janitors@vger.kernel.org, Jay Vosburgh <fubar@us.ibm.com>,
David Miller <davem@davemloft.net>,
Andy Gospodarek <andy@greyhouse.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] bond_3ad.c: switch MAC_ADDRESS_COMPARE macro for compare_ether_addr()
Date: Tue, 31 May 2011 02:10:22 +0100 [thread overview]
Message-ID: <1306804222.4277.66.camel@localhost> (raw)
In-Reply-To: <20110531004418.GA22937@optiplex.tchesoft.com>
On Mon, 2011-05-30 at 21:44 -0300, Rafael Aquini wrote:
> Converts all uses of MAC_ADDRESS_COMPARE macro to compare_ether_addr() and delete the macro.
[...]
Given all the casts you have to add, this doesn't seem like an
improvement.
How about replacing struct mac_addr with u8[ETH_ALEN] at the same time?
You should also be able to get rid of null_mac_addr and use
is_zero_ether_addr() instead.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-05-31 1:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 0:44 [PATCH] bond_3ad.c: switch MAC_ADDRESS_COMPARE macro for Rafael Aquini
2011-05-31 0:44 ` [PATCH] bond_3ad.c: switch MAC_ADDRESS_COMPARE macro for compare_ether_addr() Rafael Aquini
2011-05-31 1:10 ` Ben Hutchings [this message]
2011-05-31 1:10 ` Ben Hutchings
2011-05-31 7:17 ` walter harms
2011-05-31 7:17 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306804222.4277.66.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=andy@greyhouse.net \
--cc=aquini@linux.com \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.